Re: Review Request 71518: Added the test `GarbageCollectorIntegrationTest.ROOT_OrphanContainer`.

2019-09-19 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71518/#review217876 --- Patch looks great! Reviews applied: [71501, 71518] Passed

Re: Review Request 71518: Added the test `GarbageCollectorIntegrationTest.ROOT_OrphanContainer`.

2019-09-19 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71518/ --- (Updated Sept. 20, 2019, 11:06 a.m.) Review request for mesos and Gilbert

Re: Review Request 71479: Added a test to ensure resources are recovered during agent removal.

2019-09-19 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71479/#review217875 --- Patch looks great! Reviews applied: [71515, 71516, 71476, 71479]

Re: Review Request 71520: Fixed inefficient `hashmap` access patterns.

2019-09-19 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71520/#review217874 --- Ship it! Nit: There's a typo in the third-last line of the

Re: Review Request 71476: Simplified recover resources when removing frameworks or agents.

2019-09-19 Thread Meng Zhu
> On Sept. 18, 2019, 10:43 a.m., Andrei Sekretenko wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Lines 1489-1494 (original), 1523-1528 (patched) > > > > > > Previously, this code was executed even in

Re: Review Request 71476: Simplified recover resources when removing frameworks or agents.

2019-09-19 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71476/ --- (Updated Sept. 19, 2019, 5 p.m.) Review request for mesos, Andrei Sekretenko

Re: Review Request 71512: Windows: Libprocess: Fixed parallel test execution.

2019-09-19 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71512/#review217870 --- Patch looks great! Reviews applied: [71510, 71511, 71512]

Re: Review Request 71497: Introduced new names for SSL-related libprocess flags.

2019-09-19 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71497/#review217865 --- Patch looks great! Reviews applied: [71496, 71497] Passed

Re: Review Request 71511: Windows: Stout: Fixed parallel test execution.

2019-09-19 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71511/ --- (Updated Sept. 19, 2019, 11:30 a.m.) Review request for mesos, Benjamin

Re: Review Request 71512: Windows: Libprocess: Fixed parallel test execution.

2019-09-19 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71512/ --- (Updated Sept. 19, 2019, 11:30 a.m.) Review request for mesos, Benjamin

Re: Review Request 71510: Windows: Fixed parallel test execution.

2019-09-19 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71510/ --- (Updated Sept. 19, 2019, 11:30 a.m.) Review request for mesos, Benjamin

Re: Review Request 71510: Windows: Fixed parallel test execution.

2019-09-19 Thread Joseph Wu
> On Sept. 19, 2019, 3:25 a.m., Benjamin Bannier wrote: > > cmake/MesosConfigure.cmake > > Lines 55 (patched) > > > > > > A feature of the current parallel test setup is that users can > > overwrite `TEST_DRIVER` at

Re: Review Request 71520: Fixed inefficient `hashmap` access patterns.

2019-09-19 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71520/#review217860 --- Patch looks great! Reviews applied: [71519, 71520] Passed

Re: Review Request 71510: Windows: Fixed parallel test execution.

2019-09-19 Thread Benjamin Bannier
> On Sept. 19, 2019, 12:25 p.m., Benjamin Bannier wrote: > > cmake/MesosConfigure.cmake > > Lines 55 (patched) > > > > > > A feature of the current parallel test setup is that users can > > overwrite `TEST_DRIVER`

Re: Review Request 71518: Added the test `GarbageCollectorIntegrationTest.OrphanContainer`.

2019-09-19 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71518/#review217854 --- Bad patch! Reviews applied: [71501, 71518] Failed command:

Re: Review Request 71497: Introduced new names for SSL-related libprocess flags.

2019-09-19 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71497/ --- (Updated Sept. 19, 2019, 2:35 p.m.) Review request for mesos, Greg Mann and

Re: Review Request 71510: Windows: Fixed parallel test execution.

2019-09-19 Thread Joseph Wu
> On Sept. 19, 2019, 3:25 a.m., Benjamin Bannier wrote: > > cmake/MesosConfigure.cmake > > Lines 55 (patched) > > > > > > A feature of the current parallel test setup is that users can > > overwrite `TEST_DRIVER` at

Review Request 71519: Fixed inefficient `hashmap` access patterns.

2019-09-19 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71519/ --- Review request for mesos, Benno Evers and Benjamin Mahler. Bugs: MESOS-9948

Review Request 71520: Fixed inefficient `hashmap` access patterns.

2019-09-19 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71520/ --- Review request for mesos, Benno Evers and Benjamin Mahler. Bugs: MESOS-9948

Re: Review Request 71478: Windows: Moved definition out of inline function call.

2019-09-19 Thread Till Toenshoff via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71478/#review217850 --- Ship it! Ship It! - Till Toenshoff On Sept. 12, 2019, 7:35

Review Request 71518: Added the test `GarbageCollectorIntegrationTest.OrphanContainer`.

2019-09-19 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71518/ --- Review request for mesos and Gilbert Song. Bugs: MESOS-9966

Re: Review Request 71510: Windows: Fixed parallel test execution.

2019-09-19 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71510/#review217848 --- cmake/MesosConfigure.cmake Lines 55 (patched)

Re: Review Request 71441: Fixed URI stringification.

2019-09-19 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71441/#review217847 --- Patch looks great! Reviews applied: [71441] Passed command: