Re: Review Request 71750: Improved performance of v1 operator API GetAgents call.

2019-11-20 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71750/#review218725 --- Fix it, then Ship it! src/master/http.cpp Lines 2141

Re: Review Request 71741: Updated operator API documention to use rereservation format.

2019-11-20 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71741/#review218724 --- Bad review! Reviews applied: [71741, 71739, 71725, 71729]

Re: Review Request 71787: Added end-to-end test for reservation update with persistent volume.

2019-11-20 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71787/ --- (Updated Nov. 20, 2019, 2:49 p.m.) Review request for mesos and Benjamin

Re: Review Request 71741: Updated operator API documention to use rereservation format.

2019-11-20 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71741/#review218721 --- Fix it, then Ship it! docs/operator-http-api.md Lines 1869

Re: Review Request 71739: Used post-reservation refinement format in some operator API docs.

2019-11-20 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71739/ --- (Updated Nov. 20, 2019, 3:16 p.m.) Review request for mesos and Benno Evers.

Re: Review Request 71741: Updated operator API documention to use rereservation format.

2019-11-20 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71741/ --- (Updated Nov. 20, 2019, 3:17 p.m.) Review request for mesos and Benno Evers.

Re: Review Request 71787: Added end-to-end test for reservation update with persistent volume.

2019-11-20 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71787/#review218720 --- src/tests/persistent_volume_endpoints_tests.cpp Lines 347

Re: Review Request 71787: Added end-to-end test for reservation update with persistent volume.

2019-11-20 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71787/ --- (Updated Nov. 20, 2019, 1:07 p.m.) Review request for mesos and Benjamin

Re: Review Request 71785: Removed check when validating reservations.

2019-11-20 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71785/#review218718 --- Ship it! Like discussed offline, let's add a test as part of

Re: Review Request 71790: SSL Socket: Implemented sendfile.

2019-11-20 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71790/#review218714 --- Patch looks great! Reviews applied: [71659, 71764, 71660, 71661,