Re: Review Request 71665: SSL Wrapper: Implemented socket connection and handshake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71665/#review218881 --- 3rdparty/libprocess/src/ssl/socket_wrapper.cpp Lines 449

Re: Review Request 71827: Improved operator api subscribe initial payload performance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71827/#review218887 --- Patch looks great! Reviews applied: [71823, 71824, 71825, 71826,

Re: Review Request 71826: Updated StreamingHttpConnection to allow writing serialized records.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71826/ --- (Updated Dec. 3, 2019, 5:27 a.m.) Review request for mesos, Andrei Sekretenko

Re: Review Request 71825: Updated mesos code to work against recordio encoder/decoder changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71825/ --- (Updated Dec. 3, 2019, 5:26 a.m.) Review request for mesos, Andrei Sekretenko

Re: Review Request 71824: Updated stout recordio encoder/decoder to be lower-level.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71824/ --- (Updated Dec. 3, 2019, 5:25 a.m.) Review request for mesos, Andrei Sekretenko

Re: Review Request 71824: Updated stout recordio encoder/decoder to be lower-level.

> On Dec. 2, 2019, 12:49 p.m., Andrei Sekretenko wrote: > > 3rdparty/stout/include/stout/recordio.hpp > > Line 82 (original) > > > > > > Now that Encoder has no state, did you consider dropping `class > > Encoder`

Re: Review Request 71827: Improved operator api subscribe initial payload performance.

> On Dec. 2, 2019, 1:23 p.m., Andrei Sekretenko wrote: > > src/master/http.cpp > > Lines 444 (patched) > > > > > > Shouldn't we delete `_getState`, `_getFrameworks` and so on altogether? > > > > They are

Re: Review Request 71825: Updated mesos code to work against recordio encoder/decoder changes.

> On Dec. 2, 2019, 2:13 p.m., Andrei Sekretenko wrote: > > Overall makes sense, even without the depending patches. I would say that > > the need to feed deserializing functor into RecordIO decoder surprised me > > before, to some degree. > > > > Might require adjustment if you decide to act

Re: Review Request 71823: Simplified V0 -> V1 direct serialization logic.

> On Dec. 2, 2019, 11:46 a.m., Andrei Sekretenko wrote: > > Overall looks good and makes things much more readable! > > > > The only general concern that I see is the notice in the > > `wire_format_lite.h` that states that `WireFormatLite` "must not be called > > directly by clients." > >

Re: Review Request 71823: Simplified V0 -> V1 direct serialization logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71823/ --- (Updated Dec. 3, 2019, 4:13 a.m.) Review request for mesos, Andrei Sekretenko

Re: Review Request 71665: SSL Wrapper: Implemented socket connection and handshake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71665/#review218813 --- 3rdparty/libprocess/src/ssl/socket_wrapper.cpp Lines 369

Re: Review Request 71825: Updated mesos code to work against recordio encoder/decoder changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71825/#review218879 --- Overall makes sense, even without the depending patches. I would

Re: Review Request 71827: Improved operator api subscribe initial payload performance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71827/#review218878 --- Fix it, then Ship it! src/master/http.cpp Lines 444 (patched)

Re: Review Request 71826: Updated StreamingHttpConnection to allow writing serialized records.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71826/#review218877 --- Ship it! Ship It! - Andrei Sekretenko On Nov. 26, 2019,

Re: Review Request 71824: Updated stout recordio encoder/decoder to be lower-level.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71824/#review218876 --- 3rdparty/stout/include/stout/recordio.hpp Line 82 (original)

Re: Review Request 71823: Simplified V0 -> V1 direct serialization logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71823/#review218874 --- Fix it, then Ship it! Overall looks good and makes things much