Re: Review Request 71790: SSL Socket: Implemented sendfile.

2019-12-10 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71790/#review218992 --- Patch looks great! Reviews applied: [71659, 71764, 71660, 71661,

Re: Review Request 71790: SSL Socket: Implemented sendfile.

2019-12-10 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71790/ --- (Updated Dec. 10, 2019, 3:55 p.m.) Review request for mesos, Benno Evers, Benja

Re: Review Request 71666: SSL Wrapper: Implemented send/recv and shutdown.

2019-12-10 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71666/ --- (Updated Dec. 10, 2019, 3:55 p.m.) Review request for mesos, Benno Evers, Benja

Re: Review Request 71665: SSL Wrapper: Implemented socket connection and handshake.

2019-12-10 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71665/ --- (Updated Dec. 10, 2019, 3:53 p.m.) Review request for mesos, Benno Evers, Benja

Re: Review Request 71664: SSL Wrapper: Implemented BIO for SSL socket wrapper.

2019-12-10 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71664/ --- (Updated Dec. 10, 2019, 3:52 p.m.) Review request for mesos, Benno Evers, Benja

Re: Review Request 71660: SSL Wrapper: Stubbed out a SSL socket class.

2019-12-10 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71660/ --- (Updated Dec. 10, 2019, 3:50 p.m.) Review request for mesos, Benno Evers, Benja

Re: Review Request 71661: Added missing header guards for poll_socket.hpp.

2019-12-10 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71661/ --- (Updated Dec. 10, 2019, 3:50 p.m.) Review request for mesos, Benno Evers, Benja

Re: Review Request 71664: SSL Wrapper: Implemented BIO for SSL socket wrapper.

2019-12-10 Thread Joseph Wu
> On Nov. 26, 2019, 11:38 a.m., Greg Mann wrote: > > 3rdparty/libprocess/src/ssl/socket_wrapper.cpp > > Lines 212-215 (patched) > > > > > > Are we sure that there are no ill effects of immediately returning 1 > > he