Re: Review Request 71858: WIP: Set resource limits when launching executor container.

> On Jan. 8, 2020, 5:43 a.m., Greg Mann wrote: > > src/slave/slave.cpp > > Lines 3623 (patched) > > > > > > Should this be an `Option`? So that we can only set > > `containerConfig.limits` when limits have

Re: Review Request 71858: WIP: Set resource limits when launching executor container.

> On Jan. 8, 2020, 5:43 a.m., Greg Mann wrote: > > src/slave/slave.cpp > > Lines 3623 (patched) > > > > > > Should this be an `Option`? So that we can only set > > `containerConfig.limits` when limits have

Re: Review Request 71858: WIP: Set resource limits when launching executor container.

> On Jan. 8, 2020, 5:43 a.m., Greg Mann wrote: > > src/slave/slave.cpp > > Lines 3140-3201 (patched) > > > > > > I think maybe this logic could be easier to read if we do something > > like: > > > > ``` >

Review Request 71991: Added the 'TASK_RESOURCE_LIMITS' agent capability.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71991/ --- Review request for mesos, Andrei Budnik and Qian Zhang. Bugs: MESOS-10044

Re: Review Request 71944: Set container process's OOM score adjust.

> On Jan. 7, 2020, 11:07 p.m., Greg Mann wrote: > > src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp > > Lines 199 (patched) > > > > > > Do we really want to do this? My concern is that this

Re: Review Request 71858: WIP: Set resource limits when launching executor container.

> On Jan. 7, 2020, 9:43 p.m., Greg Mann wrote: > > src/slave/slave.cpp > > Lines 3140-3201 (patched) > > > > > > I think maybe this logic could be easier to read if we do something > > like: > > > > ``` >

Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71965/#review219217 --- src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp Line

Re: Review Request 71983: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71983/#review219238 --- Bad patch! Reviews applied: [71855, 71931, 71856, 71858, 71884,

Re: Review Request 71966: Cgroups isolator: added support for nested cgroups during recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71966/#review219236 --- Patch looks great! Reviews applied: [71855, 71931, 71856, 71858,

[GitHub] [mesos] bbannier merged pull request #349: site: update the year to 2020 in the footer

bbannier merged pull request #349: site: update the year to 2020 in the footer URL: https://github.com/apache/mesos/pull/349 This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: Review Request 71987: Disabled `DefaultExecutorTest.DomainSockets` on non-Linux platforms.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71987/#review219235 --- Ship it! Ship It! - Benno Evers On Jan. 13, 2020, 10:22

Review Request 71987: Disabled `DefaultExecutorTest.DomainSockets` on non-Linux platforms.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71987/ --- Review request for mesos and Benno Evers. Repository: mesos Description

Re: Review Request 71986: Removed redundant calls to `c_str` flagged by mesos-tidy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71986/#review219234 --- Ship it! Ship It! - Till Toenshoff On Jan. 13, 2020, 9:49

Re: Review Request 71985: Properly initialized dummy variable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71985/#review219233 --- Ship it! Ship It! - Till Toenshoff On Jan. 13, 2020, 9:48

Review Request 71986: Removed redundant calls to `c_str` flagged by mesos-tidy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71986/ --- Review request for mesos and Benno Evers. Repository: mesos Description

Review Request 71985: Properly initialized dummy variable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71985/ --- Review request for mesos and Benno Evers. Repository: mesos Description

Re: Review Request 71983: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71983/ --- (Updated Jan. 13, 2020, 4:06 p.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 71956: Added a test `ROOT_CGROUPS_CFS_CommandTaskLimits`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71956/ --- (Updated Jan. 13, 2020, 4:06 p.m.) Review request for mesos, Andrei Budnik and