ut of the dependency chain though because I wanted to make it explicit
that this review should not be slurped up when Joris applies them.
- Alex
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39377/#review102974
-------
On Oct. 16, 2015, 7:50 p.m., Alex Clemmer wrote:
>
> -
d e-mail. To reply, visit:
https://reviews.apache.org/r/39380/#review102978
-------
On Oct. 16, 2015, 7:50 p.m., Alex Clemmer wrote:
>
> ---
> This is an automatically generat
/stout/windows/os.hpp
2b0966889af73238a08e29f1136d0ce286a0ffda
Diff: https://reviews.apache.org/r/39382/diff/
Testing
---
CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015
on Windows 10.
Autotools `make check` on Ubuntu 15.
Thanks,
Alex Clemmer
led to apply patch
Looks like someone pushed to master after I rebased. Sorry!
- Alex
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39382/#review102993
---------
`make check` on Ubuntu 15.
Thanks,
Alex Clemmer
stout/windows/os.hpp
2b0966889af73238a08e29f1136d0ce286a0ffda
3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp
ee2a7a79617612ed448e650cc77608c4962fe5a5
Diff: https://reviews.apache.org/r/39262/diff/
Testing
---
`make check` on Ubuntu 15, OS X 10.10, and running the `check` project on
Windows
ran `make check` on Ubuntu 15.
Thanks,
Alex Clemmer
`make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015
on Windows 10.
Autotools `make check` on Ubuntu 15.
Thanks,
Alex Clemmer
.
Thanks,
Alex Clemmer
check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015
on Windows 10.
Autotools `make check` on Ubuntu 15.
Thanks,
Alex Clemmer
---
CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015
on Windows 10.
Autotools `make check` on Ubuntu 15.
Thanks,
Alex Clemmer
10.10, and ran `check` target in VS2015
on Windows 10.
Autotools `make check` on Ubuntu 15.
Thanks,
Alex Clemmer
10.
Autotools `make check` on Ubuntu 15.
Thanks,
Alex Clemmer
c85bddbda3a17b45d7e31517ddf70358ebde1b41
Diff: https://reviews.apache.org/r/39381/diff/
Testing
---
CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015
on Windows 10.
Autotools `make check` on Ubuntu 15.
Thanks,
Alex Clemmer
/stout/windows/os.hpp
eaeed7393b1c44f04737e18cd90a6fc292aa061d
Diff: https://reviews.apache.org/r/39382/diff/
Testing
---
CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015
on Windows 10.
Autotools `make check` on Ubuntu 15.
Thanks,
Alex Clemmer
/3rdparty/stout/include/stout/flags/parse.hpp
e34ed78386130a1e757be1b1f1a2dbf794b7cd37
Diff: https://reviews.apache.org/r/39380/diff/
Testing
---
CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015
on Windows 10.
Autotools `make check` on Ubuntu 15.
Thanks,
Alex
,
Alex Clemmer
` (or equivalent) on Windows 10, Ubuntu
15, OS X 10.10. Built autotools solution and ran `make check` on Ubuntu 15.
Thanks,
Alex Clemmer
/os.hpp
eaeed7393b1c44f04737e18cd90a6fc292aa061d
Diff: https://reviews.apache.org/r/39382/diff/
Testing
---
CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015
on Windows 10.
Autotools `make check` on Ubuntu 15.
Thanks,
Alex Clemmer
Diff: https://reviews.apache.org/r/39381/diff/
Testing
---
CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015
on Windows 10.
Autotools `make check` on Ubuntu 15.
Thanks,
Alex Clemmer
://reviews.apache.org/r/39220/diff/
Testing
---
Built CMake solution and ran `make check` (or equivalent) on Windows 10, Ubuntu
15, OS X 10.10. Built autotools solution and ran `make check` on Ubuntu 15.
Thanks,
Alex Clemmer
---
Built CMake solution and ran `make check` (or equivalent) on Windows 10, Ubuntu
15, OS X 10.10. Built autotools solution and ran `make check` on Ubuntu 15.
Thanks,
Alex Clemmer
` project in VS on Windows 10.
Thanks,
Alex Clemmer
` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
/libprocess/3rdparty/stout/include/stout/windows/os.hpp
3e6f2aafd0f541f512025dfa683ab4178701f7c4
Diff: https://reviews.apache.org/r/39538/diff/
Testing
---
`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex
Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
://reviews.apache.org/r/39539/diff/
Testing
---
`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
right?
- Alex Clemmer
On Oct. 22, 2015, 3:35 a.m., Alex Clemmer wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
cialization though! That blows my mind.
- Alex
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39219/#review103062
-------
rts clarity,
because it is not obvious.
- Alex
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39537/#review103599
-------
/stout/os/mkdir.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/39383/diff/
Testing
---
CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015
on Windows 10.
Autotools `make check` on Ubuntu 15.
Thanks,
Alex Clemmer
---
CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015
on Windows 10.
Autotools `make check` on Ubuntu 15.
Thanks,
Alex Clemmer
/stout/posix/os.hpp
b6afe0e76366d0bc68d37097ced83a1e14828d84
3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp
3e6f2aafd0f541f512025dfa683ab4178701f7c4
Diff: https://reviews.apache.org/r/39559/diff/
Testing
---
Thanks,
Alex Clemmer
and ran `make check` on Ubuntu 15.
Thanks,
Alex Clemmer
Wu.
Repository: mesos
Description
---
CMake: Add state.cpp, flags.cpp to Windows agent build.
Diffs
-
src/CMakeLists.txt e6169a0e3ad34dd0e4c3430a6532bd48c4bd04fd
Diff: https://reviews.apache.org/r/39560/diff/
Testing
---
Thanks,
Alex Clemmer
an't commit this stuff with
tests" is "yes, I agree, but I have to write this before we can open up the
tests!" :)
- Alex Clemmer
On Oct. 22, 2015, 6:23 p.m., Alex Clemmer wrote:
>
> ---
> This is an automat
he answer is yes.
Also, you might be leery of committing this without tests. That's ok! We
need this to pull the FS tests out of `os_tests.cpp` though. The last function
we will need to port to get those tests functional on Windows is `rmdir`, and
I'm almost done.
- Alex Clemme
> On Oct. 22, 2015, 6:33 p.m., Alex Clemmer wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/mkdtemp.hpp,
> > line 31
> > <https://reviews.apache.org/r/39559/diff/1/?file=1103501#file1103501line31>
> >
> > Just so I catch it be
on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
,
Alex Clemmer
https://reviews.apache.org/r/39583/#review103746
-------
On Oct. 23, 2015, 8:57 a.m., Alex Clemmer wrote:
>
> ---
> This is an automatically generated e-m
autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
views.apache.org/r/39540/#review103800
---
On Oct. 22, 2015, 3:36 a.m., Alex Clemmer wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39540/
>
---
`make check` from CMake on OS X 10.10.
`make check` from Autotools on OS X 10.10.
Ran `check` project in VS on Windows 10.
PLEASE NOTE: I am on a terrible network with proxy problems and I can't SSH
into my Ubuntu box to test this from Ubuntu
Thanks,
Alex Clemmer
---
`make check` from CMake on OS X 10.10.
`make check` from Autotools on OS X 10.10.
Ran `check` project in VS on Windows 10.
PLEASE NOTE: I am on a terrible network with proxy problems and I can't SSH
into my Ubuntu box to test this from Ubuntu
Thanks,
Alex Clemmer
Autotools on OS X 10.10.
Ran `check` project in VS on Windows 10.
PLEASE NOTE: I am on a terrible network with proxy problems and I can't SSH
into my Ubuntu box to test this from Ubuntu
Thanks,
Alex Clemmer
---
`make check` from CMake on OS X 10.10.
`make check` from Autotools on OS X 10.10.
Ran `check` project in VS on Windows 10.
PLEASE NOTE: I am on a terrible network with proxy problems and I can't SSH
into my Ubuntu box to test this from Ubuntu
Thanks,
Alex Clemmer
---
`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
` project in VS on Windows 10.
Thanks,
Alex Clemmer
; code.
Yes, I admit it's a super nitpicky thing to do.
- Alex
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39019/#review101663
---------
check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
7a8819541506f57f70a9b577dc97a76fc26ebaa8
Diff: https://reviews.apache.org/r/39539/diff/
Testing
---
`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
/
Testing
---
`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
---
CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015
on Windows 10.
Autotools `make check` on Ubuntu 15.
Thanks,
Alex Clemmer
:
https://reviews.apache.org/r/39559/#review103815
-------
On Oct. 22, 2015, 6:23 p.m., Alex Clemmer wrote:
>
> ---
> This is an automatically generated e-
eviews.apache.org/r/39559/#review103815
---
On Oct. 22, 2015, 6:23 p.m., Alex Clemmer wrote:
>
> ---
> This is an automatically generated e-mail. To re
3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp
b6afe0e76366d0bc68d37097ced83a1e14828d84
3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp
3e6f2aafd0f541f512025dfa683ab4178701f7c4
Diff: https://reviews.apache.org/r/39559/diff/
Testing
---
Thanks,
Alex
> On Oct. 23, 2015, 6:45 p.m., Joseph Wu wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/mkdtemp.hpp,
> > line 34
> > <https://reviews.apache.org/r/39559/diff/1/?file=1103501#file1103501line34>
> >
> > `strlen()` might be better
;re not using snake case. Have I missed something
important?
- Alex
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39559/#review103815
-------
On Oct. 27, 2015, 8:14 a.m., Alex Clemmer wrote:
>
&
.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
- Alex
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39584/#review104054
---
On Oct. 27, 2015, 8:23 a.m., Ale
/rmdir.hpp (line 138)
<https://reviews.apache.org/r/39584/#comment162433>
note that actually `::rmdir` here will deal appropriately with Unix-style
paths, so there's no real need to normalize them.
- Alex Clemmer
On Oct. 27, 2015, 8:23 a.m., Alex Cl
autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp
e26df59d9b837e1f4a4b92577f0a3de4b9076cb4
3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp
edf17d5ad8efbc988e909bfb8ffa5a015ecdc89d
Diff: https://reviews.apache.org/r/39559/diff/
Testing
---
Thanks,
Alex
and ran `make check` on Ubuntu 15.
Thanks,
Alex Clemmer
---
Thanks,
Alex Clemmer
.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
hanks,
Alex Clemmer
hanks,
Alex Clemmer
buntu
Thanks,
Alex Clemmer
check` from CMake on OS X 10.10.
`make check` from Autotools on OS X 10.10.
Ran `check` project in VS on Windows 10.
PLEASE NOTE: I am on a terrible network with proxy problems and I can't SSH
into my Ubuntu box to test this from Ubuntu
Thanks,
Alex Clemmer
` project in VS on Windows 10.
Thanks,
Alex Clemmer
autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
,
Alex Clemmer
,
Alex Clemmer
1a7037d64afeedc340258c92067e95d1d3caa027
Diff: https://reviews.apache.org/r/39803/diff/
Testing
---
`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
://reviews.apache.org/r/39805/diff/
Testing
---
`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
Remoortere, and Joseph Wu.
Repository: mesos
Description
---
Made `path_tests.cpp` standalone.
Diffs
-
3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp
ad9ce324eaf940f68d04c6db7ba37d05efb1216a
Diff: https://reviews.apache.org/r/39834/diff/
Testing
---
Thanks,
Alex
/os_tests.cpp
5a1da57f7e27cf8154f0d5f6efd47dcee8a430ff
Diff: https://reviews.apache.org/r/39805/diff/
Testing
---
`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
tps://reviews.apache.org/r/39805/#comment162892>
Oh, interesting, I thought that the lineup here was identical to that of
`git diff`. I guess not.
- Alex Clemmer
On Nov. 1, 2015, 1:22 a.m., Alex Clemmer wrote:
>
> ---
/3rdparty/stout/include/stout/windows.hpp
1a7037d64afeedc340258c92067e95d1d3caa027
Diff: https://reviews.apache.org/r/39803/diff/
Testing
---
`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
---
Thanks,
Alex Clemmer
---
Thanks,
Alex Clemmer
/
Testing
---
Thanks,
Alex Clemmer
://reviews.apache.org/r/39851/diff/
Testing
---
Thanks,
Alex Clemmer
://reviews.apache.org/r/39851/diff/
Testing
---
Thanks,
Alex Clemmer
tps://reviews.apache.org/r/39851/#comment162948>
Ah. VisualStudio tricked me into believing this was ok! It claimed this
built correctly, but now when I `make clean` it doesn't. I'll have to revisit
tomorrow, as it's 3:30 AM.
- Alex Clemmer
On Nov. 2, 2015, 11:06 a.m
://reviews.apache.org/r/39851/diff/
Testing
---
Thanks,
Alex Clemmer
://reviews.apache.org/r/39851/diff/
Testing
---
Thanks,
Alex Clemmer
/path_tests.cpp
ad9ce324eaf940f68d04c6db7ba37d05efb1216a
Diff: https://reviews.apache.org/r/39834/diff/
Testing
---
Thanks,
Alex Clemmer
230/#comment162998>
Sorry I'm super late to the party. Does it make sense to add these to the
CMake build system as well?
- Alex Clemmer
On Oct. 22, 2015, 10:02 a.m., Till Toenshoff wrote:
>
> ---
> This is an automatica
g/r/39634/#comment162999>
If it's not too much trouble, it would be great to see this logic added
also the `cmake/CompilationCOnfigure.cmake`. It should only be a couple lines
of code.
- Alex Clemmer
On Oct. 30, 2015, 5:05 a.m., David For
719/#comment163000>
It looks like it might make sense to add this to `src/CMakeLists.txt` also?
- Alex Clemmer
On Nov. 2, 2015, 6:52 p.m., Timothy Chen wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
s to its own tests file so that we can run it on
Windows too? `os_test.cpp` has is too big and full of unimplemented stuff to
add Windows support right now.
- Alex Clemmer
On Oct. 23, 2015, 7:49 a.m., Benjamin Bannier wrote:
>
> --
://reviews.apache.org/r/39851/diff/
Testing
---
Thanks,
Alex Clemmer
/diff/
Testing
---
Thanks,
Alex Clemmer
801 - 900 of 1037 matches
Mail list logo
