d23f551c2caa454da0c0f6cb7d77a8c2bd75a474
Diff: https://reviews.apache.org/r/53541/diff/
Testing
---
make check
Thanks,
Alexander Rojas
the
> > authorization check for those Calls as a separate patch, so we can see how
> > these fields will be filled in?
>
> Alexander Rojas wrote:
> Will fix when everything is running properly.
So as bespoken, I won't break this patch, however there's
3d198
src/tests/authorization_tests.cpp d23f551c2caa454da0c0f6cb7d77a8c2bd75a474
Diff: https://reviews.apache.org/r/53541/diff/
Testing
---
make check
Thanks,
Alexander Rojas
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53541/#review156189
-------
On Nov. 21, 2016, 5:25 p.m., Alexander Rojas wrote:
>
> -
src/authorizer/local/authorizer.cpp 77e05dd2475d6e7511e7c7eeea578ec31ff3d198
src/tests/authorization_tests.cpp d23f551c2caa454da0c0f6cb7d77a8c2bd75a474
Diff: https://reviews.apache.org/r/53541/diff/
Testing
---
make check
Thanks,
Alexander Rojas
3d198
src/tests/authorization_tests.cpp d23f551c2caa454da0c0f6cb7d77a8c2bd75a474
Diff: https://reviews.apache.org/r/53541/diff/
Testing
---
make check
Thanks,
Alexander Rojas
eviews.apache.org/r/53541/#review156027
---
On Nov. 9, 2016, 1:43 a.m., Alexander Rojas wrote:
>
> ---
> This is an automatically generated e-mail. To re
---
make check
Thanks,
Alexander Rojas
b6a9f142eecbdfd59210872a92e3126f04de334c
src/authorizer/local/authorizer.cpp f1dff65d973fc84f4171f68fd0391a2343a96965
src/tests/authorization_tests.cpp 5d7e17b67821357b8cb538798acc883945c8f8fd
Diff: https://reviews.apache.org/r/53541/diff/
Testing
---
make check
Thanks,
Alexander Rojas
/authorizer.cpp f1dff65d973fc84f4171f68fd0391a2343a96965
src/tests/authorization_tests.cpp 5d7e17b67821357b8cb538798acc883945c8f8fd
Diff: https://reviews.apache.org/r/53541/diff/
Testing
---
make check
Thanks,
Alexander Rojas
/tests/authorization_tests.cpp 5d7e17b67821357b8cb538798acc883945c8f8fd
Diff: https://reviews.apache.org/r/53058/diff/
Testing
---
make check
Thanks,
Alexander Rojas
15ad5a647fc71d36ffd149893b3b9448a7d99323
src/master/quota_handler.cpp d87d6c6266ba596c4e6bd36124f5a360428fe171
src/master/weights_handler.cpp c240fb2980a7e957136d11ddd3f43ee4761a07dc
Diff: https://reviews.apache.org/r/53057/diff/
Testing
---
Tests in the last patch of the series.
Thanks,
Alexander Rojas
b6a9f142eecbdfd59210872a92e3126f04de334c
src/authorizer/local/authorizer.cpp f1dff65d973fc84f4171f68fd0391a2343a96965
Diff: https://reviews.apache.org/r/52600/diff/
Testing
---
tests in the last patch of the chain.
Thanks,
Alexander Rojas
0; --back) {
if (representation[back] != '0') {
break;
}
}
representation.resize(back + 1);
out << representation << (representation[back] == '.' ? "0" : "");
```
Performance
```
Run on (8 X 1000 MHz CPU s)
2016-11-01 11:13:40
BenchmarkTime(ns)CPU(ns) Iterations
---
BM_Jsonify 73785 73757 9534
```
6. Using thread local variables:
```c++
static THREAD_LOCAL std::stringstream* ss;
static THREAD_LOCAL std::once_flag once_flag;
std::call_once(once_flag, [=]() {
ss = new std::stringstream;
ss->imbue(std::locale::classic());
});
*ss << std::setprecision(std::numeric_limits::digits10)
<< std::showpoint << number.value;.
std::string trimmed = strings::trim(ss->str(), strings::SUFFIX, "0");
out << trimmed << (trimmed.back() == '.' ? "0" : "");
ss->str("");
return out;
```
Performance
```
Run on (8 X 1000 MHz CPU s)
2016-11-01 11:14:45
BenchmarkTime(ns)CPU(ns) Iterations
---
BM_Jsonify 68407 68415 9716
```
Thanks,
Alexander Rojas
;< representation << (representation[back] == '.' ? "0" : "");
```
Performance
```
Run on (8 X 1000 MHz CPU s)
2016-11-01 11:13:40
BenchmarkTime(ns)CPU(ns) Iterations
---
BM_Jsonify 73785 73757 9534
```
6. Using thread local variables:
```c++
static THREAD_LOCAL std::stringstream* ss;
static THREAD_LOCAL std::once_flag once_flag;
std::call_once(once_flag, [=]() {
ss = new std::stringstream;
ss->imbue(std::locale::classic());
});
*ss << std::setprecision(std::numeric_limits::digits10)
<< std::showpoint << number.value;.
std::string trimmed = strings::trim(ss->str(), strings::SUFFIX, "0");
out << trimmed << (trimmed.back() == '.' ? "0" : "");
ss->str("");
return out;
```
Performance
```
Run on (8 X 1000 MHz CPU s)
2016-11-01 11:14:45
BenchmarkTime(ns)CPU(ns) Iterations
---
BM_Jsonify 68407 68415 9716
```
Thanks,
Alexander Rojas
s.apache.org/r/52877/diff/2/?file=1550725#file1550725line181>
> >
> > Investigate whether this creates a string in optimized code.
see above.
- Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52877/#review154397
---
brary
> > calls made.
>
> Alexander Rojas wrote:
> That occurred to me, but then some issues appeared with the idea. The
> version in `json.hpp` uses a free function, the way to keep the
> `stringstream` is by making it global (either having a global variable or
> marking it `
1);
out << representation << (representation[back] == '.' ? "0" : "");
```
Performance
```
Run on (8 X 1000 MHz CPU s)
2016-11-01 11:13:40
BenchmarkTime(ns)CPU(ns) Iterations
---
BM_Jsonify 73785 73757 9534
```
6. Using thread local variables:
```c++
static THREAD_LOCAL std::stringstream* ss;
static THREAD_LOCAL std::once_flag once_flag;
std::call_once(once_flag, [=]() {
ss = new std::stringstream;
ss->imbue(std::locale::classic());
});
*ss << std::setprecision(std::numeric_limits::digits10)
<< std::showpoint << number.value;.
std::string trimmed = strings::trim(ss->str(), strings::SUFFIX, "0");
out << trimmed << (trimmed.back() == '.' ? "0" : "");
ss->str("");
return out;
```
Performance
```
Run on (8 X 1000 MHz CPU s)
2016-11-01 11:14:45
BenchmarkTime(ns)CPU(ns) Iterations
---
BM_Jsonify 68407 68415 9716
```
Thanks,
Alexander Rojas
/libprocess/include/process/future.hpp
175214a9090f8cc8241a81e535c87370102f3011
3rdparty/libprocess/src/tests/future_tests.cpp
7c411c7be1849119fe0b070622dbe4488fa11b7a
Diff: https://reviews.apache.org/r/53299/diff/
Testing
---
`make check`
Thanks,
Alexander Rojas
)
-
3rdparty/libprocess/include/process/future.hpp
175214a9090f8cc8241a81e535c87370102f3011
3rdparty/libprocess/src/tests/future_tests.cpp
7c411c7be1849119fe0b070622dbe4488fa11b7a
Diff: https://reviews.apache.org/r/53299/diff/
Testing
---
`make check`
Thanks,
Alexander Rojas
175214a9090f8cc8241a81e535c87370102f3011
3rdparty/libprocess/src/tests/future_tests.cpp
7c411c7be1849119fe0b070622dbe4488fa11b7a
Diff: https://reviews.apache.org/r/53299/diff/
Testing
---
`make check`
Thanks,
Alexander Rojas
/authorization_tests.cpp 5d7e17b67821357b8cb538798acc883945c8f8fd
Diff: https://reviews.apache.org/r/53058/diff/
Testing
---
make check
Thanks,
Alexander Rojas
b6a9f142eecbdfd59210872a92e3126f04de334c
src/authorizer/local/authorizer.cpp f1dff65d973fc84f4171f68fd0391a2343a96965
Diff: https://reviews.apache.org/r/52600/diff/
Testing
---
tests in the last patch of the chain.
Thanks,
Alexander Rojas
b6a9f142eecbdfd59210872a92e3126f04de334c
src/authorizer/local/authorizer.cpp f1dff65d973fc84f4171f68fd0391a2343a96965
Diff: https://reviews.apache.org/r/52600/diff/
Testing
---
tests in the last patch of the chain.
Thanks,
Alexander Rojas
Diff: https://reviews.apache.org/r/53058/diff/
Testing
---
make check
Thanks,
Alexander Rojas
c240fb2980a7e957136d11ddd3f43ee4761a07dc
Diff: https://reviews.apache.org/r/53057/diff/
Testing
---
Tests in the last patch of the series.
Thanks,
Alexander Rojas
d87d6c6266ba596c4e6bd36124f5a360428fe171
src/master/weights_handler.cpp c240fb2980a7e957136d11ddd3f43ee4761a07dc
Diff: https://reviews.apache.org/r/53057/diff/
Testing
---
Tests in the last patch of the series.
Thanks,
Alexander Rojas
b6a9f142eecbdfd59210872a92e3126f04de334c
src/authorizer/local/authorizer.cpp f1dff65d973fc84f4171f68fd0391a2343a96965
Diff: https://reviews.apache.org/r/52600/diff/
Testing (updated)
---
tests in the last patch of the chain.
Thanks,
Alexander Rojas
brary
> > calls made.
>
> Alexander Rojas wrote:
> That occurred to me, but then some issues appeared with the idea. The
> version in `json.hpp` uses a free function, the way to keep the
> `stringstream` is by making it global (either having a global variable or
> marking it `
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52600/#review153194
---
On Oct. 19, 2016, 10:50 a.m., Alexander Rojas wrote:
>
> ---
> T
/diff/
Testing
---
make check
Thanks,
Alexander Rojas
b3b6d0bbe877cf3794a5c616374ffce8c1b1552c
Diff: https://reviews.apache.org/r/52600/diff/
Testing
---
make check
Thanks,
Alexander Rojas
b3b6d0bbe877cf3794a5c616374ffce8c1b1552c
Diff: https://reviews.apache.org/r/52600/diff/
Testing
---
make check
Thanks,
Alexander Rojas
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52877/#review152761
---
On Oct. 14, 2016, 2:50 p.m., Alexander Rojas wrote:
>
>
d87d6c6266ba596c4e6bd36124f5a360428fe171
src/master/weights_handler.cpp c240fb2980a7e957136d11ddd3f43ee4761a07dc
src/tests/authorization_tests.cpp 5d7e17b67821357b8cb538798acc883945c8f8fd
Diff: https://reviews.apache.org/r/52600/diff/
Testing
---
make check
Thanks,
Alexander Rojas
quot; : "");
```
Performance
```
Run on (8 X 1000 MHz CPU s)
2016-10-14 13:33:22
BenchmarkTime(ns)CPU(ns) Iterations
---
BM_Jsonify 82363 82337 8591
```
5. Proposal 3, try to avoid copies (there are still some being created):
```c++
std::stringstream ss;
ss.imbue(std::locale::classic());
ss << std::setprecision(std::numeric_limits::digits10)
<< std::showpoint << number.value;
std::string representation = ss.str();
int back = representation.size() - 1;
for (; back > 0; --back) {
if (representation[back] != '0') {
break;
}
}
representation.resize(back + 1);
out << representation << (representation[back] == '.' ? "0" : "");
```
Performance
```
Run on (8 X 1000 MHz CPU s)
2016-10-14 13:34:40
BenchmarkTime(ns)CPU(ns) Iterations
---
BM_Jsonify 94267 94235 7166
```
Thanks,
Alexander Rojas
quot; : ["foo"] },
"users" : { "type" : "NONE" }
}
]
}
```
and credentials:
```
foo bar
baz bar
```
Thanks,
Alexander Rojas
t; : [
{
"principals" : { "values" : ["foo"] },
"users" : { "type" : "NONE" }
}
]
}
```
and credentials:
```
foo bar
baz bar
```
Thanks,
Alexander Rojas
t; : [
{
"principals" : { "values" : ["foo"] },
"users" : { "type" : "NONE" }
}
]
}
```
and credentials:
```
foo bar
baz bar
```
Thanks,
Alexander Rojas
cess_mesos_logs" : [
{
"principals" : { "values" : ["foo"] },
"logs" : { "type" : "NONE" }
}
],
"access_sandboxes" : [
{
"principals" : { "values" : ["foo"] },
"users" : { "type" : "NONE" }
}
]
}
```
and credentials:
```
foo bar
baz bar
```
Thanks,
Alexander Rojas
-
src/webui/master/static/js/controllers.js
29a5a1c8754cc2fb934854750d6dfb04f1eaeae4
Diff: https://reviews.apache.org/r/52034/diff/
Testing
---
manual tests and `make check`
Thanks,
Alexander Rojas
--gtest_break_on_failure --gtest_repeat=1
--gtest_filter="SlaveAuthorizerTest/*.ViewFlags"` Before applying the patch the
issue could be reproduced, but not after the patch.
- Alexander Rojas
On July 22, 2016, 3:35 p.m., Neil Conway wrote:
>
> --
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50339/#review143341
---
Ship it!
Ship It!
- Alexander Rojas
On July 22, 2016, 3:35
the office
(which is the reason I didn't propose a patch yet). The error occurs in Linux
only so I will try it and then give it a ship it if it solves the issue.
- Alexander Rojas
On July 22, 2016, 3:35 p.m., Neil Conway
gt; than available
> cpus(*):32; mem(*):256819; ports(*):[31000-32000]; disk(kafka,
> kafka)[kafka_0:data]:960679; disk(*):240169;
> ```
>
> With new:
>
> _Your example here_
- Alexander Rojas
On July 12, 2016, 8:15 a.m., Tim Harper wrote:
>
> ---
12, 2016, 8:15 a.m., Tim Harper wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49910/
> ---
>
> (Updated July 12, 2016, 8:15 a.m.)
>
>
> Review re
/
Testing
---
`make check` (It is not a functional change)
Thanks,
Alexander Rojas
> On July 5, 2016, 9:03 a.m., Alexander Rojas wrote:
> > src/files/files.cpp, lines 729-731
> > <https://reviews.apache.org/r/49600/diff/1/?file=1436468#file1436468line729>
> >
> > The lambda doesn't use any method nor attribute from `FilesProcess`, so
ig object and you will be using just on field of
the `url.query` attribute. Why not copying that value and capturing only that
one?
I also wonder if one can save itself from copying a possible big `object`
object.
- Alexander Rojas
On July 4, 2016, 7:41 p.m., Abhish
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49575/#review140625
---
Ship it!
Ship It!
- Alexander Rojas
On July 3, 2016, 7:51
/tmp/acls.json &
# Following requests succeed (200 OK response)
http http://localhost:5051/monitor/statistics -a foo:bar
http http://localhost:5051/monitor/statistics.json -a foo:bar
http http://localhost:5051/monitor/containers -a foo:bar
# Following requests fail (403 forbidden response)
http http://localhost:5051/monitor/statistics -a baz:bar
http http://localhost:5051/monitor/statistics.json -a baz:bar
http http://localhost:5051/monitor/containers -a baz:bar
```
Thanks,
Alexander Rojas
`flags` handler.
Diffs
-
src/master/http.cpp e5acdb8e0bbcd7a2b7e8a8bc7f4bbeaae2c4fea1
src/master/master.hpp e2ab2110fe5a287ab16ac9ef4222fed633e02ebe
Diff: https://reviews.apache.org/r/49394/diff/
Testing
---
make check
Thanks,
Alexander Rojas
Forbidden response
http GET http://127.0.0.1:5050/flags -a baz:bar
http GET http://127.0.0.1:5051/flags -a baz:bar
# Returned JSON doesn't include flags information.
http GET http://127.0.0.1:5050/state -a baz:bar
http GET http://127.0.0.1:5051/state -a baz:bar
```
Thanks,
Alexander Rojas
# 403 Forbidden response
http GET http://127.0.0.1:5050/flags -a baz:bar
http GET http://127.0.0.1:5051/flags -a baz:bar
# Returned JSON doesn't include flags information.
http GET http://127.0.0.1:5050/state -a baz:bar
http GET http://127.0.0.1:5051/state -a baz:bar
```
Thanks,
Alexander Rojas
documentation is available.
Diffs (updated)
-
docs/authorization.md 9bd6031d2a3aef921fa4e3f6683cc5c234832d47
docs/upgrades.md 079e04f9e886da4e28ef79b61f0fef82e927e771
Diff: https://reviews.apache.org/r/49257/diff/
Testing
---
Not a functional change.
Thanks,
Alexander Rojas
`flags` handler.
Diffs (updated)
-
src/master/http.cpp e5acdb8e0bbcd7a2b7e8a8bc7f4bbeaae2c4fea1
src/master/master.hpp e2ab2110fe5a287ab16ac9ef4222fed633e02ebe
Diff: https://reviews.apache.org/r/49394/diff/
Testing
---
make check
Thanks,
Alexander Rojas
https://reviews.apache.org/r/49394/diff/
Testing
---
make check
Thanks,
Alexander Rojas
.
Diffs (updated)
-
src/master/http.cpp e5acdb8e0bbcd7a2b7e8a8bc7f4bbeaae2c4fea1
src/master/master.hpp e2ab2110fe5a287ab16ac9ef4222fed633e02ebe
Diff: https://reviews.apache.org/r/49394/diff/
Testing
---
make check
Thanks,
Alexander Rojas
If so, let us use a generic "Could not ..." error message
>
> Alexander Rojas wrote:
> This issue has been raised in the past (by myself actually), our pattern
> however is to expose this information.
See the discussion [here](htt
of
serialize which is a wrong assumption, inf fact the current formatting
clarifies what actually happens.
- Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49394/#review140141
----
e5acdb8e0bbcd7a2b7e8a8bc7f4bbeaae2c4fea1
src/master/master.hpp e2ab2110fe5a287ab16ac9ef4222fed633e02ebe
Diff: https://reviews.apache.org/r/49394/diff/
Testing
---
make check
Thanks,
Alexander Rojas
eviews.apache.org/r/49394/#review140047
---
On June 30, 2016, 11:43 a.m., Alexander Rojas wrote:
>
> ---
> This is an automatically generated e-mail. To re
HTTP API v1 call `flags` handler.
Diffs (updated)
-
src/master/http.cpp e5acdb8e0bbcd7a2b7e8a8bc7f4bbeaae2c4fea1
src/master/master.hpp e2ab2110fe5a287ab16ac9ef4222fed633e02ebe
Diff: https://reviews.apache.org/r/49394/diff/
Testing
---
make check
Thanks,
Alexander Rojas
foo:bar
# 403 Forbidden response
http GET http://127.0.0.1:5050/flags -a baz:bar
http GET http://127.0.0.1:5051/flags -a baz:bar
# Returned JSON doesn't include flags information.
http GET http://127.0.0.1:5050/state -a baz:bar
http GET http://127.0.0.1:5051/state -a baz:bar
```
Thanks,
Alexander Rojas
e
> > v1 API can get the benefit automatically.
> >
> > please move this logic inside `_flags()`. you might need to adjust its
> > return type and add a `__flags()`.
>
> Alexander Rojas wrote:
> The main problem with this suggestion is, `_flags` return
/master/master.hpp e2ab2110fe5a287ab16ac9ef4222fed633e02ebe
Diff: https://reviews.apache.org/r/49394/diff/
Testing
---
make check
Thanks,
Alexander Rojas
e
> > v1 API can get the benefit automatically.
> >
> > please move this logic inside `_flags()`. you might need to adjust its
> > return type and add a `__flags()`.
>
> Alexander Rojas wrote:
> The main problem with this suggestion is, `_flags` return
acls.json &
# Following requests succeed (200 OK response)
http http://localhost:5051/monitor/statistics -a foo:bar
http http://localhost:5051/monitor/statistics.json -a foo:bar
http http://localhost:5051/monitor/containers -a foo:bar
# Following requests fail (403 forbidden response)
http http://localhost:5051/monitor/statistics -a baz:bar
http http://localhost:5051/monitor/statistics.json -a baz:bar
http http://localhost:5051/monitor/containers -a baz:bar
```
Thanks,
Alexander Rojas
tps://reviews.apache.org/r/49201/#comment205340>
This line cause a test which set the path as `/metrics//snapshot`.
- Alexander Rojas
On June 29, 2016, 5:31 p.m., Alexander Rojas wrote:
>
> ---
> This is an automatically generated e-mail.
/tmp/acls.json &
# Following requests succeed (200 OK response)
http http://localhost:5051/monitor/statistics -a foo:bar
http http://localhost:5051/monitor/statistics.json -a foo:bar
http http://localhost:5051/monitor/containers -a foo:bar
# Following requests fail (403 forbidden response)
http http://localhost:5051/monitor/statistics -a baz:bar
http http://localhost:5051/monitor/statistics.json -a baz:bar
http http://localhost:5051/monitor/containers -a baz:bar
```
Thanks,
Alexander Rojas
> On June 28, 2016, 4:50 p.m., Alexander Rojas wrote:
> > include/mesos/authorizer/authorizer.proto, lines 90-91
> > <https://reviews.apache.org/r/49319/diff/1/?file=1431917#file1431917line90>
> >
> > This comment is rather incomplete:
> >
>
e
> > v1 API can get the benefit automatically.
> >
> > please move this logic inside `_flags()`. you might need to adjust its
> > return type and add a `__flags()`.
>
> Alexander Rojas wrote:
> The main problem with this suggestion is, `_flags` return
check`
Thanks,
Alexander Rojas
is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49313/#review139931
---
On June 29, 2016, 10:33 a.m., Alexander Rojas wrote:
>
> -
foo:bar
# 403 Forbidden response
http GET http://127.0.0.1:5050/flags -a baz:bar
http GET http://127.0.0.1:5051/flags -a baz:bar
# Returned JSON doesn't include flags information.
http GET http://127.0.0.1:5050/state -a baz:bar
http GET http://127.0.0.1:5051/state -a baz:bar
```
Thanks,
Alexander Rojas
://reviews.apache.org/r/49359/diff/
Testing
---
`make check` (It is not a functional change)
Thanks,
Alexander Rojas
foo:bar
# 403 Forbidden response
http GET http://127.0.0.1:5050/flags -a baz:bar
http GET http://127.0.0.1:5051/flags -a baz:bar
# Returned JSON doesn't include flags information.
http GET http://127.0.0.1:5050/state -a baz:bar
http GET http://127.0.0.1:5051/state -a baz:bar
```
Thanks,
Alexander Rojas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49313/#review139886
-------
On June 29, 2016, 12:51 a.m., Alexander Rojas wrote:
>
> ---
&
0/state -a foo:bar
http GET http://127.0.0.1:5051/state -a foo:bar
# 403 Forbidden response
http GET http://127.0.0.1:5050/flags -a baz:bar
http GET http://127.0.0.1:5051/flags -a baz:bar
# Returned JSON doesn't include flags information.
http GET http://127.0.0.1:5050/state -a baz:bar
http GET http://127.0.0.1:5051/state -a baz:bar
```
Thanks,
Alexander Rojas
documentation is available.
Diffs (updated)
-
docs/authorization.md 9bd6031d2a3aef921fa4e3f6683cc5c234832d47
docs/upgrades.md 079e04f9e886da4e28ef79b61f0fef82e927e771
Diff: https://reviews.apache.org/r/49257/diff/
Testing
---
Not a functional change.
Thanks,
Alexander Rojas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49257/#review139691
---
On June 28, 2016, 2:57 p.m., Alexander Rojas wrote:
>
>
tion above?
Yup, fixed.
- Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49257/#review139775
---
On June 28, 2016, 2:57 p.m., Alexander Rojas wrote:
>
> --
we redesign the whole system.
- Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49201/#review139690
---
On June
ss and destruction of the enpoint.
All in all, we should mention that having none set is an exceptional case,
and could be treated by returning an error.
- Alexander Rojas
On June 28, 2016, 4:35 p.m., Joerg Schad wrote:
>
> ---
https://reviews.apache.org/r/49201/#review139778
-------
On June 28, 2016, 10:46 a.m., Alexander Rojas wrote:
>
> ---
> This is an automatically generated e-m
-------
On June 28, 2016, 2:57 p.m., Alexander Rojas wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49257/
> --
iff: https://reviews.apache.org/r/49095/diff/
Testing
---
`make check`
Thanks,
Alexander Rojas
I didn't notice it.
- Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49095/#review139684
---
On June 2
functional change.
Thanks,
Alexander Rojas
t
review is not really needed.
- Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49196/#review139764
-------
On June 27, 2016, noon, Alexander Rojas wrote:
>
> -
/flags -a baz:bar
http GET http://127.0.0.1:5051/flags -a baz:bar
# Returned JSON doesn't include flags information.
http GET http://127.0.0.1:5050/state -a baz:bar
http GET http://127.0.0.1:5051/state -a baz:bar
```
Thanks,
Alexander Rojas
K response)
http http://localhost:5051/monitor/statistics -a foo:bar
http http://localhost:5051/monitor/statistics.json -a foo:bar
http http://localhost:5051/monitor/containers -a foo:bar
# Following requests fail (403 forbidden response)
http http://localhost:5051/monitor/statistics -a baz:bar
http http://localhost:5051/monitor/statistics.json -a baz:bar
http http://localhost:5051/monitor/containers -a baz:bar
```
Thanks,
Alexander Rojas
>
/tardown/teardown/
- Alexander Rojas
On June 6, 2016, 5:11 p.m., Joerg Schad wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49254/#review139552
---
Ship it!
Ship It!
- Alexander Rojas
On June 27, 2016, 12:33
> On June 14, 2016, 3:13 p.m., Joerg Schad wrote:
> >
>
> Alexander Rojas wrote:
> Given that Jörg is busy to finish this patch, It get's superseeded by
> [r/49257/](https://reviews.apache.org/r/49257/)
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46887/#review137495
---
On June 14, 2016, 1:46 p.m., Jan Schlicht wrote:
>
> ---
>
/authorization.md abadee4ae51ee2d2e160c7883b4f518593f2f5b3
docs/upgrades.md 079e04f9e886da4e28ef79b61f0fef82e927e771
Diff: https://reviews.apache.org/r/49257/diff/
Testing
---
Not a functional change.
Thanks,
Alexander Rojas
)
http http://localhost:5051/monitor/statistics -a foo:bar
http http://localhost:5051/monitor/statistics.json -a foo:bar
http http://localhost:5051/monitor/containers -a foo:bar
# Following requests fail (403 forbidden response)
http http://localhost:5051/monitor/statistics -a baz:bar
http http://localhost:5051/monitor/statistics.json -a baz:bar
http http://localhost:5051/monitor/containers -a baz:bar
```
Thanks,
Alexander Rojas
7;t
# requires authorization.
http GET http://127.0.0.1:5051/flags -a baz:bar
# This should return 401 Unauthorized, the user bar
# is not known.
http GET http://127.0.0.1:5051/flags -a bar:bar
```
Thanks,
Alexander Rojas
tps://reviews.apache.org/r/48058/#comment204807>
This file has a 80 columns line limit. Can you provide a patch fixing it?
- Alexander Rojas
On May 31, 2016, 9:03 a.m., Joerg Schad wrote:
>
> ---
> This is an automatically generated e
401 - 500 of 1224 matches
Mail list logo
