Re: Review Request 70879: Updated webui Roles tab to consistently display '-' for 0 entries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70879/#review215962 --- Ship it! LGTM - Armand Grillet On June 18, 2019, 10:22 p.m

Re: Review Request 70090: Addressed issues flagged by pylint-2.3.1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70090/#review213376 --- Ship it! Ship It! - Armand Grillet On March 3, 2019, 12:39

Re: Review Request 70091: Added tox invocation to test stage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70091/#review213375 --- Ship it! Ship It! - Armand Grillet On March 3, 2019, 6:09

Re: Review Request 70092: Updated to pylint-2.3.1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70092/#review213374 --- Ship it! Ship It! - Armand Grillet On March 3, 2019, 12:39

Re: Review Request 70090: Addressed issues flagged by pylint-2.3.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70090/#review213363 --- Ship it! Ship It! - Armand Grillet On March 3, 2019, 2:01

Re: Review Request 70092: Updated to pylint-2.3.0.

tps://reviews.apache.org/r/70092/#comment299302> Why is this necessary? The directory `.tox` should mainly have `.py` and `.pyc` but no C++ source files. - Armand Grillet On March 3, 2019, 2:01 a.m., Benjamin Bannier

Re: Review Request 69817: Refactored 'support/verify-reviews.py' to be closer to commit 7412179.

e repository instead of where the > script is being called. > > > Diffs > - > > support/verify-reviews.py 71326d34bb649e27a3a2901867d31a2a1fffd4e9 > > > Diff: https://reviews.apache.org/r/69817/diff/1/ > > > Testing > --- > > > Thanks, > > Armand Grillet > >

Review Request 69817: Refactored 'support/verify-reviews.py' to be closer to commit 7412179.

the script so that they are run from the repository instead of where the script is being called. Diffs - support/verify-reviews.py 71326d34bb649e27a3a2901867d31a2a1fffd4e9 Diff: https://reviews.apache.org/r/69817/diff/1/ Testing --- Thanks, Armand Grillet

Review Request 69701: Improved debuggability of `verify-reviews.py`.

://reviews.apache.org/r/69701/diff/1/ Testing --- Thanks, Armand Grillet

Review Request 69698: Added try/except for `shell()` calls in `verify-reviews.py`.

: https://reviews.apache.org/r/69698/diff/1/ Testing --- Thanks, Armand Grillet

Review Request 69697: Reverted cleanup step of `verify-reviews.py`.

support/verify-reviews.py 72f98b234d9a2a84decb0569998d74e4c730122d Diff: https://reviews.apache.org/r/69697/diff/1/ Testing --- Thanks, Armand Grillet

Re: Review Request 69662: Displayed resource provider information in the Mesos webui.

is in `agents.html` (that's a good thing). - Armand Grillet On Jan. 3, 2019, 4 p.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 69559: Simplified verify-reviews.py to be more similar to the Python 2 script.

5960e8e7019ea3d9f Checking if review: 69557 needs verification Latest diff timestamp: 2018-12-12 11:16:24 Latest review timestamp: 2018-12-14 12:22:58 Checking if review: 69445 needs verification Latest diff timestamp: 2018-12-12 20:44:05 Latest review timestamp: 2018-12-14 12:23:02 Checking if review: 69436 needs verification Latest diff timestamp: 2018-11-22 19:40:46 Latest review timestamp: 2018-12-14 12:23:16 4 review requests need verification 69551 69559 69338 69563 git clean -fd git reset --hard 343cf1e8a8f976b461d4bc05960e8e7019ea3d9f ``` Thanks, Armand Grillet

Re: Review Request 69559: Simplified verify-reviews.py to be more similar to the Python 2 script.

e1f6784557189de04f00 - Armand --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69559/#review211355 --- On Dec. 13, 2018, 4:59 p.m

Re: Review Request 69436: Fixed flaky check in cluster::Slave destructor.

> On Dec. 14, 2018, 1:23 p.m., Armand Grillet wrote: > > Bad patch! > > > > Reviews applied: [69436] > > > > Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:14.04' > > BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose

Re: Review Request 69559: Simplified verify-reviews.py to be more similar to the Python 2 script.

d e-mail. To reply, visit: https://reviews.apache.org/r/69559/#review211306 ----------- On Dec. 13, 2018, 4:59 p.m., Armand Grillet wrote: > > --- > This is an automatically g

Re: Review Request 69436: Fixed flaky check in cluster::Slave destructor.

0-23301 + docker build --no-cache=true -t mesos-1544790190-23301 . Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running? Full log: console - Armand Grillet On Nov. 22, 2018, 7:43 p.m., Benno Evers wrote: > >

Re: Review Request 69445: WIP: Moved `ReadOnlyHandler` into separate header.

. Please find a reviewer by asking on JIRA or the mailing list. - Armand Grillet On Dec. 12, 2018, 8:54 p.m., Benno Evers wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 69557: Removed redundant handling of empty framework IDs.

ion_tests.cpp: patch does not apply Full log: console - Armand Grillet On Dec. 12, 2018, 11:29 a.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://r

Re: Review Request 69559: Simplified verify-reviews.py to be more similar to the Python 2 script.

review 69557 Dependent review: https://reviews.apache.org/api/review-requests/69398/ Dependent review: https://reviews.apache.org/api/review-requests/69397/ Applying review 69397 /usr/local/opt/python/bin/python3.7 support/apply-reviews.py -n -r 69397 ``` Thanks, Armand Grillet

Re: Review Request 69547: Added a test `ROOT_UNPRIVILEGED_USER_TaskSandboxSharedPersistentVolume`.

. Please find a reviewer by asking on JIRA or the mailing list. - Armand Grillet On Dec. 11, 2018, 1:17 p.m., Qian Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Review Request 69559: Simplified verify-reviews.py to be more similar to the Python 2 script.

://reviews.apache.org/r/69559/diff/1/ Testing --- Checked https://www.diffchecker.com/R5uYlefc, a diff of 'verify-reviews.py' between 74121798f24fca372180b8c4bc00b4df07d46240 and this commit. Thanks, Armand Grillet

Re: Review Request 69395: Added '--all' flag to 'mesos task list'.

(cli.tests.task.TestTaskPlugin) ... ok -- Ran 8 tests in 20.889s OK ``` Thanks, Armand Grillet

Re: Review Request 69395: Added '--all' flag to 'mesos task list'.

(cli.tests.task.TestTaskPlugin) ... ok -- Ran 8 tests in 20.889s OK ``` Thanks, Armand Grillet

Re: Review Request 69426: Replaced CLI test helper function 'running_tasks' by 'wait_for_task'.

test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok test_list (cli.tests.task.TestTaskPlugin) ... ok -- Ran 7 tests in 19.319s OK ``` Thanks, Armand Grillet

Re: Review Request 69395: Added '--all' flag to 'mesos task list'.

(cli.tests.task.TestTaskPlugin) ... ok -- Ran 8 tests in 20.889s OK ``` Thanks, Armand Grillet

Re: Review Request 69426: Replaced CLI test helper function 'running_tasks' by 'wait_for_task'.

test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok test_list (cli.tests.task.TestTaskPlugin) ... ok -- Ran 7 tests in 19.319s OK ``` Thanks, Armand Grillet

Re: Review Request 69394: Updated 'mesos task list' to only display running tasks.

) ... ok test_exec_exit_status (cli.tests.task.TestTaskPlugin) ... ok test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok test_list (cli.tests.task.TestTaskPlugin) ... ok -- Ran 7 tests in 19.845s OK Thanks, Armand Grillet

Review Request 69442: Updated 'REPOSITORY_URL' in 'support/reviewboardrc' to use gitbox.

reviews.apache.org/r/69442/diff/1/ Testing --- Posted this review request after updating '.reviewboardrc' to use `REPOSITORY_URL = "https://gitbox.apache.org/repos/asf/mesos.git`. Thanks, Armand Grillet

Review Request 69426: Replaced CLI test helper function 'running_tasks' by 'wait_for_task'.

-- Ran 7 tests in 19.319s OK ``` Thanks, Armand Grillet

Re: Review Request 69395: Added '--all' flag to 'mesos task list'.

) ... ok -- Ran 8 tests in 20.889s OK ``` Thanks, Armand Grillet

Re: Review Request 69395: Added '--all' flag to 'mesos task list'.

) ... ok -- Ran 8 tests in 20.889s OK ``` Thanks, Armand Grillet

Review Request 69425: Fixed name of task created when running mesos-cli-tests.

-- Ran 7 tests in 19.732s OK ``` Thanks, Armand Grillet

Re: Review Request 69390: Added docs describing how to use the new CLI.

. Thanks, Armand Grillet

Re: Review Request 69390: Added docs describing how to use the new CLI.

) - docs/cli.md PRE-CREATION docs/home.md e05b65d55176a706c072f73904a8e0f4365a8cb2 Diff: https://reviews.apache.org/r/69390/diff/2/ Changes: https://reviews.apache.org/r/69390/diff/1-2/ Testing --- Checked the rendered Markdown code. Thanks, Armand Grillet

Re: Review Request 69393: Displayed 'State' field when using 'mesos task list'.

) ... ok test_exec_exit_status (cli.tests.task.TestTaskPlugin) ... ok test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok test_list (cli.tests.task.TestTaskPlugin) ... ok -- Ran 7 tests in 20.812s OK ``` Thanks, Armand

Review Request 69395: Added '--all' flag to 'mesos task list'.

, Armand Grillet

Review Request 69394: Updated 'mesos task list' to only display running tasks.

(cli.tests.task.TestTaskPlugin) ... ok -- Ran 7 tests in 19.845s OK Thanks, Armand Grillet

Review Request 69393: Displayed 'State' field when using 'mesos task list'.

(cli.tests.task.TestTaskPlugin) ... ok -- Ran 7 tests in 20.812s OK ``` Thanks, Armand Grillet

Review Request 69390: Added docs describing how to use the new CLI.

Diff: https://reviews.apache.org/r/69390/diff/1/ Testing --- Checked the rendered Markdown code. Thanks, Armand Grillet

Review Request 69381: Updated configuration docs describing how to build the new CLI.

0cba405c53c5e2efdc7170abdafdd4a5db331804 Diff: https://reviews.apache.org/r/69381/diff/1/ Testing --- Checked the rendered Markdown code. Thanks, Armand Grillet

Review Request 69380: Added configuration docs describing how to use Python 3.

/configuration/cmake.md 0cba405c53c5e2efdc7170abdafdd4a5db331804 Diff: https://reviews.apache.org/r/69380/diff/1/ Testing --- Checked the rendered Markdown code. Thanks, Armand Grillet

Review Request 69374: Updated new CLI test step to use binary created by PyInstaller.

/cli_new/bin/mesos /home/agrillet/mesos/src/python/cli_new/bin/mesos2 $ ctest -R CLITests -V ``` Thanks, Armand Grillet

Re: Review Request 69310: Always used absolute executable paths in parallel runner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69310/#review210469 --- Ship it! Ship It! - Armand Grillet On Nov. 11, 2018, 1:01

Re: Review Request 69309: Explicitly constructed command line args in parallel runner.

(original), 72 (patched) <https://reviews.apache.org/r/69309/#comment295151> s/`command lint`/`command line` - Armand Grillet On Nov. 11, 2018, 1:01 a.m., Benjamin Bannier wrote: > > --- > This is an automatically g

Re: Review Request 69275: Added environment sanity check to parallel test runner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69275/#review210384 --- Ship it! Ship It! - Armand Grillet On Nov. 7, 2018, 10:41

Re: Review Request 69274: Reduced default oversubscription in parallel test runner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69274/#review210376 --- Ship it! Ship It! - Armand Grillet On Nov. 7, 2018, 9:30

Re: Review Request 69275: Added environment sanity check to parallel test runner.

(patched) <https://reviews.apache.org/r/69275/#comment295044> Double space here. - Armand Grillet On Nov. 7, 2018, 9:30 p.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 69255: Updated PyInstaller requirement for new CLI to support Python 3.7.

pen again with Python 3.8. - Armand --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69255/#review210335 --- On Nov. 5,

Review Request 69255: Updated PyInstaller requirement for new CLI to support Python 3.7.

/69255/diff/1/ Testing --- ``` $ ./bootstrap $ mkdir build $ cd build $ PYTHON_3=python37 ../configure --enable-new-cli $ make check $ ./src/mesos ``` Thanks, Armand Grillet

Review Request 69237: Simplified 'test_exec' in new CLI to better manage newlines.

-- Ran 7 tests in 17.531s OK ``` Thanks, Armand Grillet

Review Request 69208: Updated new CLI task attach/exec exit strategy.

) ... ok test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok test_list (cli.tests.task.TestTaskPlugin) ... ok -- Ran 7 tests in 17.146s OK ``` Thanks, Armand Grillet

Review Request 69207: Moved 'updated_tasks()' to new CLI tests base.

-- Ran 6 tests in 12.429s OK ``` Thanks, Armand Grillet

Review Request 69206: Added return value to new Mesos CLI commands.

-- Ran 6 tests in 12.429s OK ``` Thanks, Armand Grillet

Review Request 69138: Updated 'CLI_FILES' in 'cli_new/CmakeLists.txt'.

--- Thanks, Armand Grillet

Re: Review Request 69115: Added test for interactive 'task exec'.

) ... ok -- Ran 6 tests in 12.602s OK ``` Thanks, Armand Grillet

Re: Review Request 69049: Added test for 'task exec'.

) ... ok -- Ran 5 tests in 8.754s OK ``` Thanks, Armand Grillet

Review Request 69119: Added new CLI constants 'TEST_DIRECTORY' and 'TEST_DATA_DIRECTORY'.

/ Testing --- Thanks, Armand Grillet

Re: Review Request 69049: Added test for 'task exec'.

) ... ok -- Ran 5 tests in 8.754s OK ``` Thanks, Armand Grillet

Re: Review Request 69114: Added 'exec_command' to test util functions for the new CLI.

/tests/base.py 3fb471c1f49e930d908322055bb9a188f88ee602 Diff: https://reviews.apache.org/r/69114/diff/2/ Changes: https://reviews.apache.org/r/69114/diff/1-2/ Testing --- Tested later in the chain. Thanks, Armand Grillet

Review Request 69116: Added 'popen_tty' to test util functions for the new CLI.

a TTY. This will be the case for tests concerning the 'task attach' subcommand. Diffs - src/python/cli_new/lib/cli/tests/base.py 3fb471c1f49e930d908322055bb9a188f88ee602 Diff: https://reviews.apache.org/r/69116/diff/1/ Testing --- Thanks, Armand Grillet

Re: Review Request 69075: Updated docker image fetcher to enforce HTTP 1.x.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69075/#review209845 --- Ship it! Ship It! - Armand Grillet On Oct. 22, 2018, 1:22

Review Request 69115: Added test for interactive 'task exec'.

TestTaskPlugin test_exec (cli.tests.task.TestTaskPlugin) ... ok test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok test_list (cli.tests.task.TestTaskPlugin) ... ok -- Ran 6 tests in 12.602s OK ``` Thanks, Armand Grillet

Review Request 69049: Added test for 'task exec'.

test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok TestTaskPlugin test_exec (cli.tests.task.TestTaskPlugin) ... ok test_list (cli.tests.task.TestTaskPlugin) ... ok -- Ran 5 tests in 8.754s OK ``` Thanks, Armand Grillet

Review Request 69048: Added tenacity to 'pip-requirements' for new CLI.

/ Testing --- Tested later in the chain. Thanks, Armand Grillet

Review Request 69114: Added 'exec_command' to test util functions for the new CLI.

/diff/1/ Testing --- Tested later in the chain. Thanks, Armand Grillet

Review Request 69105: Added 'task atach' subcommand to new CLI.

em/linux,docker/runtime,namespaces/pid" $ sudo src/mesos-execute \ --master=127.0.0.1:5050 \ --name=tty-test \ --docker_image=library/alpine \ --no-shell \ --tty \ --command="sh -i" $ cd src/python/cli_new $ source activate $ mesos task attach tty-test

Re: Review Request 69104: Fixed formatting in subcommand help in the new CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69104/#review209821 --- Ship it! Ship It! - Armand Grillet On oct. 20, 2018, 11:30

Re: Review Request 69103: Fixed bug in 'execute.cpp' with tty-based tasks and no 'containerInfo'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69103/#review209820 --- Ship it! Ship It! - Armand Grillet On Oct. 20, 2018, 10:57

Review Request 69084: Updated 'Makefile.am' to make new CLI build step more reliable.

/Makefile.am 5795c7097a9ed1f659e169ad81a9f2c09481aa81 Diff: https://reviews.apache.org/r/69084/diff/1/ Testing --- ``` $ ./bootstrap $ mkdir build $ cd build $ ../configure --enable-new-cli --disable-java --disable-python $ make check $ ./src/mesos Mesos CLI ... ``` Thanks, Armand Grillet

Re: Review Request 68977: Added Record-IO encoder and decoder to Python library.

== __ summary __ py3-test: commands succeeded congratulations :) ``` Thanks, Armand Grillet

Re: Review Request 68977: Added Record-IO encoder and decoder to Python library.

(cli.tests.recordio.TestRecordIO) ... ok test_encode_decode (cli.tests.recordio.TestRecordIO) ... ok TestTaskPlugin test_list (cli.tests.task.TestTaskPlugin) ... ok -- Ran 6 tests in 5.008s OK ``` Thanks, Armand Grillet

Re: Review Request 68971: Moved import of '../lib' from new CLI bootstrap to pip-requirements.txt.

mesos.exceptions import MesosException` and use `MesosException`. Commited to see the git hook running and saw the error `E0401: Unable to import 'mesos.exceptions' (import-error).`. Updated `support/pylint.config`, run the git hook again and saw that the error was gone. Thanks, Armand Grillet

Review Request 69047: Updated Python library to be easier to handle as a Python module.

08f854f43681d1f694bb48604773256be7ce927b Diff: https://reviews.apache.org/r/69047/diff/1/ Testing --- Thanks, Armand Grillet

Review Request 69026: Changed usage documentation for new CLI.

) mesos task exec --version mesos task exec [options] [...] Options: -h --help Show this screen. -i --interactive interactive [default: False] -t --tty tty [default: False] Description: Execute commands in a task's container ``` Thanks, Armand Grillet

Re: Review Request 68978: Added TaskIO object to new CLI for `task exec` and `task attach`.

7cf84bcf1d327bc9c63934e371692cef989ad3aa Diff: https://reviews.apache.org/r/68978/diff/5/ Changes: https://reviews.apache.org/r/68978/diff/4-5/ Testing --- Thanks, Armand Grillet

Review Request 69023: Added `retry` argument to `request()` method for Resource object.

/r/69023/diff/1/ Testing --- Used `task exec` successfully later in this chain. Tests suite of the lib still passing. Thanks, Armand Grillet

Re: Review Request 69003: Added `task exec` to new CLI.

task exec --interactive cat ``` Thanks, Armand Grillet

Review Request 69007: Added `get_container_id` to util functions for the new CLI.

Diff: https://reviews.apache.org/r/69007/diff/1/ Testing --- Thanks, Armand Grillet

Re: Review Request 69003: Added `task exec` to new CLI.

/python/cli_new/lib/cli/plugins/task/main.py a47a8c53ee2d8d468ea0f9947ea3f65d81fc9251 Diff: https://reviews.apache.org/r/69003/diff/2/ Changes: https://reviews.apache.org/r/69003/diff/1-2/ Testing (updated) --- Only tested manually at the moment. Thanks, Armand Grillet

Re: Review Request 68977: Added Record-IO encoder and decoder to new CLI.

-- Ran 6 tests in 5.008s OK ``` Thanks, Armand Grillet

Review Request 69003: WIP: Added `task exec` to new CLI.

, Armand Grillet

Review Request 68978: Added TaskIO object to new CLI for `task exec` and `task attach`.

--- Thanks, Armand Grillet

Review Request 68977: Added Record-IO encoder and decoder to new CLI.

://issues.apache.org/jira/browse/MESOS-6551 Repository: mesos Description --- Added Record-IO encoder and decoder to new CLI. Diffs - src/python/cli_new/lib/cli/recordio.py PRE-CREATION Diff: https://reviews.apache.org/r/68977/diff/1/ Testing --- Thanks, Armand Grillet

Review Request 68976: Added `post()` function to new CLI for interacting with the HTTP API.

--- Thanks, Armand Grillet

Review Request 68971: Added pylint init-hook to add Mesos library to `PYTHONPATH`.

was gone. Thanks, Armand Grillet

Review Request 68970: Fixed JSON object type error when using `support/apply-reviews.py`.

(json_str))` in `def url_to_json(url):` to verify that the type was now a `str` and not a `http.client.HTTPResponse`. Thanks, Armand Grillet

Re: Review Request 68965: Added try/catch statements when using Mesos util functions in new CLI.

) ... ok test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok TestTaskPlugin test_list (cli.tests.task.TestTaskPlugin) ... ok -- Ran 4 tests in 5.350s OK ``` Thanks, Armand Grillet

Review Request 68965: Added try/catch statements when using Mesos util functions in new CLI.

``` Thanks, Armand Grillet

Re: Review Request 66683: Updated address sanitization in new CLI to accept DNS names.

aster1-log' --registry=in_memory`. Also ran `mesos-cli-tests` successfully. Thanks, Armand Grillet

Re: Review Request 66683: Updated address sanitization in new CLI to accept DNS names.

=in_memory`. Also ran `mesos-cli-tests` successfully. Thanks, Armand Grillet

Re: Review Request 66683: Updated address sanitization in new CLI to accept DNS names.

_dir='/tmp/master1' --log_dir='/tmp/master1-log' --registry=in_memory`. Also ran `mesos-cli-tests` successfully. Thanks, Armand Grillet

Re: Review Request 68951: Updated verify-reviews.py to use current interpreter in subprocesses.

e-mail. To reply, visit: https://reviews.apache.org/r/68951/#review209317 ----------- On Oct. 8, 2018, 8:06 p.m., Armand Grillet wrote: > > --- > This is an automatically gen

Review Request 68951: Updated verify-reviews.py to use current interpreter in subprocesses.

uot;" print("Applying review %s" % review_id) print("%s support/apply-reviews.py -n -r %s" % (sys.executable, review_id)) apply_review(1337) apply_review("1337") ``` In both cases, `python3 test.py` prints `/usr/local/bin/python3 support/apply-reviews.py -n -r 1337` which is what I expected. Thanks, Armand Grillet

Re: Review Request 68711: Added `task ls` command to new CLI.

(cli.tests.tests.TestInfrastructure) ... ok TestTaskPlugin test_list (cli.tests.task.TestTaskPlugin) ... ok test_ls (cli.tests.task.TestTaskPlugin) ... ok -- Ran 5 tests in 9.656s OK ``` Thanks, Armand Grillet

Review Request 68950: Moved `get_agent_address` from `util.py` to `mesos.py` in new CLI.

7cec7e49ab3c0926067626f5bd5dbba8bf4f44d7 Diff: https://reviews.apache.org/r/68950/diff/1/ Testing --- ``` $ mesos-cli-tests ``` Thanks, Armand Grillet

Review Request 68949: Removed unused `lib/cli/tasks.py` for new CLI.

-cli-tests ``` Thanks, Armand Grillet

Review Request 68939: Updated cpplint.py to be less verbose when there is no linting issue.

rdparty/stout/include/stout/option.hpp [MESOS-9056 6b57b1bcd] Added support for `Option` / `Option`. Author: Benjamin Mahler 1 file changed, 44 insertions(+) ``` The updated `cpplint.patch` has been created using `git diff`. Thanks, Armand Grillet

Review Request 68937: Removed output in mesos-style.py when linting goes well.

changed, 3 insertions(+), 3 deletions(-) ``` Thanks, Armand Grillet

Re: Review Request 66683: Updated address field of new CLI config to accept URLs.

:5061" ``` On the server providing `http://.com` I had a Mesos master running with `bash mesos-master.sh --port='5061' --work_dir='/tmp/master1' --log_dir='/tmp/master1-log' --registry=in_memory`. Also ran `mesos-cli-tests` successfully. Thanks, Armand Grillet

  1   2   3   4   5   6   >