/containerizer/mesos/containerizer.cpp
7ab0b07f689f872573ca458ae47cd6426ebc0365
Diff: https://reviews.apache.org/r/64575/diff/1/
Testing
---
```
GTEST_FILTER="" nice make check -j16 V=0
```
Thanks,
Armand Grillet
: Restart the agent.
```
I have thus removed the tab before `This ensures agent doesn't recover` as it
did not appear in the logs.
Thanks,
Armand Grillet
as follows:
Nov: Step 1: rm -f /var/lib/mesos/slave/meta/slaves/latest
Nov: This ensures agent doesn't recover old live executors.
Nov: Step 2: Restart the agent.
```
I have thus removed the tab before `This ensures agent doesn't recover` as it
did not appear in the logs.
Thanks,
Armand Grillet
ot;: "SCALAR",
"scalar": {
"value": 2
}
}
],
"command": {
"value": "sleep 1000"
},
"check": {
"type": "COMMAND",
"command": {
"command": {
"value": "echo \"Bonjour\""
},
"uris": []
}
}
}
]
}
```
And:
```
$ nice make check
```
Thanks,
Armand Grillet
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63999/#review191898
---
Ship it!
Ship It!
- Armand Grillet
On nov. 27, 2017, 3:44
tps://reviews.apache.org/r/63999/#comment269831>
Could you please add a comment explaining how does the flags passed on the
command line have precedence over the defaults?
- Armand Grillet
On Nov. 21, 2017, 9:09 p.m., Benjamin Bannier
ot;: 2
}
}
],
"command": {
"value": "sleep 1000"
},
"check": {
"type": "COMMAND",
"command": {
"command": {
"value": "echo \"Bonjour\""
},
"uris": []
}
}
}
]
}
```
And:
```
$ nice make check
```
Thanks,
Armand Grillet
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64068/#review191875
---
Ship it!
Ship It!
- Armand Grillet
On Nov. 24, 2017, 7:12
uot;,
"type": "SCALAR",
"scalar": {
"value": 2
}
}
],
"command": {
"value": "sleep 1000"
},
"check": {
"type": "COMMAND",
"command": {
"command": {
"value": "echo \"Bonjour\""
},
"uris": []
}
}
}
]
}
```
And:
```
$ nice make check
```
Thanks,
Armand Grillet
uot;type": "SCALAR",
"scalar": {
"value": 2
}
}
],
"command": {
"value": "sleep 1000"
},
"check": {
"type": "COMMAND",
"command": {
"command": {
"value": "echo \"Bonjour\""
},
"uris": []
}
}
}
]
}
```
And:
```
$ nice make check
```
Thanks,
Armand Grillet
-
src/slave/http.cpp c4d8098df8cf9dd2cc2301b76460dd5e3bdb2bad
Diff: https://reviews.apache.org/r/63833/diff/1/
Testing
---
```
$ make check
```
Thanks,
Armand Grillet
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63726/#review190717
---
Ship it!
Ship It!
- Armand Grillet
On Nov. 10, 2017, 3 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63726/#review190716
---
Ship it!
Ship It!
- Armand Grillet
On nov. 10, 2017, 2:56
---
Thanks,
Armand Grillet
/webui/master/static/js/*.js
```
Thanks,
Armand Grillet
,
Armand Grillet
/controllers.js
```
Thanks,
Armand Grillet
https://issues.apache.org/jira/browse/MESOS-7924
Repository: mesos
Description
---
See summary.
Diffs
-
src/webui/master/static/js/controllers.js
e753709f59d1cc5deafb632a4feab453964f1dae
Diff: https://reviews.apache.org/r/63703/diff/1/
Testing
---
Thanks,
Armand
/slave/http.cpp cfae9979e58bca1864551bf16b741d6bae6602f8
Diff: https://reviews.apache.org/r/63694/diff/1/
Testing
---
```
$ make check
```
Thanks,
Armand Grillet
://reviews.apache.org/r/63661/diff/1/
Testing
---
```
$ make check
```
Thanks,
Armand Grillet
/62938/diff/4-5/
Testing
---
Tested with a Mesos cluster running with 3 masters and 1 agent, run some CLI
commands successfully.
Thanks,
Armand Grillet
Diff: https://reviews.apache.org/r/63585/diff/1/
Testing
---
Used the linters after applying this patch.
Thanks,
Armand Grillet
7aeac344c47ccd2588fded44d7314db7abd85653
Diff: https://reviews.apache.org/r/63582/diff/1/
Testing
---
Used the linters after applying this patch.
Thanks,
Armand Grillet
/
Testing
---
Used the linters after applying this patch.
Thanks,
Armand Grillet
support/mesos-style.py b2fdac9f8f76bdf8d8ede9ad8a056e4bb8c2754c
support/pip-requirements.txt PRE-CREATION
Diff: https://reviews.apache.org/r/63581/diff/1/
Testing
---
Used the linters after applying this patch.
Thanks,
Armand Grillet
at=100
```
And `make check`.
Thanks,
Armand Grillet
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63463/#review189899
---
Ship it!
Ship It!
- Armand Grillet
On Nov. 1, 2017, 2:39
/62938/diff/1-2/
Testing
---
Tested with a Mesos cluster running with 3 masters and 1 agent, run some CLI
commands successfully.
Thanks,
Armand Grillet
Description
---
See summary.
Diffs
-
3rdparty/libprocess/src/process.cpp 2334e2656dddbaa0b3532715e0a18132e1b898fd
Diff: https://reviews.apache.org/r/63146/diff/1/
Testing
---
```
$ make check
```
Thanks,
Armand Grillet
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62595/#review188655
---
Ship it!
Ship It!
- Armand Grillet
On Sept. 26, 2017, 10:54
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62595/#review188654
---
LGTM.
- Armand Grillet
On Sept. 26, 2017, 10:54 p.m., Till
085ff3b820693c9ef0115a74d72b0d87f158a887
Diff: https://reviews.apache.org/r/63114/diff/1/
Testing (updated)
---
```sh
$ make check
$ DISTCHECK_CONFIGURE_FLAGS=" --disable-java" make distcheck
```
Thanks,
Armand Grillet
,
Armand Grillet
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63101/#review188488
---
Ship it!
Ship It!
- Armand Grillet
On Oct. 18, 2017, 12:12
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63102/#review188473
---
Ship it!
Ship It!
- Armand Grillet
On Oct. 18, 2017, 10:21
to commit a change on a JavaScript
file and checked that ESLinter was correctly running.
Thanks,
Armand Grillet
dd109c09368e650b7d7dabd663c11bc2e3e5180a
src/python/cli_new/pip-requirements.txt
7aeac344c47ccd2588fded44d7314db7abd85653
Diff: https://reviews.apache.org/r/62938/diff/1/
Testing
---
Tested with a Mesos cluster running with 3 masters and 1 agent, run some CLI
commands successfully.
Thanks,
Armand Grillet
-port=5037
--work_dir=/tmp/test-mesos/work/` and checked that the new output was as
expected.
Thanks,
Armand Grillet
---
Run `GLOG_v=1 ./mesos-local.sh --log_dir=/tmp/test-mesos/log/ --num_slaves=3
--port=5037 --work_dir=/tmp/test-mesos/work/` and `GLOG_v=2 ./mesos-local.sh
--log_dir=/tmp/test-mesos/log/ --num_slaves=3 --port=5037
--work_dir=/tmp/test-mesos/work/` and checked that the new output was as
expected.
Thanks,
Armand Grillet
-work_dir=/tmp/test-mesos/work/` and `GLOG_v=2 ./mesos-local.sh
--log_dir=/tmp/test-mesos/log/ --num_slaves=3 --port=5037
--work_dir=/tmp/test-mesos/work/` and checked that the new output was correct.
Thanks,
Armand Grillet
.
Thanks,
Armand Grillet
eviews.apache.org/r/62793/#review187534
---
On Oct. 10, 2017, 9:57 a.m., Armand Grillet wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62793/
> ---
1ca
src/webui/master/static/js/controllers.js
fa0ad54cbcec7a3b0bea9e2b0dc70a4c3f41e822
support/apply-reviews.py 23f20477f7edb1d7932630012a411d28c2720747
Diff: https://reviews.apache.org/r/62864/diff/1/
Testing
---
Thanks,
Armand Grillet
I have modified 'support/cpplint.py' and checked that it was
not linted.
Thanks,
Armand Grillet
I have modified 'support/cpplint.py' and checked that it was
not linted.
Thanks,
Armand Grillet
that ESLinter was correctly running.
Thanks,
Armand Grillet
/cpplint.py' and checked that it was
not linted.
Thanks,
Armand Grillet
have modified 'support/cpplint.py' and checked that it was
not linted.
Thanks,
Armand Grillet
-reviews.py 5ecde40553c6b1ace9bfcf27a7268450b8bc2838
Diff: https://reviews.apache.org/r/62788/diff/1/
Testing
---
Thanks,
Armand Grillet
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62592/#review186846
---
LGTM.
- Armand Grillet
On Oct. 2, 2017, 10:12 a.m., Till
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62591/#review186841
---
LGTM.
- Armand Grillet
On Sept. 26, 2017, 10:54 p.m., Till
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62595/#review186835
---
LGTM.
- Armand Grillet
On Sept. 26, 2017, 10:54 p.m., Till
(patched)
<https://reviews.apache.org/r/62587/#comment263674>
`s/signalled/signaled`.
- Armand Grillet
On Oct. 2, 2017, 10:09 a.m., Till Toenshoff wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
/
Testing
---
Following this commit, I have tried to commit a change on a JavaScript file and
checked that ESLinter was correctly running.
Thanks,
Armand Grillet
of `.py` and `.js` files then test commits to see if the linters
before and afer removing their `.virtualenv` were still working as expected.
Thanks,
Armand Grillet
://reviews.apache.org/r/62687/diff/1/
Testing
---
To test with one master:
```
$ ./bootstrap
$ source activate
$ mesos-cli-tests
```
I also checked that the Python linter was still working.
Thanks,
Armand Grillet
Description
---
This fixes the CI issue due to Pylint returning
`"R: 1, 0: Similar lines in 2 files"`.
Diffs
-
src/python/pylint.config c76036441784543eb9025d0bd562a5628c4bad4e
Diff: https://reviews.apache.org/r/62663/diff/1/
Testing
---
Thanks,
Armand Grillet
,
Armand Grillet
-cli-tests
I also checked that the Python linter was still working.
Thanks,
Armand Grillet
-cli-tests
```
I also checked that the Python linter was still working.
Thanks,
Armand Grillet
: https://reviews.apache.org/r/61212/diff/7/
Changes: https://reviews.apache.org/r/61212/diff/6-7/
Testing
---
Tested manually, PEP8 and Pylint used to make sure that the code style is
correct.
Thanks,
Armand Grillet
,
Armand Grillet
/python/cli_new/lib/cli/util.py 7371f83543ed527bea8dbf2fe4e20d92ef8e4492
Diff: https://reviews.apache.org/r/61212/diff/6/
Changes: https://reviews.apache.org/r/61212/diff/5-6/
Testing
---
Tested manually, PEP8 and Pylint used to make sure that the code style is
correct.
Thanks,
Armand
---
This will be used by future commands and functions of the CLI.
Diffs
-
src/python/cli_new/lib/cli/constants.py PRE-CREATION
Diff: https://reviews.apache.org/r/62572/diff/1/
Testing
---
Thanks,
Armand Grillet
that ESLinter was correctly running.
Thanks,
Armand Grillet
` were still working as expected.
Thanks,
Armand Grillet
ing
> ---
>
> Manual updates of `.py` and `.js` files then test commits to see if the
> linters before and afer removing their `.virtualenv` were still working as
> expected.
>
>
> Thanks,
>
> Armand Grillet
>
>
,
Armand Grillet
```
I also checked that the Python linter was still working.
Thanks,
Armand Grillet
7371f83543ed527bea8dbf2fe4e20d92ef8e4492
Diff: https://reviews.apache.org/r/60088/diff/6/
Changes: https://reviews.apache.org/r/60088/diff/5-6/
Testing
---
Tested manually, PEP8 and Pylint used to make sure that the code style is
correct.
Thanks,
Armand Grillet
,
Armand Grillet
,
Armand Grillet
://reviews.apache.org/r/62434/diff/1/
Testing
---
Change in the UI tested with Google Chrome 61.0.3163.91.
Thanks,
Armand Grillet
/scheduler.cpp ce69258027ed50867569374d2d827fc3cc651744
src/slave/main.cpp d53ff5013e00421ef1e13593584bd132a59738fb
src/tests/main.cpp a7dc99b90f84a1a1ea299c937fbfc84e55adad1c
Diff: https://reviews.apache.org/r/62357/diff/2/
Testing
---
```
make check
```
Thanks,
Armand Grillet
PRE-CREATION
support/mesos-style.py cf37d9f4da4ab90b92f0136a1dcd5dd8bbae5785
Diff: https://reviews.apache.org/r/62214/diff/2/
Testing
---
Following this commit, I have tried to commit a change on a JavaScript file and
checked that ESLinter was correctly running.
Thanks,
Armand Grillet
result as using it after running
`mesos::internal::logging::initialize` without flags.
Thanks,
Armand Grillet
d53ff5013e00421ef1e13593584bd132a59738fb
src/tests/main.cpp a7dc99b90f84a1a1ea299c937fbfc84e55adad1c
Diff: https://reviews.apache.org/r/62357/diff/1/
Testing
---
```
make check
```
Thanks,
Armand Grillet
> have you considered adding some kind of VirtualEnv class or making these
> > standalone virtualenv functions here for them to both reuse?
/r/62333/
- Armand
---
This is an automatically generated e-mail. To repl
on a JavaScript file and
checked that ESLinter was correctly running.
Thanks,
Armand Grillet
/1/
Testing
---
Manual updates of `.py` and `.js` files then test commits to see if the linters
before and afer removing their `.virtualenv` were still working as expected.
Thanks,
Armand Grillet
e11f881e947c11fd9fac717f12101726c2c6e380
src/webui/master/static/js/controllers.js
339dfc4786ef4b88b9a16a0eb41b9b72836d469b
src/webui/master/static/js/services.js
afd25441813324ce54f09733fd501ebf1564ef7d
Diff: https://reviews.apache.org/r/62332/diff/1/
Testing
---
Thanks,
Armand
f0
Diff: https://reviews.apache.org/r/62037/diff/4/
Changes: https://reviews.apache.org/r/62037/diff/3-4/
Testing
---
```
make check
```
Had an issue with ExamplesTest.DiskFullFramework that is not related.
Thanks,
Armand Grillet
tested manually to see if using `LOG()` without initializing GLOG gives
the same result as using it `LOG()` after running
`mesos::internal::logging::initialize` without flags.
Thanks,
Armand Grillet
```
Also tested manually to see if using `LOG()` without initializing GLOG gives
the same result as using it `LOG()` after running
`mesos::internal::logging::initialize` without flags.
Thanks,
Armand Grillet
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62018/#review184487
---
On Sept. 6, 2017, 9:48 a.m., Armand Grillet wrote:
>
> ---
rg/r/62037/diff/2-3/
Testing
---
```
make check
```
Had an issue with ExamplesTest.DiskFullFramework that is not related.
Thanks,
Armand Grillet
tomatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62018/#review184968
-------
On Sept. 6, 2017, 9:48 a.m., Armand Grillet wrote:
>
> ---
> This is an au
-requirements.txt PRE-CREATION
support/mesos-style.py cf37d9f4da4ab90b92f0136a1dcd5dd8bbae5785
Diff: https://reviews.apache.org/r/62214/diff/1/
Testing
---
Following this commit, I have tried to commit a change on a JavaScript file and
checked that ESLinter was correctly invoked.
Thanks,
Armand
,
Armand Grillet
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62116/#review184667
---
LGTM.
- Armand Grillet
On Sept. 6, 2017, 10:03 a.m., Alexander
eviews.apache.org/r/62037/#review184488
---
On Sept. 6, 2017, 9:57 a.m., Armand Grillet wrote:
>
> ---
> This is an automatically generated e-mail. To re
ges: https://reviews.apache.org/r/62037/diff/1-2/
Testing
---
```
make check
```
Had an issue with ExamplesTest.DiskFullFramework that is not related.
Thanks,
Armand Grillet
```
Thanks,
Armand Grillet
gree?
- Armand
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62037/#review184488
---
On Sept. 1, 2017, 3:47 p.m., Armand Grillet wrote:
and --quorum.
3. Started one agent.
4. Launched one task using ./mesos-execute --master='zk://127.0.0.1:2181/mesos'
--name='test' --command='sleep 3600'.
5. Checked that the output of 'mesos container list' was correct.
I also checked that the Python linter was still working.
Thanks,
Armand Grillet
---
This is useful as CLI plugins have similar imports.
Diffs
-
src/python/cli_new/pylint.config 63fbb94fbf47cccd1053b4c1eafac18b88dbc818
Diff: https://reviews.apache.org/r/62066/diff/1/
Testing
---
Thanks,
Armand Grillet
='sleep 3600'`.
5. Checked that the output of 'mesos task list' was correct.
I also checked that the Python linter was still working.
Thanks,
Armand Grillet
one agent.
4. Launched one task using ./mesos-execute --master='zk://127.0.0.1:2181/mesos'
--name='test' --command='sleep 3600'.
5. Checked that the output of 'mesos agent list' was correct.
I also checked that the Python linter was still working.
Thanks,
Armand Grillet
7371f83543ed527bea8dbf2fe4e20d92ef8e4492
Diff: https://reviews.apache.org/r/61212/diff/3/
Changes: https://reviews.apache.org/r/61212/diff/2-3/
Testing
---
Tested manually, PEP8 and Pylint used to make sure that the code style is
correct.
Thanks,
Armand Grillet
one task using `./mesos-execute
--master='zk://127.0.0.1:2181/mesos' --name='test' --command='sleep 3600'`.
5. Checked that the output of 'mesos task list' was correct.
I also checked that the Python linter was still working.
Thanks,
Armand Grillet
301 - 400 of 543 matches
Mail list logo
