/2-3/
Testing
---
Thanks,
Benno Evers
#x27;ve used `metricEquals()` now that it isn't a macro anymore.
- Benno
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70156/#review213540
-----
b2f22cd4db223d167aa35109cd8de6df82ed1f4d
Diff: https://reviews.apache.org/r/70156/diff/2/
Changes: https://reviews.apache.org/r/70156/diff/1-2/
Testing
---
Thanks,
Benno Evers
I can imagine a name conflict if the test is particularly metric heavy.
> > i.e. if the test defines another `metrics` local variable.
That's fine, the macro is introducing a new scope.
- Benno
-------
This
4dd73fb18a06ce8f75c4c1435dba84ade123bee9
Diff: https://reviews.apache.org/r/70116/diff/2/
Changes: https://reviews.apache.org/r/70116/diff/1-2/
Testing
---
Thanks,
Benno Evers
/
Testing
---
Thanks,
Benno Evers
: mesos
Description
---
Added helper to test for metrics values.
Diffs
-
src/tests/utils.hpp b2f22cd4db223d167aa35109cd8de6df82ed1f4d
Diff: https://reviews.apache.org/r/70156/diff/1/
Testing
---
Thanks,
Benno Evers
ays before committing this
so we can clarify the current ReviewBoard status with the ASF Infra team.
- Benno Evers
On March 6, 2019, 2:32 p.m., Benno Evers wrote:
>
> ---
> This is an automatically generated e-mail. To re
)
-
docs/advanced-contribution.md 28a314178f12cd5b8b7c5b43b1ecb564061c3fe1
Diff: https://reviews.apache.org/r/70129/diff/2/
Changes: https://reviews.apache.org/r/70129/diff/1-2/
Testing
---
Thanks,
Benno Evers
://reviews.apache.org/r/70129/diff/1/
Testing
---
Thanks,
Benno Evers
22a0295086ae4f4ec26df00a0e077eecfa27f1fb
src/tests/storage_local_resource_provider_tests.cpp
75f0d818a94d7a15d1df169683724294e07fdb69
Diff: https://reviews.apache.org/r/70117/diff/1/
Testing
---
Thanks,
Benno Evers
665c1c7979a5ae4ecec0d5a68e59c5419049a4d5
src/master/metrics.hpp 4495e65b6bb11f7236335a702c4f61e7c3f9b0aa
src/master/metrics.cpp 4dd73fb18a06ce8f75c4c1435dba84ade123bee9
Diff: https://reviews.apache.org/r/70116/diff/1/
Testing
---
Thanks,
Benno Evers
665c1c7979a5ae4ecec0d5a68e59c5419049a4d5
Diff: https://reviews.apache.org/r/70115/diff/1/
Testing
---
Thanks,
Benno Evers
AS WELL, but then I saw
that it's already in there!
- Benno Evers
On Feb. 21, 2019, 11:33 a.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.a
filesystem.
Thanks,
Benno Evers
---
This patch adds `master_load_tests.cpp` to the cmake build
system.
Diffs
-
src/tests/CMakeLists.txt b647d5b2b2273e0ba77accf2b213dc07ce34f399
Diff: https://reviews.apache.org/r/70022/diff/1/
Testing
---
CI run still in progress.
Thanks,
Benno Evers
://reviews.apache.org/r/70002/diff/1/
Testing
---
Clicked on the links to ensure no typos.
Thanks,
Benno Evers
s.hpp c2a5e5531de7498241e537ef1699e1a5e669b550
Diff: https://reviews.apache.org/r/69723/diff/3/
Changes: https://reviews.apache.org/r/69723/diff/2-3/
Testing
---
./src/mesos-tests
Thanks,
Benno Evers
s.cpp 1f8da63aa313c4679c0d7a3934802af1474e8f28
src/tests/mesos.hpp c2a5e5531de7498241e537ef1699e1a5e669b550
Diff: https://reviews.apache.org/r/69723/diff/2/
Changes: https://reviews.apache.org/r/69723/diff/1-2/
Testing
---
./src/mesos-tests
Thanks,
Benno Evers
cally generated e-mail. To reply, visit:
https://reviews.apache.org/r/69726/#review211936
---
On Jan. 14, 2019, 4:35 p.m., Benno Evers wrote:
>
> ---
> This is an a
/
Changes: https://reviews.apache.org/r/69726/diff/1-2/
Testing
---
Thanks,
Benno Evers
://reviews.apache.org/r/69726/diff/1/
Testing
---
Thanks,
Benno Evers
,
Benno Evers
.
`./src/mesos-tests --gtest_filter="*OperationUpdatesUponUnreachable*" --verbose
--gtest_repeat=5000`
Thanks,
Benno Evers
this test.
- Benno
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69669/#review211836
---
On Jan. 11, 2019, 2:24 p.m., Benno Evers wrote:
/Makefile.am 188a47017221a931d8b965a4af5e033b77e6ce4e
src/tests/master_load_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/69064/diff/7/
Changes: https://reviews.apache.org/r/69064/diff/6-7/
Testing (updated)
---
Several internal CI runs.
Thanks,
Benno Evers
tps://reviews.apache.org/r/69669/#comment297362>
I thought about making this a member function of `struct Slave` instead,
but it felt a bit unclean to suddenly add networking code to it because it
currently acts mostly as a fancy data storage.
- Benno Evers
On Jan. 4, 2019, 4:57 p.m., Benno Evers
sounds exceptionally vague ;)
Maybe we can add a very brief description like "a bug that resulted in a race
between the allocator update and an `UpdateSlaveMessage`"?
- Benno Evers
On Dec. 18, 2018, 9:08 a.m., Greg Mann wrote:
>
> --
FLAG=BUILD_ISOLATORS,label=mesos-ec2-ubuntu-16.04 5.6 sec 606 0 0
```
Thanks,
Benno Evers
/69669/diff/1/
Testing
---
Thanks,
Benno Evers
0
FLAG=SSL,label=mesos-ec2-debian-9 18 min 32630 0
FLAG=SSL,label=mesos-ec2-centos-6 15 min 31680 0
FLAG=BUILD_ISOLATORS,label=mesos-ec2-ubuntu-16.04 5.6 sec 606 0 0
```
Thanks,
Benno Evers
> On Dec. 20, 2018, 1:56 p.m., Benno Evers wrote:
> > src/master/master.cpp
> > Lines 8885 (patched)
> > <https://reviews.apache.org/r/69597/diff/2/?file=2115289#file2115289line8885>
> >
> > After some discussion with @bbannier, I moved the removal i
> On Dec. 21, 2018, 4:34 a.m., Greg Mann wrote:
> > src/tests/api_tests.cpp
> > Lines 4885 (patched)
> > <https://reviews.apache.org/r/69575/diff/3/?file=2115287#file2115287line4885>
> >
> > s/operationId.value()/operationId/
>
> Benno Evers wro
://reviews.apache.org/r/69575/diff/4/
Changes: https://reviews.apache.org/r/69575/diff/3-4/
Testing
---
Thanks,
Benno Evers
-centos-6 15 min 31680 0
FLAG=BUILD_ISOLATORS,label=mesos-ec2-ubuntu-16.04 5.6 sec 606 0 0
```
Thanks,
Benno Evers
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69575/#review211485
---
On Dec. 20, 2018, 12:19 p.m., Benno Evers wrote:
>
> ---
master failovers: Do we lose all
information about operations in this case, or is there some reconciliation
mechanism for operations between master and agents?
- Benno Evers
On Dec. 20, 2018, 1:46 p.m., Benno Evers wrote:
>
> ---
/
Changes: https://reviews.apache.org/r/69597/diff/1-2/
Testing
---
Thanks,
Benno Evers
://reviews.apache.org/r/69575/diff/3/
Changes: https://reviews.apache.org/r/69575/diff/2-3/
Testing
---
Thanks,
Benno Evers
ould just update the
> specific BENCHMARK test to properly filter it.
>
> I don't know if we codify our test naming style anywhere at the moment.
> However, our naming convention is to put any of the test filters at the
> beginning of a test name, rather than the e
/Makefile.am 7a4904a3d67479267087fd2313a263d8218843fa
src/tests/master_load_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/69064/diff/6/
Changes: https://reviews.apache.org/r/69064/diff/5-6/
Testing
---
Thanks,
Benno Evers
we don't need
> > to disable the test? You could even set an arbitrary header which is not
> > interpreted by libprocess.
>
> Benno Evers wrote:
> The endpoints themselves will ignore all headers, so the idea of this
> test was to verify that libprocess can s
://reviews.apache.org/r/69575/diff/2/
Changes: https://reviews.apache.org/r/69575/diff/1-2/
Testing
---
Thanks,
Benno Evers
to be removed.
Diffs
-
src/master/master.cpp b4b02d8b4d7d6d1aabda1f97b9bf824419f76a9e
Diff: https://reviews.apache.org/r/69597/diff/1/
Testing
---
Thanks,
Benno Evers
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69591/#review211434
---
Ship it!
Ship It!
- Benno Evers
On Dec. 19, 2018, 6:11 a.m
ems like just a
matter of time until someone else is running into the same trap.
Maybe it would be possible to add some validation for test names instead,
either as a linter rule or a runtime check?
- Benno
---
This i
we don't need
> > to disable the test? You could even set an arbitrary header which is not
> > interpreted by libprocess.
>
> Benno Evers wrote:
> The endpoints themselves will ignore all headers, so the idea of this
> test was to verify that libprocess can s
e, when it becomes possible to enable it.
- Benno
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69064/#review211377
---
On Dec. 18
: https://reviews.apache.org/r/69422/diff/3/
Changes: https://reviews.apache.org/r/69422/diff/2-3/
Testing
---
Thanks,
Benno Evers
7a4904a3d67479267087fd2313a263d8218843fa
src/tests/master_load_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/69064/diff/5/
Changes: https://reviews.apache.org/r/69064/diff/4-5/
Testing
---
Thanks,
Benno Evers
---
Thanks,
Benno Evers
/
Testing
---
Thanks,
Benno Evers
/tests/environment.cpp 03f8f5971b1e91e62ecfbf965028e6f2388d2a7b
Diff: https://reviews.apache.org/r/69584/diff/1/
Testing
---
Thanks,
Benno Evers
8895374499dc6baa2c4d8a8dd86fddac4e39be29
Diff: https://reviews.apache.org/r/69071/diff/3/
Testing
---
Thanks,
Benno Evers
operation feedback when agent is marked as gone.
Diffs
-
src/master/master.cpp b4b02d8b4d7d6d1aabda1f97b9bf824419f76a9e
src/tests/api_tests.cpp fdd9f871f75617fc26a28679e2a1e41f506c6133
Diff: https://reviews.apache.org/r/69575/diff/1/
Testing
---
Thanks,
Benno Evers
31501 0
FLAG=SSL,label=mesos-ec2-ubuntu-14.04 19 min 32620 0
FLAG=Plain,label=mesos-ec2-centos-7 20 min 31970 0
FLAG=SSL,label=mesos-ec2-centos-6 16 min 31720 0
```
Thanks,
Benno Evers
ture` is ready? Should we call `settle()` for each
> > of these containers?
>
> Benno Evers wrote:
> At this point we know from the `foreach`-loop above that all
> `Future`s are ready, so all calls to `defer()` in
> `composing.cpp` should have already happened. So I think
hat turned out
to be necessary.
I still didn't use the new metric, due to this part:
Future pendingHttpCalls;
do {
pendingHttpCalls = authorizer.pending();
AWAIT_READY(pendingHttpCalls);
} while (pendingHttpCalls.get() < 50u);
still ultimately bein
,
Benno Evers
apache.org/r/69422/diff/2/
Changes: https://reviews.apache.org/r/69422/diff/1-2/
Testing
---
Thanks,
Benno Evers
.
Diffs (updated)
-
src/Makefile.am 35500516e18ff251357b9e8d6bba894c44a9253b
src/tests/master_load_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/69064/diff/4/
Changes: https://reviews.apache.org/r/69064/diff/3-4/
Testing
---
Thanks,
Benno Evers
.
Diffs (updated)
-
src/master/master.hpp c7becfa615964674dcf1ebd9424aa5818a0fdb85
src/tests/cluster.hpp ad2b80e658d2f8afcefe9969d62cd33f0c475ce9
Diff: https://reviews.apache.org/r/69421/diff/2/
Changes: https://reviews.apache.org/r/69421/diff/1-2/
Testing
---
Thanks,
Benno
get nothing).
Added a comment in the header, in the hope that it's most visible there.
- Benno
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68795/#review210960
--
.
Diffs (updated)
-
src/master/http.cpp 68ee2a6dcffbc772afec6e797b1af8da48f61937
src/master/master.hpp c7becfa615964674dcf1ebd9424aa5818a0fdb85
Diff: https://reviews.apache.org/r/68795/diff/4/
Changes: https://reviews.apache.org/r/68795/diff/3-4/
Testing
---
Thanks,
Benno Evers
/master/readonly_handler.cpp 8895374499dc6baa2c4d8a8dd86fddac4e39be29
Diff: https://reviews.apache.org/r/69071/diff/3/
Changes: https://reviews.apache.org/r/69071/diff/2-3/
Testing
---
Thanks,
Benno Evers
0
FLAG=Plain,label=mesos-ec2-centos-7 20 min 31980 0
FLAG=SSL,label=mesos-ec2-centos-6 16 min 31730 0
```
Thanks,
Benno Evers
/slave_recovery_tests.cpp 5ee64a400
src/tests/slave_tests.cpp 1e918712d
src/tests/storage_local_resource_provider_tests.cpp 422a15204
src/tests/utils.hpp b2f22cd4d
src/tests/utils.cpp 06d3d6214
Diff: https://reviews.apache.org/r/69551/diff/1/
Testing
---
(todo)
Thanks,
Benno Evers
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69473/#review211187
---
Ship it!
Ship It!
- Benno Evers
On Dec. 11, 2018, 1:20 a.m
Lines 1001 (patched)
<https://reviews.apache.org/r/69474/#comment296070>
That's a pretty cool technique!
src/tests/executor_http_api_tests.cpp
Lines 1232 (patched)
<https://reviews.apache.org/r/69474/#comment296071>
Let's please fix this `TODO` before committing.
o the `UNREACHABLE` and kill the agent?
- Benno Evers
On Dec. 7, 2018, 10:17 p.m., Joseph Wu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, vi
without information loss, but
this is purely subjective so feel free to keep the current name if you prefer.
- Benno Evers
On Dec. 6, 2018, 2:21 a.m., Joseph Wu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69463/#review211140
---
Ship it!
Ship It!
- Benno Evers
On Dec. 6, 2018, 12:15 a.m
e is only asserted in a comment in
`master.hpp` but nowhere in libprocess itself.
- Benno Evers
On Dec. 6, 2018, 1:23 a.m., Joseph Wu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69307/#review211138
---
Ship it!
Ship It!
- Benno Evers
On Dec. 5, 2018, 10:01 p.m
nit test.
In the latter case, it seems like this some missing API in Mesos (i.e. an
`UNSUBSCRIBE` call), since intuitively this is something that *should* be easy
to do from the clients perspective.
- Benno Evers
On Nov. 26, 2018, 11:40 p.m., Joseph Wu wrote:
>
> -
/master.proto 80bd7c43cbb6d7df0dbd1c162cf4dda48f0e2e30
include/mesos/v1/master/master.proto cd41a7e8dc98753b5d2b8f93d92114fe97463636
Diff: https://reviews.apache.org/r/69447/diff/1/
Testing
---
Thanks,
Benno Evers
inner handler classes, and a raw pointer member
in a non-inner class, so I opted for this version instead.
It's not a strong preference though, so I'd be happy to merge the linked
alternative into this review as well.
- Benno Evers
On Nov. 22, 201
tps://reviews.apache.org/r/69064/#comment295652>
I'm not 100% happy about this part, but I also couldn't think of a better
way to generate the references. Any ideas/comments?
- Benno Evers
On Nov. 22, 2018, 1:22 a.m., B
/master/readonly_handler.cpp 8895374499dc6baa2c4d8a8dd86fddac4e39be29
src/tests/master_load_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/69445/diff/1/
Testing
---
Thanks,
Benno Evers
e` while simulatenously
> running `stress-ng --random 64` on the same machine.
>
> (before the change, `SlaveTest.DefaultExecutorCommandInfo` would fail roughly
> once every 15000 runs without `stress-ng` and roughly once every 300 runs
> with `stress-ng`)
>
>
> Thanks,
>
> Benno Evers
>
>
latenously
running `stress-ng --random 64` on the same machine.
(before the change, `SlaveTest.DefaultExecutorCommandInfo` would fail roughly
once every 15000 runs without `stress-ng` and roughly once every 300 runs with
`stress-ng`)
Thanks,
Benno Evers
/master/readonly_handler.cpp 8895374499dc6baa2c4d8a8dd86fddac4e39be29
Diff: https://reviews.apache.org/r/69071/diff/2/
Changes: https://reviews.apache.org/r/69071/diff/1-2/
Testing
---
Thanks,
Benno Evers
)
-
src/Makefile.am 8da1a05b618f17542fec9b5057484a9bae57658a
src/tests/master_load_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/69064/diff/3/
Changes: https://reviews.apache.org/r/69064/diff/2-3/
Testing
---
Thanks,
Benno Evers
r/http.cpp 68ee2a6dcffbc772afec6e797b1af8da48f61937
src/master/metrics.hpp f6bb89da9394bfe469bc690ff2de66824e994098
src/master/metrics.cpp f69ed52c1c89912e7a5d26cb9409f5959b09111a
Diff: https://reviews.apache.org/r/69422/diff/1/
Testing
---
Thanks,
Benno Evers
src/tests/cluster.hpp ad2b80e658d2f8afcefe9969d62cd33f0c475ce9
Diff: https://reviews.apache.org/r/69421/diff/1/
Testing
---
Thanks,
Benno Evers
b0
Diff: https://reviews.apache.org/r/69411/diff/2/
Changes: https://reviews.apache.org/r/69411/diff/1-2/
Testing
---
Thanks,
Benno Evers
windows.
Diffs (updated)
-
src/master/http.cpp 68ee2a6dcffbc772afec6e797b1af8da48f61937
src/master/master.hpp 3b3c1a4e61de9503c8d038dd3bee623ded5914c9
Diff: https://reviews.apache.org/r/68795/diff/3/
Changes: https://reviews.apache.org/r/68795/diff/2-3/
Testing
---
Thanks,
Benno
tps://reviews.apache.org/r/69411/#comment295527>
Note: One could also think about declaring this as
operator Try>() &&;
and have to functions above return a `MasterBuilder&&`, but I wasn't sure
if the additional strictness outweighs the increased complexity
better known as "fluent interface".
Diffs
-
src/tests/cluster.hpp ad2b80e658d2f8afcefe9969d62cd33f0c475ce9
src/tests/cluster.cpp 2b351ca70d8e80008e49722aa7d46918b5ecd9b0
Diff: https://reviews.apache.org/r/69411/diff/1/
Testing
---
Thanks,
Benno Evers
> On Nov. 6, 2018, 12:19 p.m., Benno Evers wrote:
> > src/tests/master_benchmarks.cpp
> > Lines 616 (patched)
> > <https://reviews.apache.org/r/68131/diff/3-4/?file=2070789#file2070789line620>
> >
> > Last time we tried running this benchmark, we di
> On Nov. 13, 2018, 10:48 a.m., Benno Evers wrote:
> > src/tests/CMakeLists.txt
> > Lines 365 (patched)
> > <https://reviews.apache.org/r/69311/diff/1/?file=2106803#file2106803line365>
> >
> > Does this preserve user-specified `MESOS_GTEST_RUNNER_FLAGS
tps://reviews.apache.org/r/69273/#comment295260>
We still need this to circumvent another delay at
https://github.com/apache/mesos/blob/3446e0a43eb16151d0f467e7034b0ca6baefda4a/src/slave/slave.cpp#L1306-L1311
- Benno Evers
On Nov. 14, 2018, 3:23 p.m., Benno Evers
="*ReconfigurationWithRunning*"
--gtest_repeat=500`
Thanks,
Benno Evers
that the table is still rendered
correctly:
https://github.com/lava/mesos/blob/03aa8e0eb3131fb8272201b82ee16da99df08274/3rdparty/libprocess/README.md
Thanks,
Benno Evers
ip It': it was
intended to come with the caveat that you are still going to do a test run with
the `Make` backend as well.
- Benno Evers
On Nov. 11, 2018, 12:01 a.m., Benjamin Bannier wrote:
>
> ---
> This is an automatical
ove is correct CMake syntax, but you get the idea)
Of course, if CMake already does the correct thing anyways, disregard this
issue.
- Benno Evers
On Nov. 11, 2018, 12:01 a.m., Benjamin Bannier wrote:
>
> ---
> This is an
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69312/#review210502
---
Ship it!
Ship It!
- Benno Evers
On Nov. 11, 2018, 12:01 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69313/#review210503
---
Ship it!
Ship It!
- Benno Evers
On Nov. 11, 2018, 12:01 a.m
low
I've added a TODO for now to capture this.
- Benno
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69273/#review210383
-------
On Nov. 12, 2018, 2:33 p.m., Benno Evers wrote:
>
>
mesos-tests --gtest_filter="*ReconfigurationWithRunning*"
--gtest_repeat=200`
Thanks,
Benno Evers
301 - 400 of 874 matches
Mail list logo
