Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

2016-07-19 Thread Shuai Lin
e3c8daab4fc688150a4f222e05f9b1bd9aee1912 src/tests/containerizer/provisioner_docker_tests.cpp ffe3382da8b1199e257a72ca9034fbccec9494b1 Diff: https://reviews.apache.org/r/47095/diff/ Testing --- "make check" on ubuntu 14.04 64bit with gcc 4.8.4 Thanks, Shuai Lin

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

2016-07-13 Thread Shuai Lin
/mesos_containerizer_tests.cpp e3c8daab4fc688150a4f222e05f9b1bd9aee1912 src/tests/containerizer/provisioner_docker_tests.cpp ffe3382da8b1199e257a72ca9034fbccec9494b1 Diff: https://reviews.apache.org/r/47095/diff/ Testing --- "make check" on ubuntu 14.04 64bit with gcc 4.8.4 Thanks, Shuai Lin

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

2016-07-13 Thread Shuai Lin
-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47095/#review142061 --- On May 14, 2016, 4:30 p.m., Shuai Lin wrote: > >

Re: Review Request 48927: Implemented DESTROY_VOLUMES Call in v1 master API.

2016-06-22 Thread Shuai Lin
/master.hpp fe57878dc59637459d5c5cdae0be2aa159133fa4 Diff: https://reviews.apache.org/r/48927/diff/ Testing --- Please check https://reviews.apache.org/r/48938/ , which adds the test case for both create/destroy volumes api. Thanks, Shuai Lin

Re: Review Request 48938: Added test case `MasterAPITest.CreateAndDetroyVolumes`.

2016-06-22 Thread Shuai Lin
/internal/evolve.cpp 6b1cf3c4b69d0c39fca6d3bc8482b599494c4805 src/tests/api_tests.cpp bf1a294f1fc3c8659c31115beee3876d4d0a45e2 Diff: https://reviews.apache.org/r/48938/diff/ Testing --- "make check" on ubuntu 14.04 64bit with gcc. Thanks, Shuai Lin

Re: Review Request 48926: Implemented CREATE_VOLUMES Call in v1 master API.

2016-06-22 Thread Shuai Lin
/master.hpp fe57878dc59637459d5c5cdae0be2aa159133fa4 Diff: https://reviews.apache.org/r/48926/diff/ Testing --- Please check https://reviews.apache.org/r/48938/ , which adds the test case for both create/destroy volumes api. Thanks, Shuai Lin

Re: Review Request 48926: Implemented CREATE_VOLUMES Call in v1 master API.

2016-06-21 Thread Shuai Lin
/master.hpp 98fb1fa3adab4dad5de156bf83a6c074eb2ffc64 Diff: https://reviews.apache.org/r/48926/diff/ Testing --- Please check https://reviews.apache.org/r/48938/ , which adds the test case for both create/destroy volumes api. Thanks, Shuai Lin

Re: Review Request 48927: Implemented DESTROY_VOLUMES Call in v1 master API.

2016-06-21 Thread Shuai Lin
/master.hpp 98fb1fa3adab4dad5de156bf83a6c074eb2ffc64 Diff: https://reviews.apache.org/r/48927/diff/ Testing --- Please check https://reviews.apache.org/r/48938/ , which adds the test case for both create/destroy volumes api. Thanks, Shuai Lin

Re: Review Request 48938: Added test case `MasterAPITest.CreateAndDetroyVolumes`.

2016-06-21 Thread Shuai Lin
/internal/evolve.cpp 6b1cf3c4b69d0c39fca6d3bc8482b599494c4805 src/tests/api_tests.cpp 8bc05432c758f8997bc89db1ff772c6910f0883c Diff: https://reviews.apache.org/r/48938/diff/ Testing --- "make check" on ubuntu 14.04 64bit with gcc. Thanks, Shuai Lin

Re: Review Request 48938: Added test case `MasterAPITest.CreateAndDetroyVolumes`.

2016-06-21 Thread Shuai Lin
7ce62d92a87f4885d8c4faab542c49d5bfb251d3 src/internal/evolve.cpp 67c550342c06acdfcd0ed5cbe860ad29e41e6846 src/tests/api_tests.cpp 5d10533858cf1c512e00dbe6d5fab1f6401687bf Diff: https://reviews.apache.org/r/48938/diff/ Testing --- "make check" on ubuntu 14.04 64bit with gcc. Thanks, Shuai Lin

Re: Review Request 48927: Implemented DESTROY_VOLUMES Call in v1 master API.

2016-06-21 Thread Shuai Lin
148324e2c9d52f8211df4cead783e5a2979a45fe src/master/master.hpp 50230397dcf52219fd4ed98dd1107bf53790478d Diff: https://reviews.apache.org/r/48927/diff/ Testing --- Please check https://reviews.apache.org/r/48938/ , which adds the test case for both create/destroy volumes api. Thanks, Shuai Lin

Re: Review Request 48938: Added test case `MasterAPITest.CreateAndDetroyVolumes`.

2016-06-21 Thread Shuai Lin
------ On June 20, 2016, 1:54 a.m., Shuai Lin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48938/ > ---

Re: Review Request 48927: Implemented DESTROY_VOLUMES Call in v1 master API.

2016-06-21 Thread Shuai Lin
ter::Http::_destroyVolumes( > > ``` Good catch! - Shuai --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48927/#review138639 -------

Re: Review Request 48927: Implemented DESTROY_VOLUMES Call in v1 master API.

2016-06-19 Thread Shuai Lin
50230397dcf52219fd4ed98dd1107bf53790478d Diff: https://reviews.apache.org/r/48927/diff/ Testing (updated) --- Please check https://reviews.apache.org/r/48938/ , which adds the test case for both create/destroy volumes api. Thanks, Shuai Lin

Re: Review Request 48926: Implemented CREATE_VOLUMES Call in v1 master API.

2016-06-19 Thread Shuai Lin
50230397dcf52219fd4ed98dd1107bf53790478d Diff: https://reviews.apache.org/r/48926/diff/ Testing (updated) --- Please check https://reviews.apache.org/r/48938/ , which adds the test case for both create/destroy volumes api. Thanks, Shuai Lin

Re: Review Request 48927: Implemented DESTROY_VOLUMES Call in v1 master API.

2016-06-19 Thread Shuai Lin
50230397dcf52219fd4ed98dd1107bf53790478d Diff: https://reviews.apache.org/r/48927/diff/ Testing --- Would follow up with a test case for both create/destroy volumes api soon. Thanks, Shuai Lin

Review Request 48938: Added test case `MasterAPITest.CreateAndDetroyVolumes`.

2016-06-19 Thread Shuai Lin
/api_tests.cpp 5d10533858cf1c512e00dbe6d5fab1f6401687bf Diff: https://reviews.apache.org/r/48938/diff/ Testing --- "make check" on ubuntu 14.04 64bit with gcc. Thanks, Shuai Lin

Re: Review Request 48926: Implemented CREATE_VOLUMES Call in v1 master API.

2016-06-19 Thread Shuai Lin
50230397dcf52219fd4ed98dd1107bf53790478d Diff: https://reviews.apache.org/r/48926/diff/ Testing --- Would follow up with a test case for both create/destroy volumes api soon. Thanks, Shuai Lin

Re: Review Request 48927: Implemented DESTROY_VOLUMES Call in v1 master API.

2016-06-19 Thread Shuai Lin
50230397dcf52219fd4ed98dd1107bf53790478d Diff: https://reviews.apache.org/r/48927/diff/ Testing --- Would follow up with a test case for both create/destroy volumes api soon. Thanks, Shuai Lin

Review Request 48927: Implemented DESTROY_VOLUMES Call in v1 master API.

2016-06-19 Thread Shuai Lin
for both create/destroy volumes api soon. Thanks, Shuai Lin

Review Request 48926: Implemented CREATE_VOLUMES Call in v1 master API.

2016-06-19 Thread Shuai Lin
://reviews.apache.org/r/48926/diff/ Testing --- Would follow up with a test case for both create/destroy volumes api soon. Thanks, Shuai Lin

Re: Review Request 48773: Added docs on aufs provisioning backend.

2016-06-19 Thread Shuai Lin
src/slave/flags.cpp 69828ae43c2e5432aaa27cae3dc683cd90f10db9 Diff: https://reviews.apache.org/r/48773/diff/ Testing --- Thanks, Shuai Lin

Re: Review Request 48773: Added docs on aufs provisioning backend.

2016-06-19 Thread Shuai Lin
ibution do not support AUFS instead of > > "some Linux distributions"? The same as above. - Shuai --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48773/#review137925 ----

Review Request 48773: Added docs on aufs provisioning backend.

2016-06-15 Thread Shuai Lin
://reviews.apache.org/r/48773/diff/ Testing --- Thanks, Shuai Lin

Re: Review Request 48388: Fixed compilation on OS X of aufs tests.

2016-06-08 Thread Shuai Lin
it > > could be very simple. > > Shuai Lin wrote: > Thanks for the tip. Do you mean i should create a first patch that keeps > aufs test where it is and adds the `__linux__` guards around it, and then do > the reording in the second patch? > > That surely

Re: Review Request 48388: Fixed compilation on OS X of aufs tests.

2016-06-08 Thread Shuai Lin
e.org/r/48388/#review136674 --- On June 8, 2016, 2:34 a.m., Shuai Lin wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Re: Review Request 48388: Fixed compilation on OS X of aufs tests.

2016-06-07 Thread Shuai Lin
f18cc3f72afbefa8b4b90e77deff0874808c648a Diff: https://reviews.apache.org/r/48388/diff/ Testing (updated) --- make check on both ubuntu 14.04 & mac osx Thanks, Shuai Lin

Review Request 48388: Fixed compilation on OS X of aufs tests.

2016-06-07 Thread Shuai Lin
/browse/MESOS-4672 Repository: mesos Description --- Fixed compilation on OS X of aufs tests. Diffs - src/tests/containerizer/provisioner_backend_tests.cpp f18cc3f72afbefa8b4b90e77deff0874808c648a Diff: https://reviews.apache.org/r/48388/diff/ Testing --- Thanks, Shuai

Re: Review Request 47396: Added aufs provisioning backend.

2016-06-06 Thread Shuai Lin
aufs backend, and write a simple script that launches tasks with alpine/ubuntu images Thanks, Shuai Lin

Re: Review Request 48300: Added fs::aufs::supported() function.

2016-06-06 Thread Shuai Lin
: https://reviews.apache.org/r/48300/diff/ Testing --- make check on ubuntu 14.04 Thanks, Shuai Lin

Review Request 48300: Added fs::aufs::supported() function.

2016-06-06 Thread Shuai Lin
/ Testing --- make check on ubuntu 14.04 Thanks, Shuai Lin

Re: Review Request 47396: Added aufs provisioning backend.

2016-06-06 Thread Shuai Lin
://reviews.apache.org/r/47396/diff/ Testing --- - Make check on ubuntu 14.04 64bit - Test manually: start slave with aufs backend, and write a simple script that launches tasks with alpine/ubuntu images Thanks, Shuai Lin

Re: Review Request 47608: Add Labels from TaskInfo into TaskStatus message.

2016-05-25 Thread Shuai Lin
g/r/47608/#comment199688> Should we also search in in `termiantedTasks`? ```cpp // Terminated but pending updates. LinkedHashMap terminatedTasks; ``` - Shuai Lin On May 20, 2016, 6:38 p.m., Srinivas Brahmaroutu

Re: Review Request 47608: Add Labels from TaskInfo into TaskStatus message.

2016-05-25 Thread Shuai Lin
framework. For example, when a slave is lost, the master would send `TASK_LOST` to frameworks for all tasks running on that slave. https://github.com/apache/mesos/blob/0.28.1/src/master/master.cpp#L6194-L6229 Should we also add the labels to the stauts update message there? - Shuai Lin On May 20

Re: Review Request 47396: Added aufs provisioning backend.

2016-05-15 Thread Shuai Lin
- Test manually: start slave with aufs backend, and write a simple script that launches tasks with alpine/ubuntu images Thanks, Shuai Lin

Review Request 47396: Added aufs provisioning backend.

2016-05-15 Thread Shuai Lin
, and write a simple script that launches tasks with alpine/ubuntu images Thanks, Shuai Lin

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

2016-05-14 Thread Shuai Lin
file. To do that we need a shell :) - Shuai ------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47095/#review133273

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

2016-05-14 Thread Shuai Lin
rizer/mesos_containerizer_tests.cpp 09742ff21513dc2570684d384b257868dd57a9ce src/tests/containerizer/provisioner_docker_tests.cpp 69505c922617273effc2eb52b0c567a3c01bf640 Diff: https://reviews.apache.org/r/47095/diff/ Testing --- "make check" on ubuntu 14.04 64bit with gcc 4.8.4 Thanks, Shuai Lin

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

2016-05-14 Thread Shuai Lin
/mesos_containerizer_tests.cpp 09742ff21513dc2570684d384b257868dd57a9ce src/tests/containerizer/provisioner_docker_tests.cpp 69505c922617273effc2eb52b0c567a3c01bf640 Diff: https://reviews.apache.org/r/47095/diff/ Testing --- "make check" on ubuntu 14.04 64bit with gcc 4.8.4 Thanks, Shuai Lin

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

2016-05-11 Thread Shuai Lin
> https://reviews.apache.org/r/44985/ and > > https://issues.apache.org/jira/browse/MESOS-4810 > > Shuai Lin wrote: > It's a bit awkward to use redirection if I use shell=false for the > `CommandInfo`, so I change `echo -n ...` to `/bin/echo -n ...`, hopefully it &

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

2016-05-11 Thread Shuai Lin
/mesos_containerizer_tests.cpp 09742ff21513dc2570684d384b257868dd57a9ce src/tests/containerizer/provisioner_docker_tests.cpp 69505c922617273effc2eb52b0c567a3c01bf640 Diff: https://reviews.apache.org/r/47095/diff/ Testing --- "make check" on ubuntu 14.04 64bit with gcc 4.8.4 Thanks, Shuai Lin

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

2016-05-11 Thread Shuai Lin
- Shuai --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47095/#review132207 --- On May 9, 2016, 3:51 a.m., Shuai Lin wrote

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

2016-05-11 Thread Shuai Lin
d work. Can you give it a try on centos? - Shuai --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47095/#review132393 ----------

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

2016-05-11 Thread Shuai Lin
sSandboxEnv`, since that's what's being tested. - Shuai --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47095/#review132207 -------

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

2016-05-08 Thread Shuai Lin
rizer/mesos_containerizer_tests.cpp 09742ff21513dc2570684d384b257868dd57a9ce src/tests/containerizer/provisioner_docker_tests.cpp 69505c922617273effc2eb52b0c567a3c01bf640 Diff: https://reviews.apache.org/r/47095/diff/ Testing --- "make check" on ubuntu 14.04 64bit with gcc 4.8.4 Thanks, Shuai Lin

Re: Review Request 46873: Fixed MESOS_SANDBOX env in unified containerizer.

2016-05-08 Thread Shuai Lin
> On May 3, 2016, 5:03 a.m., Jie Yu wrote: > > Can you follow up with a test (e.g., in provisioner_docker_tests.cpp) for > > this? > > Shuai Lin wrote: > Sure, would do that this week. https://reviews.apache.org/r/47095/ , Pleas

Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

2016-05-08 Thread Shuai Lin
/provisioner_docker_tests.cpp 69505c922617273effc2eb52b0c567a3c01bf640 Diff: https://reviews.apache.org/r/47095/diff/ Testing --- "make check" on ubuntu 14.04 64bit with gcc 4.8.4 Thanks, Shuai Lin

Re: Review Request 46873: Fixed MESOS_SANDBOX env in unified containerizer.

2016-05-02 Thread Shuai Lin
To reply, visit: https://reviews.apache.org/r/46873/#review131456 --- On May 2, 2016, 3:04 p.m., Shuai Lin wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 46873: Fixed MESOS_SANDBOX env in unified containerizer.

2016-05-02 Thread Shuai Lin
it: https://reviews.apache.org/r/46873/#review131282 --- On May 2, 2016, 3:04 p.m., Shuai Lin wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 46873: Fixed MESOS_SANDBOX env in unified containerizer.

2016-05-02 Thread Shuai Lin
/ Testing --- make check (ubuntu14.04 + gcc 4.8.4) Thanks, Shuai Lin

Re: Review Request 46873: Fixed MESOS_SANDBOX env in unified containerizer.

2016-05-01 Thread Shuai Lin
> > > > BTW: Can you please make your patch depend on > > https://reviews.apache.org/r/46807 > > Shuai Lin wrote: > Thanks, I just added 46807 as a dependency of this one. > > - IIRC `ContainerInfo.NetworkInfo` only works for docker containerzier

Re: Review Request 46873: Fixed MESOS_SANDBOX env in unified containerizer.

2016-05-01 Thread Shuai Lin
> > > > BTW: Can you please make your patch depend on > > https://reviews.apache.org/r/46807 > > Shuai Lin wrote: > Thanks, I just added 46807 as a dependency of this one. > > - IIRC `ContainerInfo.NetworkInfo` only works for docker containerzier

Re: Review Request 46873: Fixed MESOS_SANDBOX env in unified containerizer.

2016-05-01 Thread Shuai Lin
check (ubuntu14.04 + gcc 4.8.4) Thanks, Shuai Lin

Re: Review Request 46873: Fixed MESOS_SANDBOX env in unified containerizer.

2016-05-01 Thread Shuai Lin
+ gcc 4.8.4) Thanks, Shuai Lin

Re: Review Request 46873: Fixed MESOS_SANDBOX env in unified containerizer.

2016-05-01 Thread Shuai Lin
containerizer - Can a task have volumes when it doesn't have a rootfs? - Shuai --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46873/#review131260 ----------

Re: Review Request 46873: Fixed MESOS_SANDBOX env in unified containerizer.

2016-05-01 Thread Shuai Lin
) Thanks, Shuai Lin

Review Request 46873: Fixed MESOS_SANDBOX env in unified containerizer.

2016-04-30 Thread Shuai Lin
MESOS_SANDBOX env in unified containerizer. Diffs - src/slave/containerizer/mesos/containerizer.cpp 8d538954d6e1f13e833d75c2eaa37e700278ee0c Diff: https://reviews.apache.org/r/46873/diff/ Testing --- Thanks, Shuai Lin

Re: Review Request 42806: Added the fetcher plugin module interface.

2016-04-22 Thread Shuai Lin
8af2c9122e0b15fd54f7d3a84779540e7186f566 src/uri/fetcher.cpp aa9df5d0256a26b8684934c2bd37b82a069088f7 Diff: https://reviews.apache.org/r/42806/diff/ Testing --- make check Thanks, Shuai Lin

Re: Review Request 45358: Improved overlay backend to make the rootfs writable.

2016-04-11 Thread Shuai Lin
lly with alpine image to verify overlay backend could support 1-layer images. Thanks, Shuai Lin

Re: Review Request 45358: Improved overlay backend to make the rootfs writable.

2016-04-11 Thread Shuai Lin
ated e-mail. To reply, visit: https://reviews.apache.org/r/45358/#review128033 ------- On April 10, 2016, 8:09 a.m., Shuai Lin wrote: > > --- > This is a

Re: Review Request 45358: Improved overlay backend to make the rootfs writable.

2016-04-10 Thread Shuai Lin
- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45358/#review127696 ------- On April 10, 2016, 8:09 a.m., Shuai Lin wrote: > > -

Re: Review Request 45358: Improved overlay backend to make the rootfs writable.

2016-04-10 Thread Shuai Lin
overlay backend could support 1-layer images. Thanks, Shuai Lin

Re: Review Request 43321: Speeded up SchedulerTest.Decline by advancing the clock.

2016-04-09 Thread Shuai Lin
[ RUN ] ContentType/SchedulerTest.Decline/1 [ OK ] ContentType/SchedulerTest.Decline/1 (98 ms) ``` Repeatedly tested with: ```sh ./bin/mesos-tests.sh --gtest_filter=ContentType/SchedulerTest.Decline/* --gtest_repeat=1000 --gtest_break_on_failure ``` Thanks, Shuai Lin

Re: Review Request 43524: Speeded up RecoverTest.AutoInitialization by advacing the clock.

2016-04-08 Thread Shuai Lin
on (630 ms) [--] 1 test from RecoverTest (631 ms total) ``` Repeatly tested with: ``` ./bin/mesos-tests.sh --gtest_filter=RecoverTest.AutoInitialization --gtest_repeat=1000 --gtest_break_on_failure' ``` Thanks, Shuai Lin

Re: Review Request 43524: Speeded up RecoverTest.AutoInitialization by advacing the clock.

2016-04-08 Thread Shuai Lin
on (630 ms) [--] 1 test from RecoverTest (631 ms total) ``` Repeatly tested with: ``` ./bin/mesos-tests.sh --gtest_filter=RecoverTest.AutoInitialization --gtest_repeat=1000 --gtest_break_on_failure' ``` Thanks, Shuai Lin

Re: Review Request 43329: Speeded up MasterAllocatorTest.SlaveLost test.

2016-04-08 Thread Shuai Lin
OK ] MasterAllocatorTest/1.SlaveLost (120 ms) [--] 1 test from MasterAllocatorTest/1 (120 ms total) ``` Tested repeatedly with: ``` ./bin/mesos-tests.sh --gtest_filter=MasterAllocatorTest*.SlaveLost --gtest_repeat=1000 --gtest_break_on_failure' ``` Thanks, Shuai Lin

Re: Review Request 45083: Added ANY mode to futures collect mechanism.

2016-04-07 Thread Shuai Lin
> On April 8, 2016, 6:41 a.m., Shuai Lin wrote: > > 3rdparty/libprocess/include/process/collect.hpp, line 217 > > <https://reviews.apache.org/r/45083/diff/8/?file=1329609#file1329609line217> > > > > Got a compile error here: > > > >

Re: Review Request 45083: Added ANY mode to futures collect mechanism.

2016-04-07 Thread Shuai Lin
argument value in line 216 it compiles ok. - Shuai Lin On April 7, 2016, 10:36 a.m., haosdent huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://

Re: Review Request 45358: Improved overlay backend to make the rootfs writable.

2016-04-06 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45358/#review127315 --- @jieyu updated according to your suggestions. - Shuai Lin On

Re: Review Request 45358: Improved overlay backend to make the rootfs writable.

2016-04-06 Thread Shuai Lin
r images. Thanks, Shuai Lin

Re: Review Request 45358: Improved overlay backend to make the rootfs writable.

2016-04-06 Thread Shuai Lin
-- On April 6, 2016, 12:05 p.m., Shuai Lin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45358/ > -

Re: Review Request 45358: Improved overlay backend to make the rootfs writable.

2016-04-06 Thread Shuai Lin
lly with alpine image to verify overlay backend could support 1-layer images. Thanks, Shuai Lin

Re: Review Request 45358: Improved overlay backend to make the rootfs writable.

2016-03-27 Thread Shuai Lin
o tested manually with alpine image to verify overlay backend could support 1-layer images. Thanks, Shuai Lin

Re: Review Request 45358: Improved overlay backend to make the rootfs writable.

2016-03-27 Thread Shuai Lin
nd could support 1-layer images. Thanks, Shuai Lin

Re: Review Request 45358: Improved overlay backend to make the rootfs writable.

2016-03-27 Thread Shuai Lin
ch /abc/def.txt`. Thanks, Shuai Lin

Review Request 45358: Improved overlay backend to make the rootfs writable.

2016-03-27 Thread Shuai Lin
d49204f220c6212f83c2adf5544d04b3386c8eb7 Diff: https://reviews.apache.org/r/45358/diff/ Testing --- - make check - tested manually, with slave using overlay backend. Create a task with mesos containerizer, ubuntu docker image, with the command `mkdir -p /abc && touch /abc/def.txt`. Thanks

Re: Review Request 44435: Fixed a bug that causes the task stuck in staging state.

2016-03-19 Thread Shuai Lin
t;` - make check Thanks, Shuai Lin

Re: Review Request 44672: Added normalize method to registry puller.

2016-03-18 Thread Shuai Lin
/registry_puller.cpp (line 182) <https://reviews.apache.org/r/44672/#comment186898> I would suggest to add a new test for the `normalize` function. - Shuai Lin On March 14, 2016, 5:32 p.m., Gilbert Song wrote: > > --- > This is a

Re: Review Request 44435: Fixed a bug that causes the task stuck in staging state.

2016-03-18 Thread Shuai Lin
/containerizer/mesos_containerizer_tests.cpp e849932ab558ccd792080433169ae50dc208a12e Diff: https://reviews.apache.org/r/44435/diff/ Testing --- - Added a new test `"MesosContainerizerProvisionerTest.ProvisionFailed"` - make check Thanks, Shuai Lin

Re: Review Request 42806: Added the fetcher plugin module interface.

2016-03-13 Thread Shuai Lin
src/uri/fetcher.hpp 8af2c9122e0b15fd54f7d3a84779540e7186f566 src/uri/fetcher.cpp 8645b66f6c64c76b6c02ef0b9827a7d694d5ba97 Diff: https://reviews.apache.org/r/42806/diff/ Testing --- make check Thanks, Shuai Lin

Review Request 44435: Fixed a bug that causes the task stuck in staging state.

2016-03-06 Thread Shuai Lin
15f0f93d2e5c19a22f6cc4a71a7d94be4aaec2c1 Diff: https://reviews.apache.org/r/44435/diff/ Testing --- - Added a new test `"MesosContainerizerProvisionerTest.ProvisionFailed"` - make check Thanks, Shuai Lin

Re: Review Request 43321: Speeded up SchedulerTest.Decline by advancing the clock.

2016-02-28 Thread Shuai Lin
OK ] ContentType/SchedulerTest.Decline/1 (98 ms) ``` Thanks, Shuai Lin

Re: Review Request 43932: Added overlayfs provisioning backend.

2016-02-28 Thread Shuai Lin
e same thing to mark the mount as slave+shared > > (like we did in the bind backend). > > > > So the goal of doing that is: we want to make sure when slave fork a > > subprocess with a new mount namespace, it does not create an extra > > reference to the mount s

Re: Review Request 43701: Added a command executor based on the new V1 API.

2016-02-28 Thread Shuai Lin
tps://reviews.apache.org/r/43701/#comment182810> Maybe we should also add some tests that launches tasks with this new http cmd executor? - Shuai Lin On Feb. 20, 2016, 1:44 p.m., Qian Zhang wrote: > > --- > This is an automatically gener

Re: Review Request 43718: Added fs::supported() function.

2016-02-28 Thread Shuai Lin
ould still be tried to see if the fs is supportted. > > > > But it would be good to log some WARNINIG message here before continue. > > > > @Jie Yu, @Shuai Lin, what do you say? > > Klaus Ma wrote: > According to the comments, only one or two columns is

Re: Review Request 43932: Added overlayfs provisioning backend.

2016-02-28 Thread Shuai Lin
GTEST_FILTER='OverlayBackendTest.ROOT_OVERLAYFS_OverlayFSBackend' - OS: ubuntu 14.04 64bit vm - Kernel: 4.2.0-27-generic Thanks, Shuai Lin

Re: Review Request 43932: Added overlayfs provisioning backend.

2016-02-28 Thread Shuai Lin
modprobe overlayfs sudo make check -j4 GTEST_FILTER='OverlayBackendTest.ROOT_OVERLAYFS_OverlayFSBackend' - OS: ubuntu 14.04 64bit vm - Kernel: 4.2.0-27-generic Thanks, Shuai Lin

Re: Review Request 43932: Added overlayfs provisioning backend.

2016-02-28 Thread Shuai Lin
Shuai ------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43932/#review120750 --- On Feb. 24, 2016, 4:38 p.m., Shuai Lin wrote: >

Re: Review Request 43718: Added fs::supported() function.

2016-02-28 Thread Shuai Lin
/containerizer/fs_tests.cpp 29e43877612fa151e6f6d79268a7411272a7bfeb Diff: https://reviews.apache.org/r/43718/diff/ Testing --- make check on ubuntu 14.04 64bit vm Thanks, Shuai Lin

Re: Review Request 42100: Updated the jenkins build script to copy out xml testing reports.

2016-02-28 Thread Shuai Lin
r_build.sh $ ls -1 *.xml libprocess-tests.xml lt-mesos-tests.xml stout-tests.xml ``` Thanks, Shuai Lin

Re: Review Request 43718: Added fs::supported() function.

2016-02-28 Thread Shuai Lin
6bf87a19a795cf0a1970f160829b477a35cb789a src/tests/containerizer/fs_tests.cpp 29e43877612fa151e6f6d79268a7411272a7bfeb Diff: https://reviews.apache.org/r/43718/diff/ Testing --- make check on ubuntu 14.04 64bit vm Thanks, Shuai Lin

Re: Review Request 43718: Added fs::supported() function.

2016-02-28 Thread Shuai Lin
--------- On Feb. 22, 2016, 2:10 a.m., Shuai Lin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43718/ > ---

Re: Review Request 43718: Added fs::supported() function.

2016-02-28 Thread Shuai Lin
-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43718/#review120747 --- On Feb. 22, 2016, 2:10 a.m., Shuai Lin wrote: > > ---

Re: Review Request 42100: Updated the jenkins build script to copy out xml testing reports.

2016-02-28 Thread Shuai Lin
*.xml libprocess-tests.xml mesos-tests.xml stout-tests.xml ``` Thanks, Shuai Lin

Re: Review Request 42100: Updated the jenkins build script to copy out xml testing reports.

2016-02-28 Thread Shuai Lin
libprocess-tests.xml mesos-tests.xml stout-tests.xml ``` Thanks, Shuai Lin

Re: Review Request 42100: Updated the jenkins build script to copy out xml testing reports.

2016-02-28 Thread Shuai Lin
GLOG_v=1 MESOS_VERBOSE=1 ./support/docker_build.sh ``` Thanks, Shuai Lin

Re: Review Request 43271: Modify subprocess to deal with LIBPROCESS_PORT specially.

2016-02-25 Thread Shuai Lin
tps://reviews.apache.org/r/43271/#comment182178> Nitpick: would the warning always be logged when forking mesos-fetcher? Because it would use a copy of `os::environment()`, and #43272 removes the logic that removes `LIBPROCESS_PORT` from it? - Shuai Lin On Feb. 19, 2016, 6:54 p.m., Joseph Wu

Re: Review Request 42100: Updated the jenkins build script to copy out xml testing reports.

2016-02-24 Thread Shuai Lin
/42100/diff/ Testing (updated) --- On ubuntu 14.04 64: ``` export OS=ubuntu:14.04 CONFIGURATION=--verbose COMPILER=gcc ENVIRONMENT=GLOG_v=1 MESOS_VERBOSE=1 ./support/docker_build.sh ``` Thanks, Shuai Lin

Review Request 43932: Added overlayfs provisioning backend.

2016-02-24 Thread Shuai Lin
='OverlayBackendTest.ROOT_OVERLAYFS_OverlayFSBackend' - OS: ubuntu 14.04 64bit vm - Kernel: 4.2.0-27-generic Thanks, Shuai Lin

Re: Review Request 43718: Added fs::supported() function.

2016-02-21 Thread Shuai Lin
36ef21c865595 src/linux/fs.cpp 0df194207a66bf4c417349bebcc8912acbf5976e src/tests/containerizer/fs_tests.cpp 29e43877612fa151e6f6d79268a7411272a7bfeb Diff: https://reviews.apache.org/r/43718/diff/ Testing --- make check on ubuntu 14.04 64bit vm Thanks, Shuai Lin

  1   2   >