Re: Review Request 46372: Fixed broken mesos.native package installation.

2016-04-21 Thread Steve Niemitz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46372/#review130017 --- Ship it! Ship It! - Steve Niemitz On April 22, 2016, 1:22

Re: Review Request 45398: Added CHANGELOG for python module changes.

2016-03-29 Thread Steve Niemitz
. Repository: mesos Description --- Added CHANGELOG for python module changes. Diffs (updated) - CHANGELOG 4c73a2638074ac9f11de1438a5dd3d70e8201229 Diff: https://reviews.apache.org/r/45398/diff/ Testing --- Thanks, Steve Niemitz

Re: Review Request 45398: Added CHANGELOG for python module changes.

2016-03-29 Thread Steve Niemitz
28> > > > > s/modules/modules,/ There shouldn't be a comma there, the way its written is correct. - Steve --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45398/#review125759

Review Request 45398: Added CHANGELOG for python module changes.

2016-03-28 Thread Steve Niemitz
--- Added CHANGELOG for python module changes. Diffs - CHANGELOG 4c73a2638074ac9f11de1438a5dd3d70e8201229 Diff: https://reviews.apache.org/r/45398/diff/ Testing --- Thanks, Steve Niemitz

Re: Review Request 41410: Export CFS metrics for docker containers

2016-03-28 Thread Steve Niemitz
://reviews.apache.org/r/41410/diff/ Testing --- Thanks, Steve Niemitz

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

2016-03-24 Thread Steve Niemitz
> On March 16, 2016, 11:08 p.m., Jie Yu wrote: > > This patch breaks all the ROOT DOCKER tests in our internal CI. I've > > reverted it for now. Can you do a sudo make check with docker? > > Steve Niemitz wrote: > ok, I see what the problem is here. The issue is

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

2016-03-22 Thread Steve Niemitz
> On March 16, 2016, 11:08 p.m., Jie Yu wrote: > > This patch breaks all the ROOT DOCKER tests in our internal CI. I've > > reverted it for now. Can you do a sudo make check with docker? > > Steve Niemitz wrote: > ok, I see what the problem is here. The issue is

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

2016-03-19 Thread Steve Niemitz
79cd955e9c241becff52cc4bbef81dcc16802ee7 src/slave/containerizer/docker.cpp fb9188a19a5cd8211d4f36f9647ebb70de560109 Diff: https://reviews.apache.org/r/33174/diff/ Testing --- Thanks, Steve Niemitz

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

2016-03-19 Thread Steve Niemitz
fb9188a19a5cd8211d4f36f9647ebb70de560109 Diff: https://reviews.apache.org/r/33174/diff/ Testing --- Thanks, Steve Niemitz

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

2016-03-18 Thread Steve Niemitz
On Feb. 20, 2016, 6:47 p.m., Steve Niemitz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33174/ > --- >

Re: Review Request 44785: Don't use --as-needed on OSX.

2016-03-14 Thread Steve Niemitz
/diff/ Testing --- Thanks, Steve Niemitz

Re: Review Request 44785: Don't use --as-needed on OSX.

2016-03-14 Thread Steve Niemitz
--- Thanks, Steve Niemitz

Re: Review Request 44785: Don't use --as-needed on OSX.

2016-03-14 Thread Steve Niemitz
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44785/#review123413 ------- On March 14, 2016, 2:21 p.m., Steve Niemitz wrote: > >

Review Request 44785: Don't use --as-needed on OSX.

2016-03-14 Thread Steve Niemitz
Description --- Don't use --as-needed on OSX. Diffs - src/python/native_common/ext_modules.py.in 0a005dc5746aec428be6dbaf02e58f293d87a05c Diff: https://reviews.apache.org/r/44785/diff/ Testing --- Thanks, Steve Niemitz

Re: Review Request 41049: New python lib with only the executor driver.

2016-03-09 Thread Steve Niemitz
worked - Made sure mesos.native still worked Thanks, Steve Niemitz

Re: Review Request 41049: New python lib with only the executor driver.

2016-03-08 Thread Steve Niemitz
compatiblity, but if it's going to cause problems we could drop it. - Steve Niemitz On March 8, 2016, 6:25 p.m., Steve Niemitz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 41049: New python lib with only the executor driver.

2016-03-08 Thread Steve Niemitz
Thanks, Steve Niemitz

Re: Review Request 41049: New python lib with only the executor driver.

2016-03-08 Thread Steve Niemitz
- Tested with aurora executor - Made sure mesos.scheduler still worked - Made sure mesos.native still worked Thanks, Steve Niemitz

Re: Review Request 41049: New python lib with only the executor driver.

2016-03-07 Thread Steve Niemitz
- Made sure mesos.native still worked Thanks, Steve Niemitz

Re: Review Request 41049: New python lib with only the executor driver.

2016-03-04 Thread Steve Niemitz
1049/diff/ Testing --- On CentOS 7, GCC 4.8.5: - make distcheck - Tested with aurora executor - Made sure mesos.scheduler still worked - Made sure mesos.native still worked Thanks, Steve Niemitz

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

2016-03-02 Thread Steve Niemitz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33174/#review121650 --- @jieyu ping? - Steve Niemitz On Feb. 20, 2016, 6:47 p.m

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

2016-02-20 Thread Steve Niemitz
, Steve Niemitz

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

2016-02-20 Thread Steve Niemitz
`--cpu-quota` during > > launch so that we don't have to worry about that window. > > Steve Niemitz wrote: > Is there a minimum supported version of docker for mesos? Those > parameters were added in docker 1.7 I believe. > > Jie Yu wrote: > Yeah, I think for no

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

2016-02-20 Thread Steve Niemitz
> > running in a docker container)? > > Steve Niemitz wrote: > The command executor is a totally different code path, so calling update > wouldn't update the right thing. I'd like to handle that in a seperate > review since its more complicated. > > Jie Yu wrote: &g

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

2016-02-19 Thread Steve Niemitz
t window. Is there a minimum supported version of docker for mesos? Those parameters were added in docker 1.7 I believe. - Steve --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33174/#review119

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

2015-12-15 Thread Steve Niemitz
/r/33174/diff/ Testing --- Thanks, Steve Niemitz

Review Request 41410: Export CFS metrics for docker containers

2015-12-15 Thread Steve Niemitz
--- Export CFS metrics for docker containers Diffs - src/slave/containerizer/docker.cpp 2d2dd4e0df36207c5f3cbb4fe2c50df51c0f3e9e Diff: https://reviews.apache.org/r/41410/diff/ Testing --- Thanks, Steve Niemitz