---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44531/#review122860
---
Ship it!
Ship It!
- Travis Hegner
On March 8, 2016, 10:54
gt; > the value of `networkModeValue` would be `default` but not `bridge`, and
> > this will cause line 315 constrcut a invalid addressLocation as
> > `NetworkSettings.Networks.default.IPAddress` which will always failed and
> > thus fall to old API.
>
> Travis Hegner wrot
is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43093/#review122802
-----------
On Feb. 17, 2016, 10:52 p.m., Travis Hegner wrote:
>
> ---
> This is an automatic
gt; > the value of `networkModeValue` would be `default` but not `bridge`, and
> > this will cause line 315 constrcut a invalid addressLocation as
> > `NetworkSettings.Networks.default.IPAddress` which will always failed and
> > thus fall to old API.
>
> Travis Hegner wrot
gt; > the value of `networkModeValue` would be `default` but not `bridge`, and
> > this will cause line 315 constrcut a invalid addressLocation as
> > `NetworkSettings.Networks.default.IPAddress` which will always failed and
> > thus fall to old API.
>
> Travis Hegner wrot
---------
>
> (Updated March 8, 2016, 10:54 p.m.)
>
>
> Review request for mesos, Dan Osborne, Jie Yu, and Travis Hegner.
>
>
> Bugs: MESOS-4370
> https://issues.apache.org/jira/browse/MESOS-4370
>
>
> Re
> On March 7, 2016, 5:36 p.m., Timothy Chen wrote:
> > Are you still be able to work on this? We like to get this merged, so if
> > you can't or don't reply we will create a new patch based on this.
>
> Travis Hegner wrote:
> Hi Timothy,
>
> I'v
e`: After this patch this will fail with `Unable to
> detect network mode.`. Is that a scenario which might break currently working
> setups?
>
> haosdent huang wrote:
> >Is that a scenario which might break currently working setups
>
> Yes, `HostConfig.Netwo
> On March 7, 2016, 5:36 p.m., Timothy Chen wrote:
> > Are you still be able to work on this? We like to get this merged, so if
> > you can't or don't reply we will create a new patch based on this.
>
> Travis Hegner wrote:
> Hi Timothy,
>
> I'v
org/r/43093/#review122314
---
On Feb. 17, 2016, 10:52 p.m., Travis Hegner wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
&g
> On Feb. 12, 2016, 3:25 p.m., Travis Hegner wrote:
> > Please have a look at https://reviews.apache.org/r/43093/. Should these
> > patches be combined, or worked on together? Adding support for user defined
> > networks, should also include support for proper IP
the existing "NetworkSettings.IPAddress"
field which mesos uses to identify the container's IP.
- Travis Hegner
On Feb. 11, 2016, 1:51 p.m., Ezra Silvera wrote:
>
> ---
> This is an automatically generated e-mail. To re
On Feb. 9, 2016, 7:13 p.m., Travis Hegner wrote:
> > hanks
>
> Joerg Schad wrote:
> Oh btw regarding the commit message:
> We usually have commit messages stating what changed, so in your case it
> could be something along the lines of 'Added support for new dock
e319>
> >
> > Any reason you have a blank line here?
Likely missed it, or I'm not accustomed to the mesos style yet. I will take
care of this.
- Travis
---
This is an automatically generated e-mail. T
On Feb. 9, 2016, 7:13 p.m., Travis Hegner wrote:
> > hanks
>
> Joerg Schad wrote:
> Oh btw regarding the commit message:
> We usually have commit messages stating what changed, so in your case it
> could be something along the lines of 'Added support for new dock
that the docker API will change again in the near future,
but I can't speculate how, so at least this fixes the problem as it stands
right now.
Tested and working with Docker 1.9.1, Mesos 0.27.0, on Ubuntu 14.04.
Thanks,
Travis Hegner
omatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43093/#review117597
-----------
On Feb. 3, 2016, 7:04 p.m., Travis Hegner wrote:
>
> ---
> This is
speculate that the docker API will change again in the near future,
but I can't speculate how, so at least this fixes the problem as it stands
right now.
Tested and working with Docker 1.9.1, Mesos 0.27.0, on Ubuntu 14.04.
Thanks,
Travis Hegner
etworks..IPAddress" will never exist, but
exists in the new API.
Any testing of these fields would be mutually exclusive.
- Travis
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apa
as it stands
right now.
Tested and working with Docker 1.9.1, Mesos 0.27.0, on Ubuntu 14.04.
Thanks,
Travis Hegner
with Docker 1.9.1, Mesos 0.27.0, on Ubuntu 14.04
Thanks,
Travis Hegner
speculate how, so at least this fixes the problem as it stands
right now.
Tested and working with Docker 1.9.1, Mesos 0.27.0, on Ubuntu 14.04.
Thanks,
Travis Hegner
22 matches
Mail list logo
