Re: Review Request 62105: Enabled building of the Cyrus SASL CRAM MD5 lib on Windows.

2017-10-02 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62105/#review186622 --- Ship it! I can make the tweaks listed below before committing.

Re: Review Request 62105: Enabled building of the Cyrus SASL CRAM MD5 lib on Windows.

2017-09-19 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62105/#review185747 --- Ship it! Ship It! - Andrew Schwartzmeyer On Sept. 19, 2017,

Re: Review Request 62105: Enabled building of the Cyrus SASL CRAM MD5 lib on Windows.

2017-09-19 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62105/ --- (Updated Sept. 19, 2017, 4:57 p.m.) Review request for mesos, Andrew Schwartzme

Re: Review Request 62105: Enabled building of the Cyrus SASL CRAM MD5 lib on Windows.

2017-09-18 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62105/#review185613 --- 3rdparty/CMakeLists.txt Lines 189-213 (patched)

Re: Review Request 62105: Enabled building of the Cyrus SASL CRAM MD5 lib on Windows.

2017-09-08 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62105/ --- (Updated Sept. 8, 2017, 10:13 p.m.) Review request for mesos, Andrew Schwartzme

Re: Review Request 62105: Enabled building of the Cyrus SASL CRAM MD5 lib on Windows.

2017-09-07 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62105/#review184912 --- 3rdparty/CMakeLists.txt Lines 193-195 (patched)

Re: Review Request 62105: Enabled building of the Cyrus SASL CRAM MD5 lib on Windows.

2017-09-06 Thread John Kordich via Review Board
> On Sept. 6, 2017, 8:48 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/cyrus_sasl-2.1.27rc3.patch > > Lines 1 (patched) > > > > > > Since it's a patch, I won't review it too much. However, we should > > ensure we sub

Re: Review Request 62105: Enabled building of the Cyrus SASL CRAM MD5 lib on Windows.

2017-09-06 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62105/ --- (Updated Sept. 7, 2017, 1:11 a.m.) Review request for mesos, Andrew Schwartzmey

Re: Review Request 62105: Enabled building of the Cyrus SASL CRAM MD5 lib on Windows.

2017-09-06 Thread Joseph Wu
> On Sept. 6, 2017, 1:48 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/CMakeLists.txt > > Lines 197-198 (patched) > > > > > > I think Joe ended up committing slightly different formatting > > conventions here, with

Re: Review Request 62105: Enabled building of the Cyrus SASL CRAM MD5 lib on Windows.

2017-09-06 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62105/#review184728 --- 3rdparty/CMakeLists.txt Lines 194 (patched)

Re: Review Request 62105: Enabled building of the Cyrus SASL CRAM MD5 lib on Windows.

2017-09-06 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62105/ --- (Updated Sept. 6, 2017, 8:35 p.m.) Review request for mesos, Andrew Schwartzmey

Re: Review Request 62105: Enabled building of the Cyrus SASL CRAM MD5 lib on Windows.

2017-09-06 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62105/#review184717 --- Also make sure you pull the master branch and rebase so this revie

Re: Review Request 62105: Enabled building of the Cyrus SASL CRAM MD5 lib on Windows.

2017-09-06 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62105/#review184712 --- 3rdparty/CMakeLists.txt Lines 208 (patched)