Re: Review Request 65334: Added quota limit to the master API protos.

2018-04-11 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65334/#review200912 --- Ship it! - Meng Zhu On March 9, 2018, 5:46 p.m., Benjamin

Re: Review Request 65334: Added quota limit to the master API protos.

2018-04-10 Thread Benjamin Mahler
> On March 18, 2018, 8:27 p.m., Meng Zhu wrote: > > include/mesos/master/master.proto > > Lines 206 (patched) > > > > > > Why we are making it a repeated field? What is the usage case? Much like `UpdateWeights`,

Re: Review Request 65334: Added quota limit to the master API protos.

2018-04-10 Thread Benjamin Mahler
> On March 18, 2018, 6:27 p.m., Meng Zhu wrote: > > include/mesos/v1/quota/quota.proto > > Lines 46-48 (original), 67-69 (patched) > > > > > > If I understand it correctly, > > > > for guarantee check, we

Re: Review Request 65334: Added quota limit to the master API protos.

2018-03-18 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65334/#review199391 --- include/mesos/master/master.proto Lines 206 (patched)

Re: Review Request 65334: Added quota limit to the master API protos.

2018-03-18 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65334/#review199386 --- include/mesos/v1/quota/quota.proto Lines 46-48 (original), 67-69

Re: Review Request 65334: Added quota limit to the master API protos.

2018-03-09 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65334/ --- (Updated March 10, 2018, 1:46 a.m.) Review request for mesos, Alexander

Re: Review Request 65334: Added quota limit to the master API protos.

2018-03-07 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65334/#review198834 --- include/mesos/v1/quota/quota.proto Lines 38-40 (original), 30

Re: Review Request 65334: Added quota limit to the master API protos.

2018-02-23 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65334/ --- (Updated Feb. 23, 2018, 10:23 p.m.) Review request for mesos, Alexander

Re: Review Request 65334: Added quota limit to the master API protos.

2018-02-05 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65334/#review196836 --- PASS: Mesos patch 65334 was successfully built and tested.

Re: Review Request 65334: Added quota limit to the master API protos.

2018-02-05 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65334/#review196832 --- Ship it! Ship It! - Meng Zhu On Jan. 30, 2018, 4:21 p.m.,

Re: Review Request 65334: Added quota limit to the master API protos.

2018-01-30 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65334/ --- (Updated Jan. 31, 2018, 12:21 a.m.) Review request for mesos, Alexander

Re: Review Request 65334: Added quota limit to the master API protos.

2018-01-25 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65334/#review196242 --- include/mesos/quota/quota.proto Lines 38-50 (original), 30-34

Re: Review Request 65334: Added quota limit to the master API protos.

2018-01-24 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65334/#review196200 --- PASS: Mesos patch 65334 was successfully built and tested.