Re: Review Request 70169: Refactored SLRP to use `ServiceManager`.

2019-03-08 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70169/#review213572 --- Patch looks great! Reviews applied: [70168, 70169] Passed comman

Re: Review Request 70169: Refactored SLRP to use `ServiceManager`.

2019-03-08 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70169/#review213578 --- Patch looks great! Reviews applied: [70168, 70169] Passed comman

Re: Review Request 70169: Refactored SLRP to use `ServiceManager`.

2019-03-12 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70169/ --- (Updated March 12, 2019, 8:43 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 70169: Refactored SLRP to use `ServiceManager`.

2019-03-13 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70169/#review213690 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 70169: Refactored SLRP to use `ServiceManager`.

2019-03-19 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70169/#review213801 --- Reviewed simultaneously with https://reviews.apache.org/r/70168/,

Re: Review Request 70169: Refactored SLRP to use `ServiceManager`.

2019-03-19 Thread Chun-Hung Hsiao
> On March 19, 2019, 1:12 p.m., Benjamin Bannier wrote: > > src/resource_provider/storage/provider.cpp > > Line 3734 (original), 3140 (patched) > > > > > > Preexisting, but isn't this already covered by above > > `

Re: Review Request 70169: Refactored SLRP to use `ServiceManager`.

2019-03-19 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70169/ --- (Updated March 20, 2019, 6:03 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 70169: Refactored SLRP to use `ServiceManager`.

2019-03-20 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70169/#review213834 --- Fix it, then Ship it! Looking good. Let's squash this with http

Re: Review Request 70169: Refactored SLRP to use `ServiceManager`.

2019-03-22 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70169/#review213926 --- FAIL: Failed to apply the current review. Failed command: `python