Re: Review Request 35433: Send StatusUpdates if checkpointed resources don't exist on the slave.

2015-06-18 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35433/ --- (Updated June 19, 2015, 12:42 a.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 35433: Send StatusUpdates if checkpointed resources don't exist on the slave.

2015-06-18 Thread Michael Park
> On June 18, 2015, 5:21 p.m., Benjamin Hindman wrote: > > src/slave/slave.cpp, lines 1418-1420 > > > > > > The only logic question I have here now is how come we don't need the > > following code even though we use

Re: Review Request 35433: Send StatusUpdates if checkpointed resources don't exist on the slave.

2015-06-18 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35433/ --- (Updated June 18, 2015, 7:47 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 35433: Send StatusUpdates if checkpointed resources don't exist on the slave.

2015-06-18 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35433/ --- (Updated June 18, 2015, 6:45 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 35433: Send StatusUpdates if checkpointed resources don't exist on the slave.

2015-06-18 Thread Jie Yu
> On June 18, 2015, 5:21 p.m., Benjamin Hindman wrote: > > src/slave/slave.cpp, lines 1418-1420 > > > > > > The only logic question I have here now is how come we don't need the > > following code even though we use

Re: Review Request 35433: Send StatusUpdates if checkpointed resources don't exist on the slave.

2015-06-18 Thread Jie Yu
> On June 18, 2015, 5:27 p.m., Jie Yu wrote: > > src/slave/slave.cpp, lines 1403-1421 > > > > > > Hum, are you sending multiple status update if there are multiple > > 'resource's in 'checkpointedTaskResources'? My

Re: Review Request 35433: Send StatusUpdates if checkpointed resources don't exist on the slave.

2015-06-18 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35433/#review88406 --- src/slave/slave.cpp (lines 1403 - 1421)

Re: Review Request 35433: Send StatusUpdates if checkpointed resources don't exist on the slave.

2015-06-18 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35433/#review88405 --- src/slave/slave.cpp (lines 1418 - 1420)

Re: Review Request 35433: Send StatusUpdates if checkpointed resources don't exist on the slave.

2015-06-18 Thread Michael Park
> On June 18, 2015, 5 p.m., Jie Yu wrote: > > Your latest diff does not look right. Sorry about that, rebased. - Michael --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35433/#review88392 ---

Re: Review Request 35433: Send StatusUpdates if checkpointed resources don't exist on the slave.

2015-06-18 Thread Michael Park
> On June 18, 2015, 5:02 p.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, lines 104-112 > > > > > > Ditto. Yeah, sorry about that. Rebased. - Michael --

Re: Review Request 35433: Send StatusUpdates if checkpointed resources don't exist on the slave.

2015-06-18 Thread Michael Park
> On June 18, 2015, 5:02 p.m., Alexander Rukletsov wrote: > > docs/mesos-frameworks.md, lines 29-30 > > > > > > Artifact? This was recently removed. Yeah, sorry about that. Rebased. - Michael --

Re: Review Request 35433: Send StatusUpdates if checkpointed resources don't exist on the slave.

2015-06-18 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35433/ --- (Updated June 18, 2015, 5:03 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 35433: Send StatusUpdates if checkpointed resources don't exist on the slave.

2015-06-18 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35433/#review88393 --- Michael, there are some artifacts in the patch, could you please reb

Re: Review Request 35433: Send StatusUpdates if checkpointed resources don't exist on the slave.

2015-06-18 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35433/ --- (Updated June 18, 2015, 5:01 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 35433: Send StatusUpdates if checkpointed resources don't exist on the slave.

2015-06-18 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35433/#review88392 --- Your latest diff does not look right. - Jie Yu On June 18, 2015,

Re: Review Request 35433: Send StatusUpdates if checkpointed resources don't exist on the slave.

2015-06-18 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35433/ --- (Updated June 18, 2015, 4:54 p.m.) Review request for mesos, Benjamin Hindman a