Re: Review Request 36326: containerizer: added cgroups based statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36326/#review91647 --- Patch looks great! Reviews applied: [36106, 36326] All tests passe

Re: Review Request 36326: containerizer: added cgroups based statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36326/ --- (Updated July 14, 2015, 5:04 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 36326: containerizer: added cgroups based statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36326/ --- (Updated July 14, 2015, 4:09 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 36326: containerizer: added cgroups based statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36326/ --- (Updated July 13, 2015, 6:41 p.m.) Review request for Timothy Chen. Changes -

Re: Review Request 36326: containerizer: added cgroups based statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36326/#review91376 --- src/slave/containerizer/docker.cpp (line 1325)

Re: Review Request 36326: containerizer: added cgroups based statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36326/#review91372 --- Patch looks great! Reviews applied: [36106, 36326] All tests passe

Re: Review Request 36326: containerizer: added cgroups based statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36326/ --- (Updated July 10, 2015, 11:03 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 36326: containerizer: added cgroups based statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36326/ --- (Updated July 10, 2015, 10:47 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 36326: containerizer: added cgroups based statistics.

> On July 10, 2015, 8:50 p.m., Timothy Chen wrote: > > src/slave/containerizer/docker.cpp, line 1266 > > > > > > I think you reordered things here that used to be in _usage. > > > > We used to first check t

Re: Review Request 36326: containerizer: added cgroups based statistics.

> On July 10, 2015, 8:50 p.m., Timothy Chen wrote: > > src/slave/containerizer/docker.cpp, line 1266 > > > > > > I think you reordered things here that used to be in _usage. > > > > We used to first check t

Re: Review Request 36326: containerizer: added cgroups based statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36326/#review91342 --- src/slave/containerizer/docker.cpp (line 1216)

Re: Review Request 36326: containerizer: added cgroups based statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36326/#review91224 --- Patch looks great! Reviews applied: [36106, 36326] All tests passe

Re: Review Request 36326: containerizer: added cgroups based statistics.

> On July 8, 2015, 9:57 p.m., Timothy Chen wrote: > > src/slave/containerizer/docker.hpp, line 230 > > > > > > I dont' think we need to expose this. Since the method is a bit long, kept it but replaced other "usage"

Re: Review Request 36326: containerizer: added cgroups based statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36326/ --- (Updated July 9, 2015, 8:38 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 36326: containerizer: added cgroups based statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36326/#review91051 --- Patch looks great! Reviews applied: [36106, 36326] All tests passe

Re: Review Request 36326: containerizer: added cgroups based statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36326/#review91005 --- src/slave/containerizer/docker.hpp (line 230)

Re: Review Request 36326: containerizer: added cgroups based statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36326/ --- (Updated July 8, 2015, 9:40 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 36326: containerizer: added cgroups based statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36326/ --- (Updated July 8, 2015, 9:02 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 36326: containerizer: added cgroups based statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36326/ --- (Updated July 8, 2015, 8:53 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 36326: containerizer: added cgroups based statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36326/ --- (Updated July 8, 2015, 8:39 p.m.) Review request for mesos and Timothy Chen.

Review Request 36326: containerizer: added cgroups based statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36326/ --- Review request for mesos and Timothy Chen. Repository: mesos Description