https://issues.apache.org/jira/browse/MESOS-2902 says this will be done in
a module instead?
Do we still need this review?
On Wed, Jul 22, 2015 at 3:31 AM, Mesos ReviewBot reviews@mesos.apache.org
wrote:
---
This is an automatically
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36425/
---
(Updated July 22, 2015, 7:33 a.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36425/
---
(Updated July 22, 2015, 7:39 a.m.)
Review request for mesos, Benjamin Hindman
On July 19, 2015, 8:09 p.m., Benjamin Hindman wrote:
src/master/main.cpp, line 139
https://reviews.apache.org/r/36425/diff/4/?file=1010039#file1010039line139
We've tried to name our flags the same as how you'd see them on the
command line, so
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36425/
---
(Updated July 21, 2015, 4:47 p.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36425/#review92219
---
src/master/main.cpp (line 139)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36425/
---
(Updated July 13, 2015, 7:25 p.m.)
Review request for mesos, Benjamin Hindman
On July 13, 2015, 6:14 p.m., Anand Mazumdar wrote:
a few fly-by general comments.
thanks!
On July 13, 2015, 6:14 p.m., Anand Mazumdar wrote:
src/master/main.cpp, line 205
https://reviews.apache.org/r/36425/diff/2/?file=1009590#file1009590line205
Can we align this similar to
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36425/#review91496
---
a few fly-by general comments.
src/master/main.cpp (line 93)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36425/#review91489
---
Patch looks great!
Reviews applied: [36424, 36425]
All tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36425/#review91492
---
docs/configuration.md (line 92)
On July 13, 2015, 6:14 p.m., Anand Mazumdar wrote:
src/master/main.cpp, line 211
https://reviews.apache.org/r/36425/diff/2/?file=1009590#file1009590line211
Can we remove the reference here ?
strings::trim(...) returns a temporary that would be destroyed at the
end
On July 13, 2015, 9:12 p.m., Cody Maloney wrote:
Generally looks reasonable to me. I haven't integration tested yet inside
DCOS, will work on that before too long.
Marco Massenzio wrote:
reasonable
not exactly a ringing endorsement :) but I guess I'll take it...
13 matches
Mail list logo
