Re: Review Request 36656: Removed 'SSL_ENABLE_SSL_V2' configuration flag for SSLv2.

2015-07-26 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36656/ --- (Updated July 26, 2015, 5:28 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 36656: Removed 'SSL_ENABLE_SSL_V2' configuration flag for SSLv2.

2015-07-26 Thread Joris Van Remoortere
On July 22, 2015, 7:51 p.m., Michael Park wrote: 3rdparty/libprocess/src/openssl.cpp, line 332 https://reviews.apache.org/r/36656/diff/1/?file=1018170#file1018170line332 Saw this while grepping for `SSLv2`. We still need to use this rather than `TLS_method` currently

Re: Review Request 36656: Removed 'SSL_ENABLE_SSL_V2' configuration flag for SSLv2.

2015-07-22 Thread Michael Park
On July 21, 2015, 10:59 p.m., Artem Harutyunyan wrote: 3rdparty/libprocess/src/tests/ssl_tests.cpp, line 676 https://reviews.apache.org/r/36656/diff/1/?file=1018171#file1018171line676 s/protocol/protocols/ Now that we're only referring to SSL-V3, I think it should be:

Re: Review Request 36656: Removed 'SSL_ENABLE_SSL_V2' configuration flag for SSLv2.

2015-07-21 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36656/#review92534 --- Ship it! 3rdparty/libprocess/src/openssl.cpp (line 489)

Review Request 36656: Removed 'SSL_ENABLE_SSL_V2' configuration flag for SSLv2.

2015-07-21 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36656/ --- Review request for mesos, Benjamin Hindman and Michael Park. Bugs: MESOS-3121

Re: Review Request 36656: Removed 'SSL_ENABLE_SSL_V2' configuration flag for SSLv2.

2015-07-21 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36656/ --- (Updated July 21, 2015, 10:51 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 36656: Removed 'SSL_ENABLE_SSL_V2' configuration flag for SSLv2.

2015-07-21 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36656/#review92492 --- Ship it! 3rdparty/libprocess/src/tests/ssl_tests.cpp (line 673)