Re: Review Request 36819: Use setup.py in python cli package.

2015-08-13 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/#review95303 --- Ship it! LGTM module the issue below. BTW, do we know if anyone

Re: Review Request 36819: Use setup.py in python cli package.

2015-08-13 Thread haosdent huang
On Aug. 13, 2015, 6:27 p.m., Kapil Arya wrote: src/cli/python/mesos/__init__.py, line 27 https://reviews.apache.org/r/36819/diff/6/?file=1034329#file1034329line27 Don't we need a `mesos.cli` here as well? Kartic Krish wrote: Looks like the module structure has been changed,

Re: Review Request 36819: Use setup.py in python cli package.

2015-08-13 Thread haosdent huang
On Aug. 13, 2015, 4 p.m., Marco Massenzio wrote: Today we are cutting a 0.24 RC (according to @Vinod's recent email) - it would be great if we could have this fix in, which solves an issue with the Python installers. Can anyone please do anything about this one? Thanks! T_T?

Re: Review Request 36819: Use setup.py in python cli package.

2015-08-13 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/ --- (Updated Aug. 13, 2015, 6:46 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 36819: Use setup.py in python cli package.

2015-08-13 Thread Kartic Krish
On Aug. 13, 2015, 6:27 p.m., Kapil Arya wrote: src/cli/python/mesos/__init__.py, line 27 https://reviews.apache.org/r/36819/diff/6/?file=1034329#file1034329line27 Don't we need a `mesos.cli` here as well? Looks like the module structure has been changed, so just 'packages': [

Re: Review Request 36819: Use setup.py in python cli package.

2015-08-13 Thread Kartic Krish
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/#review95305 --- Looks good. Please include the she-bang in setup.py (as per

Re: Review Request 36819: Use setup.py in python cli package.

2015-08-13 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/#review95374 --- Ship it! Ship It! - Till Toenshoff On Aug. 13, 2015, 6:46 p.m.,

Re: Review Request 36819: Use setup.py in python cli package.

2015-08-13 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/#review95262 --- Ship it! Today we are cutting a 0.24 RC (according to @Vinod's

Re: Review Request 36819: Use setup.py in python cli package.

2015-08-12 Thread haosdent huang
On Aug. 12, 2015, 4:47 p.m., Alexander Rojas wrote: src/cli/python/mesos/__init__.py, line 1 https://reviews.apache.org/r/36819/diff/6/?file=1034329#file1034329line1 Why was the shebang line removed? The origin file is __init__.py. __init__.py need have shebang line. But this file

Re: Review Request 36819: Use setup.py in python cli package.

2015-08-12 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/#review95112 --- src/cli/python/mesos/__init__.py

Re: Review Request 36819: Use setup.py in python cli package.

2015-08-07 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/ --- (Updated Aug. 7, 2015, 2:31 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 36819: Use setup.py in python cli package.

2015-08-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/#review94554 --- Patch looks great! Reviews applied: [36819] All tests passed. -

Re: Review Request 36819: Use setup.py in python cli package.

2015-08-07 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/ --- (Updated Aug. 7, 2015, 3:08 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 36819: Use setup.py in python cli package.

2015-08-03 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/#review93931 --- Ship it! This looks good to me. Provided that we test it on a

Re: Review Request 36819: Use setup.py in python cli package.

2015-08-01 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/ --- (Updated Aug. 1, 2015, 10:09 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 36819: Use setup.py in python cli package.

2015-07-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/#review93552 --- Patch looks great! Reviews applied: [36819] All tests passed. -

Re: Review Request 36819: Use setup.py in python cli package.

2015-07-29 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/ --- (Updated July 30, 2015, 2:49 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 36819: Use setup.py in python cli package.

2015-07-29 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/ --- (Updated July 29, 2015, 7:44 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 36819: Use setup.py in python cli package.

2015-07-29 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/ --- (Updated July 29, 2015, 7:43 a.m.) Review request for mesos and Benjamin

Re: Review Request 36819: Use setup.py in python cli package.

2015-07-29 Thread haosdent huang
On July 27, 2015, 5:58 p.m., Marco Massenzio wrote: thanks for doing this! (this may also fix a long-standing issue of mine: https://issues.apache.org/jira/browse/MESOS-2337 - could you please take a look?) Only a few minor nits about formatting and stuff, then I think this is

Re: Review Request 36819: Use setup.py in python cli package.

2015-07-27 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/#review93141 --- thanks for doing this! (this may also fix a long-standing issue of

Review Request 36819: Use setup.py in python cli package.

2015-07-26 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/ --- Review request for mesos. Repository: mesos Description --- Use

Re: Review Request 36819: Use setup.py in python cli package.

2015-07-26 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/ --- (Updated July 26, 2015, 5:10 p.m.) Review request for mesos and Benjamin

Re: Review Request 36819: Use setup.py in python cli package.

2015-07-26 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/ --- (Updated July 26, 2015, 5:24 p.m.) Review request for mesos and Benjamin

Re: Review Request 36819: Use setup.py in python cli package.

2015-07-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/#review93047 --- Patch looks great! Reviews applied: [36819] All tests passed. -