Re: Review Request 37024: Exposes mesos version information in components.

Oh man, me too. :) On Mon, Oct 12, 2015 at 11:50 AM, Benjamin Mahler wrote: > Apologies, I've committed the fix for cmake. Looking forward to getting it > set up in jenkins to catch these! > > On Sun, Oct 11, 2015 at 9:53 AM, haosdent huang > wrote: > >> This is an automatically generated e-mai

Re: Review Request 37024: Exposes mesos version information in components.

Apologies, I've committed the fix for cmake. Looking forward to getting it set up in jenkins to catch these! On Sun, Oct 11, 2015 at 9:53 AM, haosdent huang wrote: > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37024/ > > On October 10th, 2015, 10:17

Re: Review Request 37024: Exposes mesos version information in components.

> On Oct. 10, 2015, 10:17 a.m., Alex Clemmer wrote: > > src/Makefile.am, line 554 > > > > > > Hmm, I know this is submitted, but can we go back and add this also to > > the CMakeLists.txt in src/? Sorry, my fault

Re: Review Request 37024: Exposes mesos version information in components.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37024/#review102162 --- src/Makefile.am (line 554)

Re: Review Request 37024: Exposes mesos version information in components.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37024/#review101841 --- Ship it! Thanks for your patience! Committing this shortly. src/

Re: Review Request 37024: Exposes mesos version information in components.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37024/#review101881 --- Patch looks great! Reviews applied: [37024] All tests passed. -

Re: Review Request 37024: Exposes mesos version information in components.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37024/ --- (Updated Oct. 8, 2015, 7:01 a.m.) Review request for mesos and Ben Mahler. Ch

Re: Review Request 37024: Exposes mesos version information in components.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37024/ --- (Updated Oct. 7, 2015, 2:56 a.m.) Review request for mesos and Ben Mahler. Ch

Re: Review Request 37024: Exposes mesos version information in components.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37024/ --- (Updated Oct. 7, 2015, 2:47 a.m.) Review request for mesos and Ben Mahler. Ch

Re: Review Request 37024: Exposes mesos version information in components.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37024/ --- (Updated Oct. 7, 2015, 2:30 a.m.) Review request for mesos and Ben Mahler. Ch

Re: Review Request 37024: Exposes mesos version information in components.

> On Oct. 6, 2015, 7:23 p.m., Ben Mahler wrote: > > Would be great to add a unit test for VersionProcess as a follow up, not in > > this patch. Thank you very much, let me add it later. - haosdent --- This is an automatically generated

Re: Review Request 37024: Exposes mesos version information in components.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37024/#review101679 --- Would be great to add a unit test for VersionProcess as a follow up

Re: Review Request 37024: Exposes mesos version information in components.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37024/#review101617 --- Patch looks great! Reviews applied: [37024] All tests passed. -

Re: Review Request 37024: Exposes mesos version information in components.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37024/ --- (Updated Oct. 6, 2015, 2:02 a.m.) Review request for mesos and Ben Mahler. Ch

Re: Review Request 37024: Exposes mesos version information in components.

> On Oct. 6, 2015, 1:16 a.m., Ben Mahler wrote: > > Sorry, this should be the last iteration. :) Never mind, it is my fault not to recompile it again before update. Thank you very much. - haosdent --- This is an automatically generated

Re: Review Request 37024: Exposes mesos version information in components.

> On Oct. 6, 2015, 1:16 a.m., Ben Mahler wrote: > > src/version/version.hpp, line 43 > > > > > > Hm.. I'm confused as to how you can initialize this non-static member > > in the .cpp file as you're doing now. Can you

Re: Review Request 37024: Exposes mesos version information in components.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37024/#review101571 --- Ship it! Sorry, this should be the last iteration. :) src/versio

Re: Review Request 37024: Exposes mesos version information in components.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37024/ --- (Updated Oct. 6, 2015, 1:14 a.m.) Review request for mesos and Ben Mahler. Ch

Re: Review Request 37024: Exposes mesos version information in components.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37024/ --- (Updated Oct. 6, 2015, 1:11 a.m.) Review request for mesos and Ben Mahler. Ch

Re: Review Request 37024: Exposes mesos version information in components.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37024/#review101534 --- Ship it! Looks great hsaodent! Thanks for your patience, just a co

Re: Review Request 37024: Exposes mesos version information in components.

> On Oct. 5, 2015, 6:48 p.m., Marco Massenzio wrote: > > src/version/version.cpp, lines 81-82 > > > > > > Minor nit: s/mesos/Apache Mesos and I think you can drop the "This > > endpoint" - "Shows the current version

Re: Review Request 37024: Exposes mesos version information in components.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37024/#review101508 --- src/version/version.cpp (lines 81 - 82)

Re: Review Request 37024: Exposes mesos version information in components.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37024/#review101506 --- Ship it! Ship It! - Marco Massenzio On Oct. 5, 2015, 8 a.m., ha

Re: Review Request 37024: Exposes mesos version information in components.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37024/ --- (Updated Oct. 5, 2015, 8 a.m.) Review request for mesos and Ben Mahler. Chang

Re: Review Request 37024: Exposes mesos version information in components.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37024/ --- (Updated Oct. 4, 2015, 3:12 p.m.) Review request for mesos and Ben Mahler. Ch

Re: Review Request 37024: Exposes mesos version information in components.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37024/ --- (Updated Oct. 4, 2015, 2:39 p.m.) Review request for mesos and Ben Mahler. Bu

Re: Review Request 37024: Exposes mesos version information in components.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37024/ --- (Updated Oct. 4, 2015, 2:25 p.m.) Review request for mesos and Ben Mahler. Bu

Re: Review Request 37024: Exposes mesos version information in components.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37024/ --- (Updated Oct. 4, 2015, 1:07 p.m.) Review request for mesos and Ben Mahler. Bu

Re: Review Request 37024: Exposes mesos version information in components.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37024/ --- (Updated Oct. 4, 2015, 1:07 p.m.) Review request for mesos and Ben Mahler. Bu

Re: Review Request 37024: Exposes mesos version information in components.

> On Aug. 31, 2015, 10:47 p.m., Ben Mahler wrote: > > Couple of comments: > > > > Let's not call the actor VersionInfo, since that sounds like a protobuf > > message. How about 'VersionProcess' and we avoid the wrapper type entirely > > since Version is taken in stout? > > > > Also, can we in

Re: Review Request 37024: Exposes mesos version information in components.

> On Aug. 31, 2015, 10:47 p.m., Ben Mahler wrote: > > Couple of comments: > > > > Let's not call the actor VersionInfo, since that sounds like a protobuf > > message. How about 'VersionProcess' and we avoid the wrapper type entirely > > since Version is taken in stout? > > > > Also, can we in

Re: Review Request 37024: Exposes mesos version information in components.

> On Aug. 31, 2015, 10:47 p.m., Ben Mahler wrote: > > Couple of comments: > > > > Let's not call the actor VersionInfo, since that sounds like a protobuf > > message. How about 'VersionProcess' and we avoid the wrapper type entirely > > since Version is taken in stout? > > > > Also, can we in

Re: Review Request 37024: Exposes mesos version information in components.

> On Aug. 31, 2015, 10:47 p.m., Ben Mahler wrote: > > Couple of comments: > > > > Let's not call the actor VersionInfo, since that sounds like a protobuf > > message. How about 'VersionProcess' and we avoid the wrapper type entirely > > since Version is taken in stout? > > > > Also, can we in

Re: Review Request 37024: Exposes mesos version information in components.

> On Aug. 3, 2015, 7:37 p.m., Ben Mahler wrote: > > src/master/http.cpp, lines 526-542 > > > > > > Could you include these fields as well? They capture "version" / > > "build" information. Once you do, perhaps it is

Re: Review Request 37024: Exposes mesos version information in components.

> On Aug. 3, 2015, 7:37 p.m., Ben Mahler wrote: > > src/master/http.cpp, lines 526-542 > > > > > > Could you include these fields as well? They capture "version" / > > "build" information. Once you do, perhaps it is

Re: Review Request 37024: Exposes mesos version information in components.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37024/#review97180 --- Couple of comments: Let's not call the actor VersionInfo, since tha

Re: Review Request 37024: Exposes mesos version information in components.

> On Aug. 3, 2015, 7:37 p.m., Ben Mahler wrote: > > src/master/http.cpp, lines 526-542 > > > > > > Could you include these fields as well? They capture "version" / > > "build" information. Once you do, perhaps it is

Re: Review Request 37024: Exposes mesos version information in components.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37024/#review95552 --- Patch looks great! Reviews applied: [37024] All tests passed. - M

Re: Review Request 37024: Exposes mesos version information in components.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37024/ --- (Updated Aug. 16, 2015, 5:38 p.m.) Review request for mesos and Ben Mahler. S