Re: Review Request 37173: Maintenance Primitives: Added unavailability to Allocator's Slave struct.

2015-09-14 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37173/ --- (Updated Sept. 14, 2015, 12:40 p.m.) Review request for mesos, Benjamin

Re: Review Request 37173: Maintenance Primitives: Added unavailability to Allocator's Slave struct.

2015-09-13 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37173/ --- (Updated Sept. 13, 2015, 8:32 p.m.) Review request for mesos, Benjamin

Re: Review Request 37173: Maintenance Primitives: Added unavailability to Allocator's Slave struct.

2015-09-13 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37173/#review98797 --- Ship it! src/master/allocator/mesos/hierarchical.hpp (line 296)

Re: Review Request 37173: Maintenance Primitives: Added unavailability to Allocator's Slave struct.

2015-09-10 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37173/#review98529 --- Ship it! src/master/allocator/mesos/hierarchical.hpp (line 272)

Re: Review Request 37173: Maintenance Primitives: Added unavailability to Allocator's Slave struct.

2015-09-02 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37173/ --- (Updated Sept. 2, 2015, 7:31 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37173: Maintenance Primitives: Added unavailability to Allocator's Slave struct.

2015-08-27 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37173/#review96809 --- include/mesos/master/allocator.proto (line 31)

Re: Review Request 37173: Maintenance Primitives: Added unavailability to Allocator's Slave struct.

2015-08-25 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37173/#review96323 --- Ship it! Ship It! - Guangya Liu On Aug. 25, 2015, 2:12 a.m.,

Re: Review Request 37173: Maintenance Primitives: Added unavailability to Allocator's Slave struct.

2015-08-25 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37173/ --- (Updated Aug. 26, 2015, 2:12 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37173: Maintenance Primitives: Added unavailability to Allocator's Slave struct.

2015-08-18 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37173/ --- (Updated Aug. 18, 2015, 6:57 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37173: Maintenance Primitives: Added unavailability to Allocator's Slave struct.

2015-08-18 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37173/#review95782 --- Ship it! LGTM - Joseph Wu On Aug. 18, 2015, 11:57 a.m., Joris

Re: Review Request 37173: Maintenance Primitives: Added unavailability to Allocator's Slave struct.

2015-08-12 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37173/#review95142 --- include/mesos/master/allocator.hpp (lines 96 - 101)

Re: Review Request 37173: Maintenance Primitives: Added unavailability to Allocator's Slave struct.

2015-08-12 Thread Joseph Wu
On Aug. 12, 2015, 12:01 p.m., Joseph Wu wrote: include/mesos/master/allocator.hpp, lines 96-101 https://reviews.apache.org/r/37173/diff/2/?file=1035790#file1035790line96 I'm not convinced that `addSlave` is the appropriate place to pass the unavailability. This

Re: Review Request 37173: Maintenance Primitives: Added unavailability to Allocator's Slave struct.

2015-08-10 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37173/ --- (Updated Aug. 10, 2015, 7:05 a.m.) Review request for mesos, Benjamin Hindman,