Review Request 37236: Added the linux filesystem isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37236/ --- Review request for mesos, Ian Downes, Timothy Chen, Vinod Kone, and Jiang Yan Xu

Re: Review Request 37236: Added the linux filesystem isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37236/ --- (Updated Aug. 10, 2015, 10:13 p.m.) Review request for mesos, Lily Chen, Ian Do

Re: Review Request 37236: Added the linux filesystem isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37236/#review94622 --- src/slave/containerizer/isolators/filesystem/linux.cpp (line 370) <

Re: Review Request 37236: Added the linux filesystem isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37236/#review94832 --- src/slave/containerizer/isolators/filesystem/linux.hpp (line 38)

Re: Review Request 37236: Added the linux filesystem isolator.

> On Aug. 11, 2015, 9:06 p.m., Jiang Yan Xu wrote: > > src/slave/containerizer/isolators/filesystem/linux.cpp, lines 267-269 > > > > > > mesos.proto documentation on Volume::container_path and > > Volume::host_path

Re: Review Request 37236: Added the linux filesystem isolator.

> On Aug. 10, 2015, 10:56 p.m., Timothy Chen wrote: > > src/slave/containerizer/isolators/filesystem/linux.cpp, line 370 > > > > > > I think we discourage storing reference from temporaries now right? Yes, we do. Bu

Re: Review Request 37236: Added the linux filesystem isolator.

> On Aug. 11, 2015, 9:06 p.m., Jiang Yan Xu wrote: > > src/slave/containerizer/isolators/filesystem/linux.cpp, lines 267-269 > > > > > > mesos.proto documentation on Volume::container_path and > > Volume::host_path

Re: Review Request 37236: Added the linux filesystem isolator.

> On Aug. 11, 2015, 9:06 p.m., Jiang Yan Xu wrote: > > src/slave/containerizer/isolators/filesystem/linux.cpp, lines 318-335 > > > > > > So this is the case where the target is expected to be within the work > > dir

Re: Review Request 37236: Added the linux filesystem isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37236/#review95139 --- src/slave/containerizer/isolators/filesystem/linux.hpp (lines 105 -

Re: Review Request 37236: Added the linux filesystem isolator.

> On Aug. 12, 2015, 6:44 p.m., Jiang Yan Xu wrote: > > src/slave/containerizer/isolators/filesystem/linux.hpp, lines 105-106 > > > > > > So this field is really for https://reviews.apache.org/r/37330 but we > > are

Re: Review Request 37236: Added the linux filesystem isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37236/ --- (Updated Aug. 12, 2015, 6:54 p.m.) Review request for mesos, Lily Chen, Ian Dow

Re: Review Request 37236: Added the linux filesystem isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37236/#review95192 --- Ship it! Ship It! - Timothy Chen On Aug. 12, 2015, 6:54 p.m., Ji

Re: Review Request 37236: Added the linux filesystem isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37236/#review95195 --- include/mesos/mesos.proto (line 1255)

Re: Review Request 37236: Added the linux filesystem isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37236/#review95198 --- Ship it! Ship It! - Jiang Yan Xu On Aug. 12, 2015, 11:54 a.m., J

Re: Review Request 37236: Added the linux filesystem isolator.

> On Aug. 12, 2015, 10:59 p.m., Jiang Yan Xu wrote: > > include/mesos/mesos.proto, line 1255 > > > > > > There is another reference to "Absoluate path" here which should be > > updated. It says "... or a path rela

Re: Review Request 37236: Added the linux filesystem isolator.

> On Aug. 12, 2015, 3:59 p.m., Jiang Yan Xu wrote: > > include/mesos/mesos.proto, line 1255 > > > > > > There is another reference to "Absoluate path" here which should be > > updated. > > Jie Yu wrote: > It s