Re: Review Request 37403: Using AcceptMediaType Request method to validate Accept header

2015-08-13 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37403/#review95296 --- Ship it! Some minor comments and noticed that we were not setting t

Re: Review Request 37403: Using AcceptMediaType Request method to validate Accept header

2015-08-12 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37403/ --- (Updated Aug. 12, 2015, 11:12 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 37403: Using AcceptMediaType Request method to validate Accept header

2015-08-12 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37403/ --- (Updated Aug. 12, 2015, 8:29 p.m.) Review request for mesos and Ben Mahler. B

Re: Review Request 37403: Using AcceptMediaType Request method to validate Accept header

2015-08-12 Thread Isabel Jimenez
> On Aug. 12, 2015, 6:31 p.m., Anand Mazumdar wrote: > > src/master/http.cpp, line 395 > > > > > > This would crash if there was no accept header specified ? No this can only enter the if with an accept header - I

Re: Review Request 37403: Using AcceptMediaType Request method to validate Accept header

2015-08-12 Thread Isabel Jimenez
> On Aug. 12, 2015, 6:31 p.m., Anand Mazumdar wrote: > > src/master/http.cpp, line 391 > > > > > > Check my earlier comment on how we can simplify this. Also , we need to > > do Accept header validations for ALL cal

Re: Review Request 37403: Using AcceptMediaType Request method to validate Accept header

2015-08-12 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37403/#review95135 --- Mainly comments around us having "Accept" header validations for all

Review Request 37403: Using AcceptMediaType Request method to validate Accept header

2015-08-12 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37403/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-2497 https://issues.ap