---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37416/
---
(Updated Aug. 31, 2015, 7:41 p.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37416/
---
(Updated Aug. 31, 2015, 10:14 p.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37416/
---
(Updated Aug. 31, 2015, 10:27 p.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37416/
---
(Updated Aug. 31, 2015, 10:27 p.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37416/#review96166
---
src/linux/perf.cpp (line 418)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37416/#review96172
---
src/linux/perf.cpp (line 418)
On Aug. 24, 2015, 5:53 p.m., Cong Wang wrote:
src/linux/perf.cpp, line 418
https://reviews.apache.org/r/37416/diff/5/?file=1045148#file1045148line418
This is not expected, right?
Paul Brett wrote:
It would be a rare event but not completly unexpected. After all, perf
can
On Aug. 24, 2015, 5:53 p.m., Cong Wang wrote:
src/linux/perf.cpp, line 418
https://reviews.apache.org/r/37416/diff/5/?file=1045148#file1045148line418
This is not expected, right?
It would be a rare event but not completly unexpected. After all, perf can be
upgraded while mesos is
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37416/
---
(Updated Aug. 21, 2015, 6:46 p.m.)
Review request for mesos and Ben Mahler.
On Aug. 19, 2015, 1:42 a.m., Ben Mahler wrote:
src/linux/perf.cpp, lines 474-478
https://reviews.apache.org/r/37416/diff/3/?file=1043975#file1043975line474
Why `_supported` here that takes a version? Why not just have supported
compute the version and then perform the necessary
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37416/
---
(Updated Aug. 20, 2015, 4:39 p.m.)
Review request for mesos and Ben Mahler.
On Aug. 19, 2015, 1:42 a.m., Ben Mahler wrote:
src/linux/perf.cpp, lines 484-490
https://reviews.apache.org/r/37416/diff/3/?file=1043975#file1043975line484
Couple of things:
(1) Let's add a comment as to why we're using await here, since it is
an anti-pattern.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37416/
---
(Updated Aug. 19, 2015, 10:18 p.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37416/
---
(Updated Aug. 20, 2015, 1:13 a.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37416/#review95779
---
Just some notes before you rebase.
src/linux/perf.cpp (lines 411
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37416/
---
(Updated Aug. 19, 2015, 12:57 a.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37416/#review95809
---
src/linux/perf.cpp (lines 384 - 385)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37416/
---
(Updated Aug. 13, 2015, 6:40 p.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37416/#review95231
---
Patch looks great!
Reviews applied: [37423, 37424, 37417, 37416]
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37416/
---
Review request for mesos and Ben Mahler.
Repository: mesos
Description
20 matches
Mail list logo
