Re: Review Request 37585: Maintenance primitives: Add a user doc.

2015-09-20 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37585/#review99711 --- Ship it! fixed inline. docs/maintenance.md (lines 139 - 140)

Re: Review Request 37585: Maintenance primitives: Add a user doc.

2015-09-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37585/#review99656 --- Bad patch! Reviews applied: [37585] Failed command: ./support/appl

Re: Review Request 37585: Maintenance primitives: Add a user doc.

2015-09-18 Thread Joseph Wu
> On Sept. 18, 2015, 5:52 p.m., Artem Harutyunyan wrote: > > docs/maintenance.md, line 27 > > > > > > Did the notion of an operator not exist before Maintenance Primitives > > were introduced? I would rephrase the s

Re: Review Request 37585: Maintenance primitives: Add a user doc.

2015-09-18 Thread Joseph Wu
> On Sept. 18, 2015, 5:52 p.m., Artem Harutyunyan wrote: > > docs/maintenance.md, lines 72-73 > > > > > > Please add anchors to links so that the relevant parts of the .proto > > file in each case are highlighted.

Re: Review Request 37585: Maintenance primitives: Add a user doc.

2015-09-18 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37585/ --- (Updated Sept. 18, 2015, 6:27 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37585: Maintenance primitives: Add a user doc.

2015-09-18 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37585/#review99635 --- docs/maintenance.md (line 25)

Re: Review Request 37585: Maintenance primitives: Add a user doc.

2015-09-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37585/#review99596 --- Patch looks great! Reviews applied: [37585] All tests passed. - M

Re: Review Request 37585: Maintenance primitives: Add a user doc.

2015-09-18 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37585/ --- (Updated Sept. 18, 2015, 12:51 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 37585: Maintenance primitives: Add a user doc.

2015-09-14 Thread Joseph Wu
> On Sept. 12, 2015, 6:59 p.m., Artem Harutyunyan wrote: > > docs/maintenance.md, lines 68-72 > > > > > > Did not we describe this already? True. The intention was to reword the documentation in the protobufs. But

Re: Review Request 37585: Maintenance primitives: Add a user doc.

2015-09-14 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37585/ --- (Updated Sept. 14, 2015, 2:32 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37585: Maintenance primitives: Add a user doc.

2015-09-14 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37585/ --- (Updated Sept. 14, 2015, 2:32 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37585: Maintenance primitives: Add a user doc.

2015-09-12 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37585/#review98703 --- docs/maintenance.md (line 9)

Re: Review Request 37585: Maintenance primitives: Add a user doc.

2015-09-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37585/#review97317 --- Patch looks great! Reviews applied: [37585] All tests passed. - M

Re: Review Request 37585: Maintenance primitives: Add a user doc.

2015-09-01 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37585/ --- (Updated Sept. 1, 2015, 10:42 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37585: Maintenance primitives: Add a user doc.

2015-08-31 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37585/#review97128 --- Patch looks great! Reviews applied: [37585] All tests passed. - M

Re: Review Request 37585: Maintenance primitives: Add a user doc.

2015-08-31 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37585/ --- (Updated Aug. 31, 2015, 11:11 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37585: Maintenance primitives: Add a user doc.

2015-08-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37585/#review96520 --- Patch looks great! Reviews applied: [37585] All tests passed. - M

Re: Review Request 37585: Maintenance primitives: Add a user doc.

2015-08-26 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37585/#review96509 --- docs/maintenance.md (line 147)

Re: Review Request 37585: Maintenance primitives: Add a user doc.

2015-08-24 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37585/ --- (Updated Aug. 24, 2015, 5:59 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37585: Maintenance primitives: Add a user doc.

2015-08-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37585/#review96251 --- Bad patch! Reviews applied: [37585] Failed command: ./support/appl

Re: Review Request 37585: Maintenance primitives: Add a user doc.

2015-08-24 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37585/ --- (Updated Aug. 24, 2015, 2:14 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37585: Maintenance primitives: Add a user doc.

2015-08-24 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37585/ --- (Updated Aug. 24, 2015, 12:03 p.m.) Review request for mesos, Benjamin Hindman,