Re: Review Request 38165: MESOS-3377 - Adding CONTAINER_NAME as additional env variable

2015-09-08 Thread Wojciech Sielski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38165/ --- (Updated Sept. 8, 2015, 7:46 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 38165: MESOS-3377 - Adding CONTAINER_NAME as additional env variable

2015-09-08 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38165/#review98050 --- src/docker/docker.cpp (line 414)

Re: Review Request 38165: MESOS-3377 - Adding CONTAINER_NAME as additional env variable

2015-09-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38165/#review98063 --- Patch looks great! Reviews applied: [38165] All tests passed. -

Re: Review Request 38165: MESOS-3377 - Adding CONTAINER_NAME as additional env variable

2015-09-08 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38165/#review98091 --- Ship it! Ship It! - Timothy Chen On Sept. 8, 2015, 7:46 p.m.,

Re: Review Request 38165: MESOS-3377 - Adding CONTAINER_NAME as additional env variable

2015-09-08 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38165/#review98093 --- Ship it! Ship It! - Guangya Liu On 九月 8, 2015, 7:46 p.m.,

Re: Review Request 38165: MESOS-3377 - Adding CONTAINER_NAME as additional env variable

2015-09-08 Thread Wojciech Sielski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38165/#review98008 --- Ship it! Ship It! - Wojciech Sielski On Sept. 7, 2015, 6:47

Re: Review Request 38165: MESOS-3377 - Adding CONTAINER_NAME as additional env variable

2015-09-08 Thread haosdent huang
> On Sept. 8, 2015, 2:57 p.m., Wojciech Sielski wrote: > > Ship It! Hi, @sielaq Could you add @tnachen in reviewers? Because he is the maintainer of docker container component, I think he could help decide this approach should be accepted or not. And then help you commit this if this is

Re: Review Request 38165: MESOS-3377 - Adding CONTAINER_NAME as additional env variable

2015-09-07 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38165/#review97950 --- src/docker/docker.cpp (line 414)

Re: Review Request 38165: MESOS-3377 - Adding CONTAINER_NAME as additional env variable

2015-09-07 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38165/#review97947 --- Ship it! Ship It! - Guangya Liu On 九月 7, 2015, 6:47 p.m.,

Re: Review Request 38165: MESOS-3377 - Adding CONTAINER_NAME as additional env variable

2015-09-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38165/#review97942 --- Patch looks great! Reviews applied: [38165] All tests passed. -

Re: Review Request 38165: MESOS-3377 - Adding CONTAINER_NAME as additional env variable

2015-09-07 Thread Wojciech Sielski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38165/ --- (Updated Sept. 7, 2015, 6:47 p.m.) Review request for mesos. Bugs:

Re: Review Request 38165: MESOS-3377 - Adding CONTAINER_NAME as additional env variable

2015-09-07 Thread Wojciech Sielski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38165/ --- (Updated Sept. 7, 2015, 6:46 p.m.) Review request for mesos. Changes ---