Re: Review Request 38878: Added test for the Subscribe->Subscribed workflow for the Executor HTTP API

2015-12-04 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38878/#review109051 --- Ship it! Ship It! - Vinod Kone On Dec. 4, 2015, 7:02 p.m., Anan

Re: Review Request 38878: Added test for the Subscribe->Subscribed workflow for the Executor HTTP API

2015-12-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38878/#review109027 --- Patch looks great! Reviews applied: [39569, 38874, 38875, 38876, 3

Re: Review Request 38878: Added test for the Subscribe->Subscribed workflow for the Executor HTTP API

2015-12-04 Thread Anand Mazumdar
> On Dec. 2, 2015, 10:29 p.m., Vinod Kone wrote: > > src/tests/executor_http_api_tests.cpp, line 757 > > > > > > Hmm. this test is a bit convoluted. you start a pid based executor > > first, wait for its update to b

Re: Review Request 38878: Added test for the Subscribe->Subscribed workflow for the Executor HTTP API

2015-12-04 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38878/ --- (Updated Dec. 4, 2015, 7:02 p.m.) Review request for mesos, Ben Mahler, Isabel

Re: Review Request 38878: Added test for the Subscribe->Subscribed workflow for the Executor HTTP API

2015-12-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38878/#review108799 --- Patch looks great! Reviews applied: [39569, 38874, 38875, 38876, 3

Re: Review Request 38878: Added test for the Subscribe->Subscribed workflow for the Executor HTTP API

2015-12-02 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38878/ --- (Updated Dec. 3, 2015, 6:48 a.m.) Review request for mesos, Ben Mahler, Isabel

Re: Review Request 38878: Added test for the Subscribe->Subscribed workflow for the Executor HTTP API

2015-12-02 Thread Anand Mazumdar
> On Dec. 2, 2015, 10:29 p.m., Vinod Kone wrote: > > src/tests/executor_http_api_tests.cpp, line 757 > > > > > > Hmm. this test is a bit convoluted. you start a pid based executor > > first, wait for its update to b

Re: Review Request 38878: Added test for the Subscribe->Subscribed workflow for the Executor HTTP API

2015-12-02 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38878/#review108731 --- src/tests/executor_http_api_tests.cpp (line 749)

Re: Review Request 38878: Added test for the Subscribe->Subscribed workflow for the Executor HTTP API

2015-11-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38878/#review108281 --- Patch looks great! Reviews applied: [39569, 38874, 38875, 38876, 3

Re: Review Request 38878: Added test for the Subscribe->Subscribed workflow for the Executor HTTP API

2015-11-29 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38878/ --- (Updated Nov. 30, 2015, 3:56 a.m.) Review request for mesos, Ben Mahler, Isabel

Re: Review Request 38878: Added test for the Subscribe->Subscribed workflow for the Executor HTTP API

2015-10-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38878/#review103906 --- Patch looks great! Reviews applied: [39569, 38874, 38875, 39297, 3

Re: Review Request 38878: Added test for the Subscribe->Subscribed workflow for the Executor HTTP API

2015-10-24 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38878/ --- (Updated Oct. 24, 2015, 7 p.m.) Review request for mesos, Ben Mahler, Isabel Ji

Re: Review Request 38878: Added test for the Subscribe->Subscribed workflow for the Executor HTTP API

2015-09-29 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38878/#review101082 --- Ship it! Ship It! - Guangya Liu On 九月 30, 2015, 3:40 a.m., Anan

Re: Review Request 38878: Added test for the Subscribe->Subscribed workflow for the Executor HTTP API

2015-09-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38878/#review101075 --- Patch looks great! Reviews applied: [38873, 38874, 38875, 38876, 3

Review Request 38878: Added test for the Subscribe->Subscribed workflow for the Executor HTTP API

2015-09-29 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38878/ --- Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone. Bugs: MES