Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38950/ --- (Updated Jan. 7, 2016, 11:27 a.m.) Review request for mesos, Adam B, Bernd Math

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38950/ --- (Updated Jan. 6, 2016, 2:43 p.m.) Review request for mesos, Adam B, Bernd Mathi

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38950/#review113061 --- Ship it! This looks great Alexander - almost perfect :) ! src/ma

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38950/ --- (Updated Jan. 5, 2016, 5:17 p.m.) Review request for mesos, Adam B, Bernd Mathi

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38950/#review112810 --- Ship it! Ship It! - Bernd Mathiske On Jan. 5, 2016, 2:34 a.m.,

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38950/ --- (Updated Jan. 5, 2016, 11:34 a.m.) Review request for mesos, Adam B, Bernd Math

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38950/#review112808 --- src/examples/test_http_authenticator_module.cpp (line 35)

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38950/ --- (Updated Jan. 5, 2016, 10:39 a.m.) Review request for mesos, Adam B, Bernd Math

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38950/ --- (Updated Jan. 5, 2016, 10:23 a.m.) Review request for mesos, Adam B, Bernd Math

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38950/ --- (Updated Jan. 4, 2016, 1:58 p.m.) Review request for mesos, Adam B, Bernd Mathi

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38950/ --- (Updated Dec. 14, 2015, 3:45 p.m.) Review request for mesos, Adam B, Bernd Math

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38950/#review110216 --- include/mesos/authentication/http/basic_authenticator_factory.hpp

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38950/#review109153 --- src/examples/test_http_authenticator_module.cpp (lines 49 - 50)

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38950/ --- (Updated Dec. 10, 2015, 3:32 p.m.) Review request for mesos, Adam B, Bernd Math

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38950/ --- (Updated Dec. 8, 2015, 11:24 a.m.) Review request for mesos, Adam B, Bernd Math

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38950/ --- (Updated Dec. 7, 2015, 3:21 p.m.) Review request for mesos, Adam B, Bernd Mathi

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38950/ --- (Updated Dec. 7, 2015, 2:33 p.m.) Review request for mesos, Adam B, Bernd Mathi

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38950/ --- (Updated Nov. 17, 2015, 2:37 p.m.) Review request for mesos, Adam B, Bernd Math

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38950/ --- (Updated Nov. 16, 2015, 5:28 p.m.) Review request for mesos, Adam B, Bernd Math

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38950/ --- (Updated Nov. 16, 2015, 11:08 a.m.) Review request for mesos, Adam B, Bernd Mat

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38950/ --- (Updated Nov. 16, 2015, 11:01 a.m.) Review request for mesos, Adam B, Bernd Mat

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38950/ --- (Updated Nov. 10, 2015, 5:02 a.m.) Review request for mesos, Adam B, Bernd Math

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38950/ --- (Updated Nov. 9, 2015, 11:38 p.m.) Review request for mesos, Adam B, Bernd Math

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38950/ --- (Updated Nov. 4, 2015, 1:20 p.m.) Review request for mesos, Adam B, Bernd Mathi

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

> On Oct. 12, 2015, 1:59 p.m., Guangya Liu wrote: > > include/mesos/authentication/http/basic_authenticator_factory.hpp, line 33 > > > > > > virtual It is not virtual because the class is not supposed to be inherited

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38950/ --- (Updated Oct. 21, 2015, 3:12 p.m.) Review request for mesos, Adam B, Bernd Math

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38950/ --- (Updated Oct. 20, 2015, 12:25 p.m.) Review request for mesos, Adam B, Bernd Mat

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38950/#review102238 --- include/mesos/authentication/http/basic_authenticator_factory.hpp

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

> On Oct. 10, 2015, 12:10 p.m., Alex Clemmer wrote: > > src/Makefile.am, line 463 > > > > > > (I hesistate to comment this time, but...) could we add this to the > > `CMakeLists.txt` file in `src/`? (It looks to be

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38950/ --- (Updated Oct. 12, 2015, 11:30 a.m.) Review request for mesos, Adam B, Bernd Mat

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38950/#review102160 --- src/Makefile.am (line 463)

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38950/#review101632 --- Patch looks great! Reviews applied: [37714, 37996, 37997, 37998, 3

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38950/ --- (Updated Oct. 6, 2015, 10:52 a.m.) Review request for mesos, Adam B, Bernd Math

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38950/#review101310 --- Patch looks great! Reviews applied: [37714, 37996, 37997, 37998, 3

Review Request 38950: Http Authenticators can be loaded as modules from mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38950/ --- Review request for mesos, Adam B, Bernd Mathiske, and Till Toenshoff. Bugs: MES