Re: Review Request 39217: Windows: Added `stout/os/chsize.hpp`.

2015-10-16 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39217/#review102948 --- Ship it! Can you also update the summary/description of this

Re: Review Request 39217: Windows: Added `stout/os/chsize.hpp`.

2015-10-16 Thread Alex Clemmer
> On Oct. 16, 2015, 5:51 p.m., Joseph Wu wrote: > > Can you also update the summary/description of this review? > > (s/chsize/ftruncate/) Good idea. I'll update it to use the commit message currently on the review. - Alex --- This is

Re: Review Request 39217: Windows: Added `stout/os/chsize.hpp`.

2015-10-15 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39217/#review102822 ---

Re: Review Request 39217: Windows: Added `stout/os/chsize.hpp`.

2015-10-15 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39217/ --- (Updated Oct. 15, 2015, 8:36 p.m.) Review request for mesos, Artem

Re: Review Request 39217: Windows: Added `stout/os/chsize.hpp`.

2015-10-15 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39217/ --- (Updated Oct. 15, 2015, 8:33 p.m.) Review request for mesos, Artem

Re: Review Request 39217: Windows: Added `stout/os/chsize.hpp`.

2015-10-15 Thread Alex Clemmer
> On Oct. 15, 2015, 8:58 p.m., James Peach wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/ftruncate.hpp, > > line 30 > > > > > > Should this be ```_chsize_s``` so you can use a large offset?

Re: Review Request 39217: Windows: Added `stout/os/chsize.hpp`.

2015-10-15 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39217/ --- (Updated Oct. 16, 2015, 4:45 a.m.) Review request for mesos, Artem

Re: Review Request 39217: Windows: Added `stout/os/chsize.hpp`.

2015-10-13 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39217/#review102343 --- 3rdparty/libprocess/3rdparty/stout/include/Makefile.am (line 67)

Re: Review Request 39217: Windows: Added `stout/os/chsize.hpp`.

2015-10-13 Thread Alex Clemmer
> On Oct. 13, 2015, 7:38 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/chsize.hpp, lines > > 24-25 > > > > > > This doc says that `ftruncate` needs an open fd too: > >

Re: Review Request 39217: Windows: Added `stout/os/chsize.hpp`.

2015-10-13 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39217/ --- (Updated Oct. 13, 2015, 6:35 p.m.) Review request for mesos, Artem

Review Request 39217: Windows: Added `stout/os/chsize.hpp`.

2015-10-12 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39217/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph