Re: Review Request 39365: HTTP Scheduler should abort when MasterDetector create fails.

2015-10-16 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39365/#review102995 --- Ship it! It's unfortunate to do EXITs for bad user inputs in a

Re: Review Request 39365: HTTP Scheduler should abort when MasterDetector create fails.

2015-10-15 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39365/ --- (Updated Oct. 15, 2015, 5:03 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 39365: HTTP Scheduler should abort when MasterDetector create fails.

2015-10-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39365/#review102860 --- Patch looks great! Reviews applied: [39365] All tests passed. -

Re: Review Request 39365: HTTP Scheduler should abort when MasterDetector create fails.

2015-10-15 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39365/#review102856 --- Ship it! Ship It! - Guangya Liu On 十月 16, 2015, 12:30 a.m.,

Re: Review Request 39365: HTTP Scheduler should abort when MasterDetector create fails.

2015-10-15 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39365/#review102837 --- Ship it! LGTM - Anand Mazumdar On Oct. 16, 2015, 12:03 a.m.,

Re: Review Request 39365: HTTP Scheduler should abort when MasterDetector create fails.

2015-10-15 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39365/ --- (Updated Oct. 15, 2015, 5:30 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 39365: HTTP Scheduler should abort when MasterDetector create fails.

2015-10-15 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39365/#review102841 --- src/scheduler/scheduler.cpp (line 170)

Re: Review Request 39365: HTTP Scheduler should abort when MasterDetector create fails.

2015-10-15 Thread Joseph Wu
> On Oct. 15, 2015, 5:13 p.m., Vinod Kone wrote: > > src/scheduler/scheduler.cpp, line 170 > > > > > > For posterity, can you add a blurb in the review on what the exact > > issue is? > > > > Also, are the