Re: Review Request 39386: Fix uncorrect launcher dir in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39386/#review103255 --- Ship it! Ship It! - Timothy Chen On Oct. 19, 2015, 2:59 a.m.,

Re: Review Request 39386: Fix uncorrect launcher dir in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39386/#review103090 --- Patch looks great! Reviews applied: [39386] All tests passed. -

Re: Review Request 39386: Fix uncorrect launcher dir in docker executor.

> On Oct. 16, 2015, 11:34 p.m., Niklas Nielsen wrote: > > src/docker/executor.cpp, line 581 > > > > > > What happens when you remove this fallback, taken a user don't provide > > the launcher dir? Hi, @nnielsen.

Re: Review Request 39386: Fix uncorrect launcher dir in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39386/ --- (Updated Oct. 19, 2015, 2:59 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 39386: Fix uncorrect launcher dir in docker executor.

> On Oct. 16, 2015, 5:30 p.m., Marco Massenzio wrote: > > Thanks for doing this. > > > > I think you will need to document the flags' usage in `configuration.md` > > (or wherever appropriate) and state clearly that it's **required** and what > > it should point to (in other words, what

Re: Review Request 39386: Fix uncorrect launcher dir in docker executor.

> On Oct. 16, 2015, 5:30 p.m., Marco Massenzio wrote: > > Thanks for doing this. > > > > I think you will need to document the flags' usage in `configuration.md` > > (or wherever appropriate) and state clearly that it's **required** and what > > it should point to (in other words, what

Re: Review Request 39386: Fix uncorrect launcher dir in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39386/#review103005 --- src/docker/executor.cpp

Re: Review Request 39386: Fix uncorrect launcher dir in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39386/#review102939 --- Ship it! Thanks for doing this. I think you will need to

Review Request 39386: Fix uncorrect launcher dir in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39386/ --- Review request for mesos and Timothy Chen. Bugs: MESOS-3738