Re: Review Request 39707: Minor code refactor for fetcher.cpp.

2015-11-04 Thread Vinod Kone
> On Nov. 4, 2015, 11:30 a.m., Bernd Mathiske wrote: > > src/launcher/fetcher.cpp, line 297 > > > > > > Or, avoiding a string constant: > > > > CHECK_FALSE(item.cache_filename().empty()); i don't see a

Re: Review Request 39707: Minor code refactor for fetcher.cpp.

2015-11-04 Thread Bernd Mathiske
> On Nov. 4, 2015, 3:30 a.m., Bernd Mathiske wrote: > > src/launcher/fetcher.cpp, line 297 > > > > > > Or, avoiding a string constant: > > > > CHECK_FALSE(item.cache_filename().empty()); > > Vinod Kone

Re: Review Request 39707: Minor code refactor for fetcher.cpp.

2015-11-04 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39707/#review105104 --- Ship it! Ship It! - Bernd Mathiske On Oct. 27, 2015, 6:45

Review Request 39707: Minor code refactor for fetcher.cpp.

2015-10-27 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39707/ --- Review request for mesos, Bernd Mathiske and Jie Yu. Repository: mesos

Re: Review Request 39707: Minor code refactor for fetcher.cpp.

2015-10-27 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39707/#review104243 --- Patch looks great! Reviews applied: [39707] All tests passed. -