Re: Review Request 39802: Windows: Implemented `stout/os/windows/ls.hpp`.

2016-01-13 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39802/#review114290 --- Ship it! Ship It! - Joris Van Remoortere On Jan. 12, 2016,

Re: Review Request 39802: Windows: Implemented `stout/os/windows/ls.hpp`.

2016-01-11 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39802/ --- (Updated Jan. 12, 2016, 12:46 a.m.) Review request for mesos, Artem

Re: Review Request 39802: Windows: Implemented `stout/os/windows/ls.hpp`.

2016-01-11 Thread Joris Van Remoortere
> On Jan. 11, 2016, 12:38 a.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/ls.hpp, lines > > 36-42 > > > > > > If this is the only section that is different between

Re: Review Request 39802: Windows: Implemented `stout/os/windows/ls.hpp`.

2016-01-11 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39802/ --- (Updated Jan. 12, 2016, 12:40 a.m.) Review request for mesos, Artem

Re: Review Request 39802: Windows: Implemented `stout/os/windows/ls.hpp`.

2016-01-11 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39802/ --- (Updated Jan. 12, 2016, 12:39 a.m.) Review request for mesos, Artem

Re: Review Request 39802: Windows: Implemented `stout/os/windows/ls.hpp`.

2016-01-11 Thread Alex Clemmer
> On Jan. 9, 2016, 1:05 a.m., Yi Sun wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/ls.hpp, line 55 > > > > > > So the entry is always pointing to the allocated memory when success. Following

Re: Review Request 39802: Windows: Implemented `stout/os/windows/ls.hpp`.

2016-01-11 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39802/ --- (Updated Jan. 11, 2016, 11:59 a.m.) Review request for mesos, Artem

Re: Review Request 39802: Windows: Implemented `stout/os/windows/ls.hpp`.

2016-01-11 Thread Alex Clemmer
> On Jan. 11, 2016, 12:38 a.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/ls.hpp, lines > > 36-42 > > > > > > If this is the only section that is different between

Re: Review Request 39802: Windows: Implemented `stout/os/windows/ls.hpp`.

2016-01-10 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39802/#review113580 --- 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/ls.hpp

Re: Review Request 39802: Windows: Implemented `stout/os/windows/ls.hpp`.

2016-01-08 Thread Yi Sun
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39802/#review113581 --- Ship it! Ship It!

Re: Review Request 39802: Windows: Implemented `stout/os/windows/ls.hpp`.

2016-01-04 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39802/#review112619 --- Ship it! Ship It! - Alex Naparu On Jan. 4, 2016, 11:20 a.m.,

Re: Review Request 39802: Windows: Implemented `stout/os/windows/ls.hpp`.

2016-01-04 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39802/ --- (Updated Jan. 4, 2016, 11:18 a.m.) Review request for mesos, Artem

Re: Review Request 39802: Windows: Implemented `stout/os/windows/ls.hpp`.

2016-01-04 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39802/ --- (Updated Jan. 4, 2016, 11:20 a.m.) Review request for mesos, Artem

Re: Review Request 39802: Windows: Implemented `stout/os/windows/ls.hpp`.

2015-11-17 Thread Alex Clemmer
> On Nov. 2, 2015, 10:02 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/ls.hpp, lines > > 66-69 > > > > > > This seems weird. `readdir_r`, per your implementation, only

Re: Review Request 39802: Windows: Implemented `stout/os/windows/ls.hpp`.

2015-11-17 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39802/ --- (Updated Nov. 17, 2015, 7:02 p.m.) Review request for mesos, Artem

Re: Review Request 39802: Windows: Implemented `stout/os/windows/ls.hpp`.

2015-11-16 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39802/ --- (Updated Nov. 16, 2015, 9:14 a.m.) Review request for mesos, Artem

Re: Review Request 39802: Windows: Implemented `stout/os/windows/ls.hpp`.

2015-11-02 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39802/#review104806 ---

Re: Review Request 39802: Windows: Implemented `stout/os/windows/ls.hpp`.

2015-10-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39802/#review104534 --- Patch looks great! Reviews applied: [39537, 39538, 39539, 39540,

Review Request 39802: Windows: Implemented `stout/os/windows/ls.hpp`.

2015-10-30 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39802/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph