Review Request 40056: Make hook execution order deterministic.

2015-11-08 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40056/ --- Review request for mesos, Ben Mahler and Kapil Arya. Bugs: MESOS-3485 https

Re: Review Request 40056: Make hook execution order deterministic.

2015-11-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40056/#review105612 --- Bad patch! Reviews applied: [40056] Failed command: ./support/app

Re: Review Request 40056: Make hook execution order deterministic.

2015-12-04 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40056/#review109028 --- Hi Haosdent! I apologize the tardy reply. The patch looks good but

Re: Review Request 40056: Make hook execution order deterministic.

2015-12-06 Thread Guangya Liu
> On 十二月 4, 2015, 9:15 p.m., Niklas Nielsen wrote: > > Hi Haosdent! > > > > I apologize the tardy reply. The patch looks good but needs rebasing. > > Also, have you thought of a way to test this? > > > > With a test (maybe by just ensuring the existing ordering of the test > > modules are inde

Re: Review Request 40056: Make hook execution order deterministic.

2015-12-07 Thread Niklas Nielsen
> On Dec. 4, 2015, 1:15 p.m., Niklas Nielsen wrote: > > Hi Haosdent! > > > > I apologize the tardy reply. The patch looks good but needs rebasing. > > Also, have you thought of a way to test this? > > > > With a test (maybe by just ensuring the existing ordering of the test > > modules are ind

Re: Review Request 40056: Make hook execution order deterministic.

2015-12-09 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40056/ --- (Updated Dec. 9, 2015, 5:25 p.m.) Review request for mesos, Ben Mahler, Kapil A

Re: Review Request 40056: Make hook execution order deterministic.

2015-12-09 Thread haosdent huang
> On Dec. 4, 2015, 9:15 p.m., Niklas Nielsen wrote: > > Hi Haosdent! > > > > I apologize the tardy reply. The patch looks good but needs rebasing. > > Also, have you thought of a way to test this? > > > > With a test (maybe by just ensuring the existing ordering of the test > > modules are ind

Re: Review Request 40056: Make hook execution order deterministic.

2015-12-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40056/#review109586 --- Patch looks great! Reviews applied: [40056] Passed command: expor

Re: Review Request 40056: Make hook execution order deterministic.

2015-12-09 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40056/#review109651 --- Ship it! Ship It! - Guangya Liu On 十二月 9, 2015, 5:25 p.m., haos