Review Request 40403: Added streaming and construction methods for URI.

2015-11-17 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40403/ --- Review request for mesos, Ben Mahler and Vinod Kone. Repository: mesos Descri

Re: Review Request 40403: Added streaming and construction methods for URI.

2015-11-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40403/#review106961 --- Patch looks great! Reviews applied: [40250, 40251, 40252, 40274, 4

Re: Review Request 40403: Added streaming and construction methods for URI.

2015-11-18 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40403/#review107074 --- Ship it! src/uri/schemes/http.hpp (line 38)

Re: Review Request 40403: Added streaming and construction methods for URI.

2015-11-18 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40403/ --- (Updated Nov. 18, 2015, 11:25 p.m.) Review request for mesos, Ben Mahler and Vi

Re: Review Request 40403: Added streaming and construction methods for URI.

2015-11-20 Thread Jie Yu
> On Nov. 18, 2015, 7:54 p.m., Vinod Kone wrote: > > src/uri/schemes/http.hpp, line 38 > > > > > > consider merging `uri/schemes/*` and `src/uri/utils.cpp` into a single > > `src/uri.cpp` file. I thought about that