Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40632/ --- (Updated 三月 14, 2016, 4:03 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40632/ --- (Updated 三月 11, 2016, 9:10 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40632/ --- (Updated 二月 29, 2016, 7:04 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40632/#review116776 --- src/master/allocator/mesos/hierarchical.cpp (lines 1333 - 1335)

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40632/ --- (Updated 一月 23, 2016, 3:18 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

> On 一月 16, 2016, 2:11 a.m., Joseph Wu wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1291-1319 > > > > > > None of this should be necessary: > > > > 1) You should have all the allocation

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

> On Jan. 15, 2016, 6:11 p.m., Joseph Wu wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1291-1319 > > > > > > None of this should be necessary: > > > > 1) You should have all the allocation

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40632/ --- (Updated 一月 19, 2016, 8:03 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40632/#review115263 --- src/tests/hierarchical_allocator_tests.cpp (lines 1918 - 1919)

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

> On Jan. 15, 2016, 6:11 p.m., Joseph Wu wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1291-1319 > > > > > > None of this should be necessary: > > > > 1) You should have all the allocation

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

> On 十二月 30, 2015, 12:42 p.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1321 > > > > > > As framework can not use ALLOCATION_SLACK mixed with other resources, > > allocator need to

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

> On 一月 16, 2016, 2:11 a.m., Joseph Wu wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1291-1319 > > > > > > None of this should be necessary: > > > > 1) You should have all the allocation

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

> On 一月 19, 2016, 11:09 p.m., Joseph Wu wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 1995-1997 > > > > > > Consider moving this test to after you've implemented optimistic offers > > for

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

> On 一月 16, 2016, 2:11 a.m., Joseph Wu wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 993 > > > > > > Can you pull this out into an entirely separate (not part of this > > review chain) review? > >

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

> On 十二月 30, 2015, 12:42 p.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1321 > > > > > > As framework can not use ALLOCATION_SLACK mixed with other resources, > > allocator need to

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

> On Jan. 7, 2016, 12:22 p.m., Joseph Wu wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1305-1313 > > > > > > If you make the changes above, this recalculation will be unnecessary. > >

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40632/#review114831 --- src/master/allocator/mesos/hierarchical.cpp (lines 1291 - 1319)

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40632/ --- (Updated 一月 16, 2016, 7:38 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40632/ --- (Updated 一月 16, 2016, 7:51 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40632/ --- (Updated 一月 13, 2016, 12:39 p.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40632/ --- (Updated 一月 13, 2016, 2:24 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

> On Dec. 30, 2015, 8:42 p.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1302 > > > > > > If framework has reserved.statless resources, allocator should not > > dispatch it as

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

> On 十二月 30, 2015, 12:42 p.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1302 > > > > > > If framework has reserved.statless resources, allocator should not > > dispatch it as

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

> On Dec. 30, 2015, 8:42 p.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1302 > > > > > > If framework has reserved.statless resources, allocator should not > > dispatch it as

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

> On Dec. 30, 2015, 4:42 a.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1302 > > > > > > If framework has reserved.statless resources, allocator should not > > dispatch it as

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

> On Dec. 30, 2015, 8:42 p.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1302 > > > > > > If framework has reserved.statless resources, allocator should not > > dispatch it as

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

> On Dec. 30, 2015, 8:42 p.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1321 > > > > > > As framework can not use ALLOCATION_SLACK mixed with other resources, > > allocator need to

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

> On Dec. 30, 2015, 4:42 a.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1334 > > > > > > In this check, it seems allocator send offer when both !allocation & > > allocation are enough.

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

> On 十二月 30, 2015, 12:42 p.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1334 > > > > > > In this check, it seems allocator send offer when both !allocation & > > allocation are enough.

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40632/#review113240 --- src/master/allocator/mesos/hierarchical.cpp (line 1379)

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

> On 十二月 30, 2015, 12:42 p.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1334 > > > > > > In this check, it seems allocator send offer when both !allocation & > > allocation are enough.

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

> On 一月 7, 2016, 11:51 a.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1379 > > > > > > Add `allocation slack resource` if any `resources.unreserved()` already include allocation

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

> On 一月 7, 2016, 8:22 p.m., Joseph Wu wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 438-443 > > > > > > Resources can be dynamically reserved, so ideally, you should > > recalculating the

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40632/ --- (Updated 一月 8, 2016, 2:34 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40632/ --- (Updated 一月 8, 2016, 6:55 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40632/#review113303 --- I haven't taken a close look at the tests yet. However, it may

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

> On Dec. 30, 2015, 4:42 a.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1321 > > > > > > As framework can not use ALLOCATION_SLACK mixed with other resources, > > allocator need to

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

> On Jan. 7, 2016, 12:22 p.m., Joseph Wu wrote: > > I haven't taken a close look at the tests yet. However, it may benefit you > > to add tests (preferably in separate reviews) for: > > > > + Dynamic reservations + optimistic offers. Make sure the new reservations > > show up as allocation

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40632/ --- (Updated 一月 3, 2016, 9:21 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

> On Dec. 14, 2015, 10:14 a.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 431 > > > > > > Honestly, I'd like to separate optimistic resources into other counter > > in allocator; it's a

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40632/ --- (Updated Dec. 14, 2015, 6:41 a.m.) Review request for mesos, Artem