Re: Review Request 41169: Logger Module: Update tests that use the MesosContainerizer to pass in an ContainerLogger

2015-12-21 Thread Joseph Wu
> On Dec. 20, 2015, 3:01 p.m., Benjamin Hindman wrote: > > This looks fine, assuming that we actually need `CreateContainerLogger` > > (see below). > > Benjamin Hindman wrote: > I looked ahead in the review chain and it doesn't look like you ever > extend `CreateContainerLogger`, so why

Re: Review Request 41169: Logger Module: Update tests that use the MesosContainerizer to pass in an ContainerLogger

2015-12-21 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41169/ --- (Updated Dec. 21, 2015, 11:37 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 41169: Logger Module: Update tests that use the MesosContainerizer to pass in an ContainerLogger

2015-12-20 Thread Benjamin Hindman
> On Dec. 20, 2015, 11:01 p.m., Benjamin Hindman wrote: > > This looks fine, assuming that we actually need `CreateContainerLogger` > > (see below). I looked ahead in the review chain and it doesn't look like you ever extend `CreateContainerLogger`, so why was it necessary? Why couldn't you

Re: Review Request 41169: Logger Module: Update tests that use the MesosContainerizer to pass in an ContainerLogger

2015-12-20 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41169/#review111428 --- Ship it! This looks fine, assuming that we actually need

Re: Review Request 41169: Logger Module: Update tests that use the MesosContainerizer to pass in an ContainerLogger

2015-12-15 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41169/ --- (Updated Dec. 15, 2015, 12:40 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 41169: Logger Module: Update tests that use the MesosContainerizer to pass in an ContainerLogger

2015-12-14 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41169/ --- (Updated Dec. 14, 2015, 3:49 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 41169: Logger Module: Update tests that use the MesosContainerizer to pass in an ContainerLogger

2015-12-11 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41169/ --- (Updated Dec. 11, 2015, 4:40 p.m.) Review request for mesos, Benjamin Hindman