Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/#review123896 --- src/tests/containerizer/port_mapping_tests.cpp

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/#review123891 --- src/tests/containerizer/port_mapping_tests.cpp (line 2004)

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/#review123894 --- src/tests/containerizer/port_mapping_tests.cpp (line 2086)

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/#review123867 --- Ship it! On my machine, full test-suite remains to take about

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/#review123828 --- Patch looks great! Reviews applied: [43613, 43614, 43629, 43630,

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/ --- (Updated March 15, 2016, 5:21 p.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/ --- (Updated March 14, 2016, 2:33 p.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/ --- (Updated March 10, 2016, 1:01 p.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/#review122873 --- Patch looks great! Reviews applied: [43613, 43614, 43629, 43630,

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/ --- (Updated March 9, 2016, 1:23 p.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

> On March 8, 2016, 3:50 a.m., Bernd Mathiske wrote: > > src/tests/scheduler_event_call_tests.cpp, line 367 > > > > > > In most other places you have the blank line before the detector. True. Fixed four places

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/ --- (Updated March 8, 2016, 2:33 p.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/#review122502 --- Fix it, then Ship it!

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

> On March 4, 2016, 6:45 a.m., Bernd Mathiske wrote: > > > > Joseph Wu wrote: > I also noticed a couple of these: > ``` > MesosSchedulerDriver driver( > , DEFAULT_FRAMEWORK_INFO, master.get()->pid, > DEFAULT_CREDENTIAL); > ``` > Now fixed (there were two spaces

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/#review122186 --- Patch looks great! Reviews applied: [43613, 43614, 43629, 43630,

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

> On March 4, 2016, 6:45 a.m., Bernd Mathiske wrote: > > I also noticed a couple of these: ``` MesosSchedulerDriver driver( , DEFAULT_FRAMEWORK_INFO, master.get()->pid, DEFAULT_CREDENTIAL); ``` Now fixed (there were two spaces rather than four). --- Also went through and changed a

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/ --- (Updated March 4, 2016, 4:14 p.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/#review122072 --- src/tests/container_logger_tests.cpp (line 301)

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/#review122018 --- Bad patch! Reviews applied: [43615, 43630, 43629, 43614, 43613]

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/ --- (Updated March 3, 2016, 3:11 p.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/ --- (Updated March 3, 2016, 11:59 a.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/#review121781 --- Bad patch! Reviews applied: [43615, 43630, 43629, 43614, 43613]

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/ --- (Updated March 2, 2016, 4:05 p.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/#review121673 --- Bad patch! Reviews applied: [43615, 43630, 43629, 43614, 43613]

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/#review121657 --- LGTM so far, but let's review this again after the changes

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/ --- (Updated Feb. 29, 2016, 1:55 p.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/#review120848 --- Patch looks great! Reviews applied: [43613, 43614, 43629, 43630,

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/ --- (Updated Feb. 25, 2016, 4:41 p.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/ --- (Updated Feb. 24, 2016, 6:03 p.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/#review120430 --- Patch looks great! Reviews applied: [43613, 43614, 43629, 43630,

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/ --- (Updated Feb. 23, 2016, 11:29 a.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/#review120256 --- Bad patch! Reviews applied: [43615, 43630, 43629, 43614, 43613]

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/ --- (Updated Feb. 22, 2016, 1:33 p.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/#review120021 --- Patch looks great! Reviews applied: [43613, 43614, 43629, 43630,

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/ --- (Updated Feb. 19, 2016, 4:50 p.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/ --- (Updated Feb. 19, 2016, 3:15 p.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/#review119567 --- Patch looks great! Reviews applied: [43613, 43614, 43629, 43630,

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/ --- (Updated Feb. 17, 2016, 2:34 p.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/#review119512 --- Patch looks great! Reviews applied: [43613, 43614, 43629, 43630,

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/#review119395 --- Patch looks great! Reviews applied: [43613, 43614, 43629, 43630,

Review Request 43615: Update test suite to use the reworked MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/ --- Review request for mesos, Bernd Mathiske and Artem Harutyunyan. Bugs: