Re: Review Request 44186: Added authentication to master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44186/#review123301 --- Ship it! Ship It! - Adam B On March 11, 2016, 11:12 a.m., Jo

Re: Review Request 44186: Added authentication to master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44186/ --- (Updated March 11, 2016, 7:12 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 44186: Added authentication to master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44186/#review123182 --- Fix it, then Ship it! src/master/http.cpp (line 1279)

Re: Review Request 44186: Added authentication to master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44186/#review122914 --- Patch looks great! Reviews applied: [44286, 44186] Passed comman

Re: Review Request 44186: Added authentication to master endpoints.

> On March 10, 2016, 6:26 a.m., Adam B wrote: > > Can you add some tests for these endpoints that show that hitting them with > > a bad credential will fail with status `Unauthorized`? See > > `TeardownTest.TeardownEndpointBadCredentials` or > > `PersistentVolumeEndpointsTest.BadCredentials`.

Re: Review Request 44186: Added authentication to master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44186/ --- (Updated March 10, 2016, 10:31 a.m.) Review request for mesos, Adam B, Alexande

Re: Review Request 44186: Added authentication to master endpoints.

> On March 10, 2016, 6:26 a.m., Adam B wrote: > > src/tests/master_maintenance_tests.cpp, line 129 > > > > > > Why set this to false and then still createBasicAuthHeaders for these > > tests? > > Why can't we ke

Re: Review Request 44186: Added authentication to master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44186/#review122886 --- Can you add some tests for these endpoints that show that hitting

Re: Review Request 44186: Added authentication to master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44186/#review122013 --- Patch looks great! Reviews applied: [44286, 44186] Passed comman

Re: Review Request 44186: Added authentication to master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44186/ --- (Updated March 3, 2016, 10:21 p.m.) Review request for mesos, Adam B and Alexan

Re: Review Request 44186: Added authentication to master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44186/ --- (Updated March 3, 2016, 4:53 p.m.) Review request for mesos, Adam B and Alexand

Re: Review Request 44186: Added authentication to master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44186/#review121833 --- Bad patch! Reviews applied: [44186, 44286] Failed command: ./sup

Re: Review Request 44186: Added authentication to master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44186/#review121811 --- Ship it! Ship It! - Alexander Rojas On March 3, 2016, 8:22 a

Re: Review Request 44186: Added authentication to master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44186/ --- (Updated March 3, 2016, 7:22 a.m.) Review request for mesos, Adam B and Alexand

Re: Review Request 44186: Added authentication to master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44186/ --- (Updated March 2, 2016, 10:22 p.m.) Review request for mesos, Adam B and Alexan