Re: Review Request 44278: Added HTTP scheduler stream IDs.

2016-03-03 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44278/#review121902 --- Ship it! Ship It! - Vinod Kone On March 3, 2016, 5:13 p.m.,

Re: Review Request 44278: Added HTTP scheduler stream IDs.

2016-03-03 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44278/ --- (Updated March 3, 2016, 5:13 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 44278: Added HTTP scheduler stream IDs.

2016-03-02 Thread Anand Mazumdar
> On March 3, 2016, 1:37 a.m., Vinod Kone wrote: > > src/master/http.cpp, lines 458-462 > > > > > > should these be BadRequest as well? I think `Forbidden` is more apt here. _There is nothing wrong with the request

Re: Review Request 44278: Added HTTP scheduler stream IDs.

2016-03-02 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44278/#review121756 --- src/master/http.cpp (line 440)

Re: Review Request 44278: Added HTTP scheduler stream IDs.

2016-03-02 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44278/ --- (Updated March 2, 2016, 10:36 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 44278: Added HTTP scheduler stream IDs.

2016-03-02 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44278/#review121728 --- Looks good. Mostly comments around having explicit `CHECK`'s if

Re: Review Request 44278: Added HTTP scheduler stream IDs.

2016-03-02 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44278/ --- (Updated March 2, 2016, 8:58 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 44278: Added HTTP scheduler stream IDs.

2016-03-02 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44278/ --- (Updated March 2, 2016, 7:14 p.m.) Review request for mesos, Anand Mazumdar

Review Request 44278: Added HTTP scheduler stream IDs.

2016-03-02 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44278/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-3583