Re: Review Request 44379: Correctly parse perf stat format for non-vanilla 3.10 kernel.

2016-03-21 Thread fan du
> On 三月 17, 2016, 1:02 a.m., Ben Mahler wrote: > > src/linux/perf.cpp, lines 435-437 > > > > > > Hm.. this comment is really hard for me to understand, if OS vendors > > enhance the format, how did you know that the

Re: Review Request 44379: Correctly parse perf stat format for non-vanilla 3.10 kernel.

2016-03-20 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44379/#review123962 --- src/linux/perf.cpp (lines 435 - 437)

Re: Review Request 44379: Correctly parse perf stat format for non-vanilla 3.10 kernel.

2016-03-19 Thread Benjamin Mahler
Hey Fan, Left some comments, mostly I'm a bit confused by your comment that OS vendors can tweak the format. How did you know they only tweak it that particular way? Ben On Wed, Mar 9, 2016 at 11:53 PM, Mesos ReviewBot wrote: > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 44379: Correctly parse perf stat format for non-vanilla 3.10 kernel.

2016-03-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44379/#review122894 --- Patch looks great! Reviews applied: [44379] Passed command: expo

Re: Review Request 44379: Correctly parse perf stat format for non-vanilla 3.10 kernel.

2016-03-09 Thread fan du
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44379/ --- (Updated 三月 10, 2016, 3:24 a.m.) Review request for mesos. Changes --- R