Review Request 44474: Improve master tasks metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44474/ --- Review request for mesos, Ian Downes and Vinod Kone. Bugs: MESOS-4740 https

Re: Review Request 44474: Improve master tasks metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44474/#review122401 --- src/master/master.cpp (line 6461)

Re: Review Request 44474: Improve master tasks metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44474/#review122423 --- Please see the first comment... I think this unexpectedly introduc

Re: Review Request 44474: Improve master tasks metrics.

> On March 8, 2016, 12:37 a.m., Ian Downes wrote: > > src/master/master.cpp, line 6461 > > > > > > I'm not familiar with this code but it appears to be changing the > > behavior substantially. > > > > The

Re: Review Request 44474: Improve master tasks metrics.

> On March 8, 2016, 12:37 a.m., Ian Downes wrote: > > src/master/metrics.cpp, line 215 > > > > > > foreach? I don't think we can use foreach over enum, can we? - Cong

Re: Review Request 44474: Improve master tasks metrics.

> On March 7, 2016, 11:17 p.m., Neil Conway wrote: > > src/master/master.cpp, line 6461 > > > > > > Seems like we use post-increment elsewhere in this RR? I am not sure I understand your question, but post-incremen

Re: Review Request 44474: Improve master tasks metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44474/ --- (Updated March 9, 2016, 7:08 p.m.) Review request for mesos, Ben Mahler, Ian Do