Re: Review Request 44621: Added tests for http endpoints with bad authentication.

2016-03-10 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44621/ --- (Updated March 10, 2016, 2:40 p.m.) Review request for mesos, Adam B and Alexan

Re: Review Request 44621: Added tests for http endpoints with bad authentication.

2016-03-10 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44621/#review122922 --- Ship it! Ship It! - Alexander Rojas On March 10, 2016, 3:41

Re: Review Request 44621: Added tests for http endpoints with bad authentication.

2016-03-10 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44621/ --- (Updated March 10, 2016, 2:41 p.m.) Review request for mesos, Adam B and Alexan

Re: Review Request 44621: Added tests for http endpoints with bad authentication.

2016-03-11 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44621/#review123185 --- Fix it, then Ship it! src/tests/master_maintenance_tests.cpp (

Re: Review Request 44621: Added tests for http endpoints with bad authentication.

2016-03-11 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44621/ --- (Updated March 11, 2016, 7:49 p.m.) Review request for mesos, Adam B and Alexan

Re: Review Request 44621: Added tests for http endpoints with bad authentication.

2016-03-13 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44621/#review123302 --- Looks good. Just some minor style points to clean up, and then we

Re: Review Request 44621: Added tests for http endpoints with bad authentication.

2016-03-13 Thread Joerg Schad
> On March 13, 2016, 8:26 a.m., Adam B wrote: > > src/tests/master_maintenance_tests.cpp, line 1786 > > > > > > You can't use `badAuthnHeaders` here, because of the content-type? Yes. > On March 13, 2016, 8:26 a.

Re: Review Request 44621: Added tests for http endpoints with bad authentication.

2016-03-13 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44621/ --- (Updated March 13, 2016, 6:50 p.m.) Review request for mesos, Adam B and Alexan

Re: Review Request 44621: Added tests for http endpoints with bad authentication.

2016-03-14 Thread Adam B
> On March 13, 2016, 12:26 a.m., Adam B wrote: > > src/tests/master_tests.cpp, line 4265 > > > > > > There is no GET request allowed on /weights (yet), so it's interesting > > to me that this part of the test passe

Re: Review Request 44621: Added tests for http endpoints with bad authentication.

2016-03-14 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44621/#review123373 --- Ship it! Ship It! - Adam B On March 13, 2016, 11:50 a.m., Jo