Re: Review Request 44934: Updated mesos-execute to add support for Appc.

2016-04-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44934/#review126648 --- Patch looks great! Reviews applied: [45259, 44934] Passed comman

Re: Review Request 44934: Updated mesos-execute to add support for Appc.

2016-04-01 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44934/ --- (Updated April 1, 2016, 8:05 p.m.) Review request for mesos and Jie Yu. Chang

Re: Review Request 44934: Updated mesos-execute to add support for Appc.

2016-03-30 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44934/#review126224 --- Just FYI, this needs to be rebased as the current mesos-executor i

Re: Review Request 44934: Updated mesos-execute to add support for Appc.

2016-03-22 Thread Jojy Varghese
> On March 22, 2016, 5:10 p.m., Tom Runyon wrote: > > It would be helpful to update docs/container-image.md to include example > > appc deployments using mesos-execute. Created MESOS-5006. - Jojy --- This is an automatically generated

Re: Review Request 44934: Updated mesos-execute to add support for Appc.

2016-03-22 Thread Tom Runyon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44934/#review124834 --- It would be helpful to update docs/container-image.md to include e

Re: Review Request 44934: Updated mesos-execute to add support for Appc.

2016-03-20 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44934/#review124448 --- Ship it! Ship It! - haosdent huang On March 20, 2016, 4:19 a

Re: Review Request 44934: Updated mesos-execute to add support for Appc.

2016-03-20 Thread Guangya Liu
> On 三月 17, 2016, 7:48 a.m., Guangya Liu wrote: > > src/cli/execute.cpp, line 241 > > > > > > The default value of `containerizer` is `mesos`, do we need to check > > this? > > > > What about make the logic

Review Request 44934: Updated mesos-execute to add support for Appc.

2016-03-20 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44934/ --- Review request for mesos and Jie Yu. Repository: mesos Description --- U

Re: Review Request 44934: Updated mesos-execute to add support for Appc.

2016-03-19 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44934/ --- (Updated March 18, 2016, 5:26 p.m.) Review request for mesos and Jie Yu. Repo

Re: Review Request 44934: Updated mesos-execute to add support for Appc.

2016-03-19 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44934/ --- (Updated March 20, 2016, 4:19 a.m.) Review request for mesos and Jie Yu. Bugs

Re: Review Request 44934: Updated mesos-execute to add support for Appc.

2016-03-19 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44934/#review123991 --- src/cli/execute.cpp (line 241)

Re: Review Request 44934: Updated mesos-execute to add support for Appc.

2016-03-19 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44934/ --- (Updated March 18, 2016, 5:39 p.m.) Review request for mesos and Jie Yu. Bugs

Re: Review Request 44934: Updated mesos-execute to add support for Appc.

2016-03-19 Thread Jojy Varghese
> On March 17, 2016, 7:48 a.m., Guangya Liu wrote: > > src/cli/execute.cpp, line 241 > > > > > > The default value of `containerizer` is `mesos`, do we need to check > > this? > > > > What about make the lo

Re: Review Request 44934: Updated mesos-execute to add support for Appc.

2016-03-19 Thread Jojy Varghese
> On March 17, 2016, 7:48 a.m., Guangya Liu wrote: > > src/cli/execute.cpp, line 241 > > > > > > The default value of `containerizer` is `mesos`, do we need to check > > this? > > > > What about make the lo

Re: Review Request 44934: Updated mesos-execute to add support for Appc.

2016-03-19 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44934/#review123969 --- src/cli/execute.cpp (lines 250 - 280)

Re: Review Request 44934: Updated mesos-execute to add support for Appc.

2016-03-19 Thread Jojy Varghese
> On March 17, 2016, 7:48 a.m., Guangya Liu wrote: > > src/cli/execute.cpp, line 241 > > > > > > The default value of `containerizer` is `mesos`, do we need to check > > this? > > > > What about make the lo

Re: Review Request 44934: Updated mesos-execute to add support for Appc.

2016-03-19 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44934/ --- (Updated March 17, 2016, 6:54 a.m.) Review request for mesos and Jie Yu. Repo

Re: Review Request 44934: Updated mesos-execute to add support for Appc.

2016-03-18 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44934/#review124370 --- src/cli/execute.cpp (line 317)

Re: Review Request 44934: Updated mesos-execute to add support for Appc.

2016-03-18 Thread Jojy Varghese
> On March 17, 2016, 2:16 a.m., Guangya Liu wrote: > > src/cli/execute.cpp, lines 251-281 > > > > > > What is the behavior of this if with mesos containerizer but without a > > docker/appc image? > > > > Th