Re: Review Request 44975: Updated cgroups test cases for cgroups device support.

2016-03-28 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44975/#review125792 --- Ship it! Thanks! Kevin and I made some minor style adjustments

Re: Review Request 44975: Updated cgroups test cases for cgroups device support.

2016-03-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44975/#review124518 --- Patch looks great! Reviews applied: [44974, 44975] Passed comman

Re: Review Request 44975: Updated cgroups test cases for cgroups device support.

2016-03-20 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44975/ --- (Updated March 21, 2016, 6:14 a.m.) Review request for mesos, Ben Mahler, Felix

Review Request 44975: Updated cgroups test cases for cgroups device support.

2016-03-20 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44975/ --- Review request for mesos, Ben Mahler, Felix Abecassis, Kevin Klues, and Niklas N

Re: Review Request 44975: Updated cgroups test cases for cgroups device support.

2016-03-19 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44975/#review124104 --- src/tests/containerizer/cgroups_tests.cpp (lines 1347 - 1349)

Re: Review Request 44975: Updated cgroups test cases for cgroups device support.

2016-03-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44975/#review124110 --- Patch looks great! Reviews applied: [44974, 44975] Passed comman

Re: Review Request 44975: Updated cgroups test cases for cgroups device support.

2016-03-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44975/#review124417 --- Patch looks great! Reviews applied: [44974, 44975] Passed comman

Re: Review Request 44975: Updated cgroups test cases for cgroups device support.

2016-03-19 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44975/ --- (Updated March 18, 2016, 9:35 a.m.) Review request for mesos, Ben Mahler, Felix

Re: Review Request 44975: Updated cgroups test cases for cgroups device support.

2016-03-18 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44975/#review124375 --- I ran the review by Ben again and sat with him to rework it to his