Re: Review Request 45067: Updated the long-lived-framework example.

2016-04-06 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45067/ --- (Updated April 6, 2016, 4:19 p.m.) Review request for mesos, Greg Mann, Artem H

Re: Review Request 45067: Updated the long-lived-framework example.

2016-04-06 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45067/ --- (Updated April 6, 2016, 3:34 p.m.) Review request for mesos, Greg Mann, Artem H

Re: Review Request 45067: Updated the long-lived-framework example.

2016-04-06 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45067/#review127403 --- Fix it, then Ship it! src/examples/long_lived_framework.cpp (l

Re: Review Request 45067: Updated the long-lived-framework example.

2016-04-05 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45067/ --- (Updated April 5, 2016, 3:40 p.m.) Review request for mesos, Greg Mann, Artem H

Re: Review Request 45067: Updated the long-lived-framework example.

2016-04-05 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45067/ --- (Updated April 5, 2016, 3:33 p.m.) Review request for mesos, Greg Mann, Artem H

Re: Review Request 45067: Updated the long-lived-framework example.

2016-04-01 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45067/#review126646 --- src/examples/long_lived_framework.cpp (line 51)

Re: Review Request 45067: Updated the long-lived-framework example.

2016-03-29 Thread Joseph Wu
> On March 28, 2016, 5:31 p.m., Vinod Kone wrote: > > src/examples/long_lived_framework.cpp, line 77 > > > > > > s/. Reject/. Reject/ <-- extraneous space Oops, that's a habit (and the Apache license uses 2 spaces :)

Re: Review Request 45067: Updated the long-lived-framework example.

2016-03-29 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45067/ --- (Updated March 29, 2016, 12:08 p.m.) Review request for mesos, Greg Mann, Artem

Re: Review Request 45067: Updated the long-lived-framework example.

2016-03-28 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45067/#review125780 --- src/examples/long_lived_framework.cpp (lines 39 - 40)

Re: Review Request 45067: Updated the long-lived-framework example.

2016-03-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45067/#review125181 --- Patch looks great! Reviews applied: [45067] Passed command: expo

Re: Review Request 45067: Updated the long-lived-framework example.

2016-03-23 Thread Joseph Wu
> On March 18, 2016, 6:35 p.m., Neil Conway wrote: > > src/examples/long_lived_framework.cpp, line 135 > > > > > > Don't we need `TaskState_Name` here? Yeah, for some reason, I thought that used an internal header.

Re: Review Request 45067: Updated the long-lived-framework example.

2016-03-23 Thread Joseph Wu
> On March 18, 2016, 11:42 p.m., haosdent huang wrote: > > src/examples/long_lived_framework.cpp, line 168 > > > > > > I think use > > ``` > > if (flags.master.isNone()) { > > EXIT(EXIT_FAILURE) > >

Re: Review Request 45067: Updated the long-lived-framework example.

2016-03-23 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45067/ --- (Updated March 23, 2016, 3:50 p.m.) Review request for mesos, Anand Mazumdar, A

Re: Review Request 45067: Updated the long-lived-framework example.

2016-03-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45067/#review124425 --- Patch looks great! Reviews applied: [45067] Passed command: expo

Re: Review Request 45067: Updated the long-lived-framework example.

2016-03-18 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45067/#review124377 --- Fix it, then Ship it! Ship It! src/examples/long_lived_framew

Re: Review Request 45067: Updated the long-lived-framework example.

2016-03-18 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45067/#review124351 --- src/examples/long_lived_framework.cpp (line 102)

Review Request 45067: Updated the long-lived-framework example.

2016-03-18 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45067/ --- Review request for mesos, Anand Mazumdar, Artem Harutyunyan, and Kevin Klues. R