> On March 18, 2016, 6:35 p.m., Neil Conway wrote: > > src/examples/long_lived_framework.cpp, line 135 > > <https://reviews.apache.org/r/45067/diff/1/?file=1307190#file1307190line135> > > > > Don't we need `TaskState_Name` here?
Yeah, for some reason, I thought that used an internal header. Added it back. - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45067/#review124351 ----------------------------------------------------------- On March 23, 2016, 3:50 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45067/ > ----------------------------------------------------------- > > (Updated March 23, 2016, 3:50 p.m.) > > > Review request for mesos, Anand Mazumdar, Artem Harutyunyan, and Kevin Klues. > > > Repository: mesos > > > Description > ------- > > This gives the example `long-lived-framework` enough options to run outside > of the build environment. > > This also updates: > > * The style of the framework code. > * Gives the `ExecutorInfo` some resources (needed for some cgroups isolators). > * Restricts the framework to one agent. Otherwise, it would grab a small > chunk of every machine in the cluster. > * Adds filters for declined offers. > > > Diffs > ----- > > src/examples/long_lived_framework.cpp > 0000289a0b9dd3d1ce30f20dd9bb381126bff30c > > Diff: https://reviews.apache.org/r/45067/diff/ > > > Testing > ------- > > make check > > Ran this on the master node on a Mesos cluster: > ``` > ./long-lived-framework --master=zk://localhost:2181/mesos > --executor_uri="https://s3.amazonaws.com/url/to/long-lived-executor"; > --executor_command="LD_LIBRARY_PATH=/path/to/libmesos && > ./long-lived-executor" > ``` > > > Thanks, > > Joseph Wu > >
