Re: Review Request 45202: Add test for rescinding offer trriggered by updating weights.

2016-04-01 Thread Adam B
> On March 30, 2016, 4:58 a.m., Adam B wrote: > > src/tests/master_allocator_tests.cpp, line 1519 > > > > > > Don't you at least know that one of these parameters is the master's > > pid? > > Yongqiao Wang wrote:

Re: Review Request 45202: Add test for rescinding offer trriggered by updating weights.

2016-03-31 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45202/#review126281 --- Patch looks great! Reviews applied: [45202] Passed command: expo

Re: Review Request 45202: Add test for rescinding offer trriggered by updating weights.

2016-03-31 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45202/ --- (Updated March 31, 2016, 7:15 a.m.) Review request for mesos and Adam B. Chan

Re: Review Request 45202: Add test for rescinding offer trriggered by updating weights.

2016-03-31 Thread Yongqiao Wang
> On March 30, 2016, 11:58 a.m., Adam B wrote: > > src/tests/master_allocator_tests.cpp, line 1519 > > > > > > Don't you at least know that one of these parameters is the master's > > pid? Do you mean the paramete

Re: Review Request 45202: Add test for rescinding offer trriggered by updating weights.

2016-03-30 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45202/#review126083 --- Fix it, then Ship it! Some minor style suggestions, and then we

Re: Review Request 45202: Add test for rescinding offer trriggered by updating weights.

2016-03-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45202/#review125437 --- Patch looks great! Reviews applied: [44450, 45202] Passed comman

Re: Review Request 45202: Add test for rescinding offer trriggered by updating weights.

2016-03-25 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45202/ --- (Updated March 25, 2016, 9:13 a.m.) Review request for mesos and Adam B. Chan

Re: Review Request 45202: Add test for rescinding offer trriggered by updating weights.

2016-03-25 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45202/#review125395 --- Great test for the rescind patch! Just a few cleanup suggestions

Review Request 45202: Add test for rescinding offer trriggered by updating weights.

2016-03-23 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45202/ --- Review request for mesos and Adam B. Bugs: MESOS-4881 https://issues.apache